unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "João Távora" <joaotavora@gmail.com>
To: Jim Porter <jporterbugs@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>, 66041@debbugs.gnu.org
Subject: bug#66041: 30.0.50; Should 'flymake-note-echo' inherit from 'compilation-info'?
Date: Mon, 18 Sep 2023 19:49:21 +0100	[thread overview]
Message-ID: <CALDnm53Hpt6oxRGzETWLJtqf66zJVhjMK3FyKovpHu5qGH_AtA@mail.gmail.com> (raw)
In-Reply-To: <b2a4ceb7-3ebb-0f2a-86db-acb77c20c039@gmail.com>

On Mon, Sep 18, 2023 at 6:44 PM Jim Porter <jporterbugs@gmail.com> wrote:
>
> On 9/18/2023 5:52 AM, João Távora wrote:
> > Yes, something like that.  Skimming the code, I think I meant for only
> > one overlay, not two, to be the end-of-line overlay containing the two
> > strings.  But this was tricky to implement and I probably missed an
> > edge case.  There is a FIXME there, have to investigate.
> >
> > Anyway, since I have your interest, any suggestions on how you would
> > implement this? Knowing that this feature is upposed to display
> > multiple pieces of relatively short cursor-unreachable text visually
> > after the end -of-line (the text being the diagnostic text, naturally).
>
> For what it's worth, I think it would be nice to have a single overlay,
> showing only the highest-severity message, and if there are more, add a
> "(+ N more)" suffix. Then, assuming it's possible to implement, you
> could click/hover over it to get a popup of some sort with all the
> messages. That way you can't overload the UI with many messages (which
> in practice might all be from the same underlying problem in your code).

That's possible to implement.

But the single/multiple overlay decision is just an implementation detail
Currently Flymake uses one "end of line" overlay only, but here the logic
o control that uniqueness failed, so an extra unintended overlay was
created, and that created problems with cursor placement.

But your suggestion is noted, though.

João





  reply	other threads:[~2023-09-18 18:49 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-17  4:42 bug#66041: 30.0.50; Should 'flymake-note-echo' inherit from 'compilation-info'? Jim Porter
2023-09-17 21:22 ` João Távora
2023-09-17 21:54   ` Jim Porter
2023-09-17 22:15     ` João Távora
2023-09-18  4:36       ` Jim Porter
2023-09-18 10:44       ` Eli Zaretskii
2023-09-18 10:46         ` João Távora
2023-09-18 11:42           ` Eli Zaretskii
2023-09-18 12:52             ` João Távora
2023-09-18 14:32               ` Eli Zaretskii
2023-09-18 15:31                 ` João Távora
2023-09-18 17:29                   ` Eli Zaretskii
2023-09-18 18:55                     ` João Távora
2023-09-18 17:44               ` Jim Porter
2023-09-18 18:49                 ` João Távora [this message]
2023-09-18 19:00                   ` Jim Porter
2023-09-21 21:40                   ` João Távora
2023-09-24  3:38                     ` Jim Porter
2023-09-24  8:18                       ` João Távora
2023-09-25  8:59                         ` João Távora
2023-09-25 10:32                           ` Eli Zaretskii
2023-09-25 11:46                             ` João Távora
2023-09-25 12:08                               ` Eli Zaretskii
2023-09-25 12:12                                 ` João Távora
2023-09-25 12:49                                   ` Eli Zaretskii
2023-09-25 13:52                                     ` João Távora
2023-09-25 14:19                                       ` Eli Zaretskii
2023-09-25 16:55                                         ` João Távora
2023-09-25 17:23                                           ` Eli Zaretskii
2023-09-25 18:23                                             ` João Távora
2023-09-25 20:55                                               ` Jim Porter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALDnm53Hpt6oxRGzETWLJtqf66zJVhjMK3FyKovpHu5qGH_AtA@mail.gmail.com \
    --to=joaotavora@gmail.com \
    --cc=66041@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=jporterbugs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).