From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#70958: 30.0.50; eglot-managed-mode hooks not called on shutdown Date: Mon, 27 May 2024 13:35:13 +0100 Message-ID: References: <86y17yz5sr.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4335"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 70958@debbugs.gnu.org, Eli Zaretskii , Felician Nemeth , Stefan Monnier To: Troy Brown Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 27 14:37:15 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sBZbG-0000rm-Rn for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 27 May 2024 14:37:14 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sBZay-0006G1-SA; Mon, 27 May 2024 08:36:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sBZav-0006Et-Ct for bug-gnu-emacs@gnu.org; Mon, 27 May 2024 08:36:55 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sBZav-0005Aa-3W for bug-gnu-emacs@gnu.org; Mon, 27 May 2024 08:36:53 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sBZb3-0005Ud-P3 for bug-gnu-emacs@gnu.org; Mon, 27 May 2024 08:37:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 27 May 2024 12:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70958 X-GNU-PR-Package: emacs Original-Received: via spool by 70958-submit@debbugs.gnu.org id=B70958.171681340221089 (code B ref 70958); Mon, 27 May 2024 12:37:01 +0000 Original-Received: (at 70958) by debbugs.gnu.org; 27 May 2024 12:36:42 +0000 Original-Received: from localhost ([127.0.0.1]:43294 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sBZak-0005U4-3R for submit@debbugs.gnu.org; Mon, 27 May 2024 08:36:42 -0400 Original-Received: from mail-lf1-f51.google.com ([209.85.167.51]:57526) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sBZai-0005Ts-8p for 70958@debbugs.gnu.org; Mon, 27 May 2024 08:36:40 -0400 Original-Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-52965199234so3533798e87.2 for <70958@debbugs.gnu.org>; Mon, 27 May 2024 05:36:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716813325; x=1717418125; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Cc0vz8BliGVLuJIXXanQduGmNCaTUeNYZ/WYfT4OGoY=; b=S+TTw9nSAiTYKvIbEFijQvKVEiQHMQy5VSx12jSJg/34VVfSlShgSwiT0JRRKtwnpL 3mIsIhBFFoM1htjXAmcn1UHs/SIFHcnOIuZw/az4gWfimCoT6lbMz8bgCXOvNa06kgqX pB2MEmGjiH902MUKtIqtoEP1grLAXmlARxwCgRgmNTDaSqspU/lXkOxY4OE0o+nT7shJ 9pCNuj//wnqUc/Vz29f/oDEWCiAkQNAcIUmU1pDbpUxW9f7O+bFnz27Zu6FTvBFQh8PK HNMOYvZNO274lPnikre+9F7ik9N4KZEkkhSPHOG1aEjKl/4VjNjT30/1havXtiQoLR6j J5qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716813325; x=1717418125; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Cc0vz8BliGVLuJIXXanQduGmNCaTUeNYZ/WYfT4OGoY=; b=KYQdABzh0MCVNzKd6EsL2gXIifr3O3lpkk/H0U+RHVgRCFfUChM/lsdTNACQe+ho7p aQ3nIli2AesQ16oUeoC5yEgRc0UcaCNHbEmMvc3iMmIhyrNJMQoCBN118pJES08TCP9m 7FqNOucdNrxYhBp4IMJLpKnYx599+ic1TLMmGfHuBWZGX5zxZqnm+5XvZFgrhw2+gXie AjNjJeHStq/ZQEMQ+qfljPZ2HgFHNl995ARJR4XHuFHF/fZkUXSD+Kpt/JlzyQZ1ANZ9 oWHEUnwyojci1ixvdSbFknvZxquVMgS1X/Zdu9CPngNwk42FLkeXJUzOEws3OqxCnALZ XGUQ== X-Forwarded-Encrypted: i=1; AJvYcCXLnW04+x4UJSxoYWDNOcH8v6BNuHqkurg2bCjKfTXjXwF6lhTrGHF37eeFmyNtxKJhyd0ASMxDmVuUzpnSa/gvFKAhZH8= X-Gm-Message-State: AOJu0YzS+HqdcQzM4AKnsg9EAVaxOjs09O0dgnNDSFTcBFDFfKip74op MEOtczsvkIesX6LnV1SAfbNAp74esHyv/iAoT4W6SfpPitOkHMgY8saAnJc26wgSPBV4NGVqPGL c0QESEwZlRuF4T2SSdxTebMSxXkVMwA== X-Google-Smtp-Source: AGHT+IGBZ1deTdakGpNTu6PuhJpIJ7g3LTKFPJTxIddWmEX+EPhMCnrQ6ROdUMi1wBuUlLR0dC3qppkU92KgMK4mKIw= X-Received: by 2002:a05:6512:15a2:b0:523:8858:db81 with SMTP id 2adb3069b0e04-529649c5e7fmr7416814e87.22.1716813325325; Mon, 27 May 2024 05:35:25 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:286028 Archived-At: On Mon, May 27, 2024 at 1:29=E2=80=AFPM Troy Brown = wrote: > > On Sun, May 26, 2024 at 6:46=E2=80=AFPM Jo=C3=A3o T=C3=A1vora wrote: > > > > So when e-m-m-hook was added it was made to run only on "turn on" > > because that's where it was most needed. We can try changing Eglot > > to also run it on "turn off", but that is a backward incompatible > > change. > > > > If it was never intended to run on "turn off", then the comment string > for eglot-managed-mode-hook likely should be updated as it indicates > it is run when Eglot stops managing the buffer (i.e., "... run by > Eglot after it started/stopped managing a buffer"). Ah, so this is only a doc bug and you don't actually need it? If so, fine with me, just provide a trivial patch for that and I'm sure some will install it ASAP. Jo=C3=A3o