From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#42425: 26.3.50; Compilation warnings when compiling eldoc.el under Emacs 26.3 Date: Sat, 23 Jan 2021 17:53:48 +0000 Message-ID: References: <878s8kyc90.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29342"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen , 42425@debbugs.gnu.org To: Philipp Stephani , Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 23 18:55:55 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l3N8d-0007WC-2s for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 23 Jan 2021 18:55:55 +0100 Original-Received: from localhost ([::1]:38824 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l3N8c-00014u-56 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 23 Jan 2021 12:55:54 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39848) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l3N7n-000147-IL for bug-gnu-emacs@gnu.org; Sat, 23 Jan 2021 12:55:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51899) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l3N7l-00013V-Lm for bug-gnu-emacs@gnu.org; Sat, 23 Jan 2021 12:55:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l3N7l-0002wP-Ja for bug-gnu-emacs@gnu.org; Sat, 23 Jan 2021 12:55:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 Jan 2021 17:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42425 X-GNU-PR-Package: emacs Original-Received: via spool by 42425-submit@debbugs.gnu.org id=B42425.161142444711245 (code B ref 42425); Sat, 23 Jan 2021 17:55:01 +0000 Original-Received: (at 42425) by debbugs.gnu.org; 23 Jan 2021 17:54:07 +0000 Original-Received: from localhost ([127.0.0.1]:35212 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l3N6t-0002vJ-Hs for submit@debbugs.gnu.org; Sat, 23 Jan 2021 12:54:07 -0500 Original-Received: from mail-io1-f53.google.com ([209.85.166.53]:44541) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l3N6r-0002un-Kj for 42425@debbugs.gnu.org; Sat, 23 Jan 2021 12:54:06 -0500 Original-Received: by mail-io1-f53.google.com with SMTP id h11so17988106ioh.11 for <42425@debbugs.gnu.org>; Sat, 23 Jan 2021 09:54:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Uak3nbpy3Oyue8N+c0iscLI9QvHEuN1X5ieFQOJevkg=; b=S7po9GUuifPkZrgWuCOnzPDsrusbBsgdhwp415e0SW3vyeoVJlgTFqUgRH51xAIm9L poszX+WAWroTyJVRq/Sl54+SOXA7MKfABD6WgffyzuIFU8otwT3px9pweKjTKybJGih2 zTxbic4jkvZymAgSDBP4ItrrJg+Vb3Uaov6u2XUddtNqVBCwtdFBPooocLkYavwWyvQ8 mYrbMtJ9C7ux51iOthmNy/4zF5Vc64QaOyY34fgPOIip1+8m13c25EscQMCA84CihSdo G+UzT2Ce3CQarI2H/Lx/T18RbbV7y3Yy1L4GWZJGXpx1iqMHjMBMIbmGHqR3VOKMr/aJ JY8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Uak3nbpy3Oyue8N+c0iscLI9QvHEuN1X5ieFQOJevkg=; b=jAUxY8PnepjpJkzzxjOHCe1dHKWZjbg5/Smh4vSk34H4gVwZKa1d7jLHvAtrh8aGKS gB7uwVA8c6Bs8qG4LSJ6b1sLyfmMID7GMrZNei9zfePByTf4G69+Ifi/91GWxcDkfn5v aV4xb/Vj1K2yaehECvigf/qLFcUJa5v6MDP4UQ/PxW25JlSzW5HBatB3kM8kUo9E5BbE JBxViB1O+VjfcUDYm7lNu6aBwx9WOZOkvWBjNx73hIYYH5rQSCfNCtpk/t5RsS0pX7UI G+c10VfUKEkTLNZUBHO+JVNdbT5ZlM+NPwPEDOW3h2VD4ZLfKkEQwvw2nVnvsi4wBbbQ 4o0w== X-Gm-Message-State: AOAM532ygPXZfapkLq+aYomphlJ6k5frnczCn+jTsTzuWUnPvMpdMdzO w6zwATE6N94bCpCEB9EZW2BGYJx6AUu7eNgsKiU= X-Google-Smtp-Source: ABdhPJwZw4fa6ThpG2W2waDwte7b9w33TJ5KIKg43M5ijnWYs9chLqWQi6WixU0xPBoCRyHbe1Ez//mU7HPAxNYAm6g= X-Received: by 2002:a02:23c7:: with SMTP id u190mr261705jau.136.1611424439778; Sat, 23 Jan 2021 09:53:59 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:198442 Archived-At: On Sat, Jan 23, 2021 at 5:35 PM Philipp Stephani wr= ote: > > Am Fr., 22. Jan. 2021 um 20:58 Uhr schrieb Lars Ingebrigtsen : > > > > Philipp Stephani writes: > > > > > eldoc is now a separate package that claims to support Emacs 26.3. > > > However, compiling eldoc.el results in a few warnings: > > > > > > emacs -Q -batch -l bytecomp -f batch-byte-compile eldoc.el > > > > > > In eldoc--eval-expression-setup: > > > eldoc.el:236:9:Warning: assignment to free variable > > > =E2=80=98eldoc-documentation-strategy=E2=80=99 > > > > > > In eldoc--supported-p: > > > eldoc.el:615:19:Warning: reference to free variable > > > =E2=80=98eldoc-documentation-strategy=E2=80=99 > > > > > > In eldoc--invoke-strategy: > > > eldoc.el:732:28:Warning: reference to free variable > > > =E2=80=98eldoc-documentation-strategy=E2=80=99 > > > > > > In end of data: > > > eldoc.el:804:1:Warning: the following functions are not known to be d= efined: > > > elisp-eldoc-var-docstring, elisp-eldoc-funcall > > > > > > 1. Probably the definition of `eldoc-documentation-strategy' needs to= be > > > moved before its first use. > > > > Doing so seems easy enough, but I'm not sure how high our ambitions are > > for doing warning-free ELPA packages on older Emacs versions? (I've > > added Jo=C3=A3o to the CCs.) > > I think our ambitions should be quite high. (I personally think we > should treat almost all compiler warnings as errors/bugs and fix them > whenever realistically possible.) I agree, but with strong emphasis on the realism bit. So if you can fix th= is and not break the master, 28 + ELPA, 27.1 + ELPA, 26.3 + ELPA cases, I'm fine with it. Just noting that shushing a warning is not the same as "fixing" it, but of course you know that. I remember there being extra trouble because eldoc.el is preloaded (because it is required by elisp-mode.el, which is also preloaded). Maybe the warnings you are bringing up have nothing to do with this, though. Another note, it must compile in version X and load in that version X. This has to be able to happen in the same session or in separate sessions. so you have 4 test cases per version. When aliasing some variables for backward compat, there were problems because of that. I think the direction of the alias is different in 26 and = 27, or something like that. In practice it makes no difference: code referenci= ng that name points to the same thing, though the thing is different in 26 and= 27. Extra credit if you can avoid pre-loading Eldoc altogether. CC'in Stefan cause I think he had some input on that (sorry for the noise if I'm mistaken,Stefan). Good luck, Jo=C3=A3o