From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#34294: 27.0.50; flymake-start-on-save-buffer has no effect Date: Mon, 18 Mar 2019 21:43:05 +0000 Message-ID: References: <87lg2x6fox.fsf@mail.linkov.net> <87h8dkk3ho.fsf@mail.linkov.net> <87y36w8qvy.fsf@gmail.com> <87o97ruu06.fsf@mail.linkov.net> <87bm3rxjkd.fsf@gmail.com> <87k1hy19ug.fsf@mail.linkov.net> <87d0mn3op7.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="235457"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 34294@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Mar 18 22:44:18 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h603L-000z59-JU for geb-bug-gnu-emacs@m.gmane.org; Mon, 18 Mar 2019 22:44:15 +0100 Original-Received: from localhost ([127.0.0.1]:47929 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h603K-00031e-Fh for geb-bug-gnu-emacs@m.gmane.org; Mon, 18 Mar 2019 17:44:14 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:38593) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h6038-0002za-RZ for bug-gnu-emacs@gnu.org; Mon, 18 Mar 2019 17:44:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h6038-0000VQ-5x for bug-gnu-emacs@gnu.org; Mon, 18 Mar 2019 17:44:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35755) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h6037-0000VA-SA for bug-gnu-emacs@gnu.org; Mon, 18 Mar 2019 17:44:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h6037-00075L-KJ for bug-gnu-emacs@gnu.org; Mon, 18 Mar 2019 17:44:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Mar 2019 21:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34294 X-GNU-PR-Package: emacs Original-Received: via spool by 34294-submit@debbugs.gnu.org id=B34294.155294540627169 (code B ref 34294); Mon, 18 Mar 2019 21:44:01 +0000 Original-Received: (at 34294) by debbugs.gnu.org; 18 Mar 2019 21:43:26 +0000 Original-Received: from localhost ([127.0.0.1]:49296 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h602X-000749-En for submit@debbugs.gnu.org; Mon, 18 Mar 2019 17:43:25 -0400 Original-Received: from mail-qt1-f172.google.com ([209.85.160.172]:45735) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h602V-00073s-4n for 34294@debbugs.gnu.org; Mon, 18 Mar 2019 17:43:23 -0400 Original-Received: by mail-qt1-f172.google.com with SMTP id v20so19835517qtv.12 for <34294@debbugs.gnu.org>; Mon, 18 Mar 2019 14:43:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=9KK/lxmM7Yznle4puMhvxwXPxWH2LHFbf3scdD+uD8Q=; b=QwSx91eZdN8YbXqkgjyQCdmnMOoCVjnOuu8RYFQIIyHDMS8QA/Rneavzzm/bTTh1WG tHVRjPjG0sFVT4V3cPF28cO8sN32yA6hNOJ+SZA/zABqpz7Oj3RFNwzPdVpr0cdOCrgB Bs4JS9DlkIHTZVTr7piIS73b55IJ68ZuRW8NM6/kF+XDSckVVomR6qKZPAd1QaZfDSLa NI9rSf0BKb/qKVn527qgnYfL7A7lEBMe374bIUY15J5LuD4r7tjkjqG4y2Wwz6jlbSFD Gik5I1J00kZEc1YKPUwIVKl9r2yo5TY8fWrzfQxATAkfbVXnbcWdk72AVyM2S+RJ340l g7Jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=9KK/lxmM7Yznle4puMhvxwXPxWH2LHFbf3scdD+uD8Q=; b=Qt6eCCV+hh+6460v+mFElYI5DqFtXPL8Efn3o5eyOR9K1tO9gcsjq0GK479YH2vl3G 9M9yaFxT8BEsc3hg4mg+HtmF+X+6qYHBI1/XqMHxRarnZC0iI+YLglPMuBNs0YWWDPXt CfW6B3ifJ7qSyR9/SExFYmnYeuPkDiITApe9vNfqWOFCUn1nYPKjnu9D438Rr2/QkUpN gqstdhiyEDKjtvWCF+LZZk7JmjIBOY+kBg5C4+m+WtPufvwxvRbZcUL3fUpkqNhoxcCP F4RG5GM7wre02/4RFSLMTzLy3JEDo80oBtPWgmCw1GBimfh+pDfMDoDBCbb4aobXS6q/ 1wZw== X-Gm-Message-State: APjAAAVE5FXALUcPZPd+x/1N7gwKCNSxIN8Jsrw4mhESfJwPjfU1rJDS /frAa9iPxq11fZheDCPKMvUQLHJ/CeaU7ENJKrU= X-Google-Smtp-Source: APXvYqxP4szOWhwz8TwwScUBFUKPzQbFqbkscU7+FubNkEOcmIFxR6j940CNDuEwg9+PhO4j334V7cJ7Ah+ZA78XBPU= X-Received: by 2002:a0c:d401:: with SMTP id t1mr14341336qvh.38.1552945397408; Mon, 18 Mar 2019 14:43:17 -0700 (PDT) In-Reply-To: <87d0mn3op7.fsf@mail.linkov.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:156471 Archived-At: On Mon, Mar 18, 2019 at 9:23 PM Juri Linkov wrote: > Jo=C3=A3o, if you are not very busy atm, could you please look at this pa= tch. It looks good to me. I just have a suggestion and would like to see the commit msg, too. > > -(defcustom flymake-start-syntax-check-on-newline t > > +(define-obsolete-variable-alias 'flymake-start-syntax-check-on-newline > > + 'flymake-start-on-newline "27.1") > > + > > +(defcustom flymake-start-on-newline t > > "Start syntax check if newline char was added/removed from the buffe= r." > > :type 'boolean) I think we should change this to default to nil. I would even go as far as obsoleting the variable entirely, and use make-obsolete-variable instead: there's no real reason why newline should be given special treatment. And users that need this for some obscure reason can probably plug it in post-self-insert-hook. If you obsolete the variable, you can remove it from the manual, too. --=20 Jo=C3=A3o T=C3=A1vora