From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#62720: 29.0.60; Not easy at all to upgrade :core packages like Eglot Date: Tue, 18 Apr 2023 21:56:43 +0100 Message-ID: References: <87a5zj2vfo.fsf@gmail.com> <834jpk5hih.fsf@gnu.org> <871qkom3fj.fsf@posteo.net> <83mt3b4yfc.fsf@gnu.org> <87edonlsxi.fsf@posteo.net> <83jzyf4vzb.fsf@gnu.org> <871qknllkj.fsf@posteo.net> <83fs934pjf.fsf@gnu.org> <87wn2fk47y.fsf@posteo.net> <83sfd2g2ek.fsf@gnu.org> <875y9yfxrr.fsf@gmail.com> <87y1muefks.fsf@gmail.com> <834jpifizy.fsf@gnu.org> <83y1mue1qi.fsf@gnu.org> <83sfd2e01f.fsf@gnu.org> <1a5e5837-513b-84d8-3260-cdbf42b71267@gutov.dev> <83sfcz9rf2.fsf@gnu.org> <09a49ab9-ac72-36a9-3e68-9c633710eba7@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23807"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62720@debbugs.gnu.org, rpluim@gmail.com, philipk@posteo.net, monnier@iro.umontreal.ca, Eli Zaretskii , larsi@gnus.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Apr 18 22:55:31 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1posMN-0005yr-C2 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 18 Apr 2023 22:55:31 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1posM0-0007oF-P3; Tue, 18 Apr 2023 16:55:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1posLv-0007o6-19 for bug-gnu-emacs@gnu.org; Tue, 18 Apr 2023 16:55:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1posLu-00010C-OW for bug-gnu-emacs@gnu.org; Tue, 18 Apr 2023 16:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1posLu-0007gZ-4t for bug-gnu-emacs@gnu.org; Tue, 18 Apr 2023 16:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 18 Apr 2023 20:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62720 X-GNU-PR-Package: emacs Original-Received: via spool by 62720-submit@debbugs.gnu.org id=B62720.168185129929520 (code B ref 62720); Tue, 18 Apr 2023 20:55:02 +0000 Original-Received: (at 62720) by debbugs.gnu.org; 18 Apr 2023 20:54:59 +0000 Original-Received: from localhost ([127.0.0.1]:60545 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1posLr-0007g1-2O for submit@debbugs.gnu.org; Tue, 18 Apr 2023 16:54:59 -0400 Original-Received: from mail-oa1-f46.google.com ([209.85.160.46]:51705) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1posLm-0007ez-RK for 62720@debbugs.gnu.org; Tue, 18 Apr 2023 16:54:58 -0400 Original-Received: by mail-oa1-f46.google.com with SMTP id 586e51a60fabf-18785f07525so507173fac.3 for <62720@debbugs.gnu.org>; Tue, 18 Apr 2023 13:54:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681851289; x=1684443289; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=be/M1cJAJEtkV4/Ir0/ZnXClFPzglrhIUiZARYOpgS8=; b=aI6ecUBUlG3s2WwtTjL7td9FcG3Rys5XUpvJwciPQSvWABvhNv5OqAmzlQabI9cw+z ZD5RgZujK9WVkscDXLd4u9sjv7ePCvRDQKSgfliRf+W5q03a/XFh60UDJw7XLcuvV6YF xIVt9vA/wrsGQaBPXKecQbq5aKzKg3WDyoOMpe1hVjWlYO9XmEFnOjBClBXDhNuqKjaT rbCz5Vo32SyE8rIGsf5fbkJgJb+CMUnu/mEtIK2YOfDnd74Utnqt/IgXd9WPC3oflegu UBX+lB78PRtItZDwDhxwPbeAKaLtxRx7TW6Tj+l2bkpwj6rCIp050W8KSOFcJq03ECpt MAaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681851289; x=1684443289; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=be/M1cJAJEtkV4/Ir0/ZnXClFPzglrhIUiZARYOpgS8=; b=WPlW7p3bwnwwAcdFZT7NsAbzaEPijlbXVpzT/eUn17FY5dWsMVApQW3/zbYc0X0bmT /uYONFuW5ByETDg8qi7iDDpFX7XLGPJEU7c6ZPyE66GAC0Y4F1keKwA3M8yyWTI75Zg+ L/hXDw9q3VTKDi66oz/mD3sK2hTZ/60IJ2Df4+pNVjHlbEIvtiRu1qM1OJ9Ez7VAxgOy qnRETdKUzMOee7jRsaL6q1AEUrE/r0tdG98XcPrnRm0VnMD/rKSHbmVqNO3Kbgkc803E +eXXYy/8bRERkfM3OFLomZplHz71K34doTYIxB7xCb2vLGNkJeYzHLV55k73c/O+N+pU VzLQ== X-Gm-Message-State: AAQBX9ezPI/Xxzwd1LsvdLfJdH7NJLC3KKCPpBMP95iNp+BCKrQNfN6G /Hn8JG5DjOT6B8Fn4hr4BsUKCA5fzt7P8Z4in2Y= X-Google-Smtp-Source: AKy350a794nG9mjLCINNy3e7L/KO5fZqOhm2ODH8fKDrvCrqKVHh/IY3rbS1W/UGCTRK3eodfY9jsQazH9aAp1N9Ooo= X-Received: by 2002:a05:6870:3906:b0:187:9bf2:af63 with SMTP id b6-20020a056870390600b001879bf2af63mr1716952oap.5.1681851289112; Tue, 18 Apr 2023 13:54:49 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:260239 Archived-At: On Tue, Apr 18, 2023 at 9:38=E2=80=AFPM Dmitry Gutov wro= te: > This particular one didn't have to, but it's a problem very > characteristic of joining a strongly centralized project with ultimately > one person having the last word in all major decisions. And it's not > like Eli is being unreasonable: we do need a stability cutoff, and we're > really long past it. These one-more-change kind of arguments repeat year > over year, with reasonable, well-intentioned people on both sides. Yes. And here both people sides "one more change". The change that _did_ make it in is more aggressive and more unstable than the one that didn't. And I repeat it didn't (and doesn't) have to be like this for Eglot and Emacs 29. It could have been a minor decision, not a "major" one. > Sure, and I agree, but I don't really see how to present that in terms > Eli would feel suitable to accept. One "trick" that worked in the past > was to somehow enumerate all potential execution flows (functions > involved, etc) that would be affected by the change. Right. And IMO it's not a "trick", it's how it should be. It's hard to pr= ove a negative, but at least it should be attempted. Well, the patch I presented (the one you +1'ed) makes it so that package-install keeps exactly its prev= ious behaviour unless its argument is one of (eglot use-package), which are argu= ments that could not have ever been passed to that function as :core packages in Emacs 28. M-x package-install RET seq or (package-install 'xref) keep EX= ACTLY the same behaviour. It's very clear to see from the minimal patch. > I don't insist, not at all. It was just my own impression of what would > constitute a reasonable Eglot release that we could be satisfied with > having a large number of people use without upgrading, for years. Issues > like blinking eldoc messages, or eldoc messages that can take up half > the height of the window seem like things that we wouldn't want in it. The issue has existed and has been worked around successfully for a long period of time. It's not actually a problem, it's a consequence of the default values for eldoc-echo-area-use-multiline-p and max-mini-window-heig= ht, both of which predate Eglot. Of course I think the current behaviour is better. But it's also different= so I don't think we should backport that particular one. Even if so far the only feedback we have had has been positive, it could well be that some people _liked_ the half-the-window-height thing (after all their customizat= ion options reflected that wish, even if by default). And by the way, not really half-the-window. I used this for a long time without being much bothered by it. > Perhaps the second issue affects only a minority of servers, and I'm > wrong to be worried. Because otherwise, I really don't understand why it > hasn't been reported and fixed until recently. Not blaming you, just to > be clear. It was reported a long time ago. By you and others. But there wasn't the means -- or rather the energy from my part -- to fix it. I couldn't just have truncated that information. So I enhanced ElDoc instead with the :echo option. Jo=C3=A3o