From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#53853: [PATCH] Don't use string-replace in flymake Date: Tue, 8 Feb 2022 09:52:34 +0000 Message-ID: References: <87r18e7fb7.fsf@gmail.com> <87zgn1ublj.fsf@gnus.org> <87mtj17oqg.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000eb2c8105d77eaa67" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32438"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Brian Leung , Lars Ingebrigtsen , 53853@debbugs.gnu.org To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Feb 08 10:53:14 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nHNBR-0008DV-Ld for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 08 Feb 2022 10:53:13 +0100 Original-Received: from localhost ([::1]:56596 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nHNBQ-0002B9-Mm for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 08 Feb 2022 04:53:12 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:34624) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nHNBG-00027m-E8 for bug-gnu-emacs@gnu.org; Tue, 08 Feb 2022 04:53:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51449) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nHNBG-0000Dv-4L for bug-gnu-emacs@gnu.org; Tue, 08 Feb 2022 04:53:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nHNBG-00057a-3p for bug-gnu-emacs@gnu.org; Tue, 08 Feb 2022 04:53:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Feb 2022 09:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53853 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 53853-submit@debbugs.gnu.org id=B53853.164431392619611 (code B ref 53853); Tue, 08 Feb 2022 09:53:02 +0000 Original-Received: (at 53853) by debbugs.gnu.org; 8 Feb 2022 09:52:06 +0000 Original-Received: from localhost ([127.0.0.1]:45346 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nHNAL-00056F-Q6 for submit@debbugs.gnu.org; Tue, 08 Feb 2022 04:52:06 -0500 Original-Received: from mail-ot1-f44.google.com ([209.85.210.44]:42629) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nHNAI-00055Y-KK for 53853@debbugs.gnu.org; Tue, 08 Feb 2022 04:52:04 -0500 Original-Received: by mail-ot1-f44.google.com with SMTP id p3-20020a0568301d4300b005a7a702f921so12830236oth.9 for <53853@debbugs.gnu.org>; Tue, 08 Feb 2022 01:52:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ucCF37zWAfUSMnLGpkZhKUFTuyK28uXFQWexMcbnMxQ=; b=jxBgiJ5b8ilt9ZZei8BzyaheD5ouOY5ANuxJ1m0IIMsfmCEXNtaho+Z6Fc/j+/FlvU XC4I9H5osJt6FuyT2W+3wmMvxCmZutKSkxNd4RhFk9m7n00c1bqQHxSRIz1u2sj5wnAk isZcBFIZzJE40HveniEdZCfFhtoyhOQ1tC07tfAH4Fy5NL1H8UZNoRs9fFu3k777Gl6s CFYz5+iaPMqPwx0qDB1lKM5K2AYoi49odyx+1hytxFFCmUV9hnR+4sNsTt6m4Ij6Dx8c TJosJ3m2P6hAXKRDCHrNegXiQwEA9jqogvbKQ22cKaKvqcpuAfN3K/zkBWrCD3/l1/nG rlzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ucCF37zWAfUSMnLGpkZhKUFTuyK28uXFQWexMcbnMxQ=; b=0dabQ5tY5Se+Zjpx0R88nztzGsUGiRt374v/95HA2o/ohAS+5zafZZmYkGXlN/qdd/ KMQJQQRZksTMvWkoc0R8ptNNMSjg95nLnR4n/74F5F14Fo3yQbcY6mozAOi1cYWFOOU/ Nut77ld5qe4XNNBd46bxDhfVdM1NZHv/dGGf/HT90OrwM91V9LpJ/7JJ605SZWpyq4oQ CAiqQxdZjV+p3hgI2LjeadoUNDNl7Cnehz5ymJWzphpks9lw5PmCtpi3eN9xVd9IC52F RRyXWe2vcup4IUNWOUhLejQPa9r19atGPgUKQLuMs/5LdTD/9Pjqrqu2Z63iBqRapp5q TJeg== X-Gm-Message-State: AOAM531HGuv5T5YRcc8EXyc9KDrN+nUyGiO3CmqEoa4awsdf9pz4WCYv lcFHRn6lqICwObNQiIevYrOFgb7DrJqiYTf2VOk= X-Google-Smtp-Source: ABdhPJygbB/AcBHhGmF1kw6ECklNNPZyX8WvrqOGq4WL4Zvi0l69m/yLGyAZXU4rQuat8jgevMtAk0+R5dTE1R2hyc4= X-Received: by 2002:a9d:4806:: with SMTP id c6mr1456434otf.317.1644313916942; Tue, 08 Feb 2022 01:51:56 -0800 (PST) In-Reply-To: <87mtj17oqg.fsf@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:226344 Archived-At: --000000000000eb2c8105d77eaa67 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Feb 8, 2022 at 9:26 AM Robert Pluim wrote: > >>>>> On Tue, 08 Feb 2022 07:16:40 +0100, Lars Ingebrigtsen < > larsi@gnus.org> said: > > Lars> Brian Leung writes: > >> OK, I've updated the patch per your suggestions. I've also made th= e > >> commit apply to the emacs-28 branch, as opposed to the master > branch. > > Lars> Thanks; pushed to emacs-28. > > I=CA=BCm not au fait with how core packages work, does this require a bum= p > in flymake's package version? Yes, Robert, I believe so. Else the core package won't get regenerated into GNU ELPA. What _doesn't_ require a bump is, for example, `eglot.el` usage of it. So if you bump flymake.el to, say, 1.9 now and eglot.el is still asking for 1.8, I think package.el will pull in the latest one regardless and the problem for eglot.el users will be fixed. I suspect though, that this problem only happened because the user was usin= g the straight.el package manager, which will try to fetch the very latest (i.e. not go through GNU ELPA as package.el does). Anyway, thanks for fixing this. Jo=C3=A3o --000000000000eb2c8105d77eaa67 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Tue, Feb 8, 2022 at 9:26 AM Robert Pluim <rpluim@gmail.com> wrote:
>>>>> On Tue, 08 Feb 2022 0= 7:16:40 +0100, Lars Ingebrigtsen <larsi@gnus.org> said:

=C2=A0 =C2=A0 Lars> Brian Leung <leungbk@posteo.net> writes:
=C2=A0 =C2=A0 >> OK, I've updated the patch per your suggestions.= I've also made the
=C2=A0 =C2=A0 >> commit apply to the emacs-28 branch, as opposed to t= he master branch.

=C2=A0 =C2=A0 Lars> Thanks; pushed to emacs-28.

I=CA=BCm not au fait with how core packages work, does this require a bump<= br> in flymake's package version?

Yes, Robe= rt, I believe so. Else the core package won't get regenerated into GNU = ELPA.

What _doesn't_ require a bump is, for ex= ample, `eglot.el` usage of it.=C2=A0 So if you
bump flymake.= el to, say, 1.9 now and eglot.el is still asking for 1.8, I think package.e= l
will pull in the latest one regardless and the problem for eglo= t.el users will be fixed.

I suspect though, that t= his problem only happened because the user was using
the straight= .el package manager, which will try to fetch the very latest (i.e.
not go through GNU ELPA as package.el does).

Anyway, thanks for fixing this.
Jo=C3=A3o
--000000000000eb2c8105d77eaa67--