unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "João Távora" <joaotavora@gmail.com>
To: Joost Kremers <joostkremers@fastmail.fm>
Cc: 73355@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>
Subject: bug#73355: 29.4; eglot-rename reports success when it shouldn't
Date: Sat, 21 Sep 2024 23:31:43 +0100	[thread overview]
Message-ID: <CALDnm534sTruDPQq4=1T8PBFEhgRCk+7HwxBxH3B_sebCTVMmw@mail.gmail.com> (raw)
In-Reply-To: <86plowslx7.fsf@fastmail.fm>

On Sat, Sep 21, 2024 at 11:04 PM Joost Kremers <joostkremers@fastmail.fm> wrote:

> Ah, OK, I didn't realise that. So does the server report it made 0 edits?

I don't know, you haven't supplied that part of the report yet.

> If it does, would it make sense to have Eglot say no changes were made?

Maybe.  Some sense. But IMO it would make even more sense for the
server to error out.





  reply	other threads:[~2024-09-21 22:31 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-19 12:01 bug#73355: 29.4; eglot-rename reports success when it shouldn't Joost Kremers
2024-09-19 16:07 ` Joost Kremers
2024-09-21 10:34 ` Eli Zaretskii
2024-09-21 11:43   ` João Távora
2024-09-21 12:12     ` Joost Kremers
2024-09-21 20:15       ` João Távora
2024-09-21 22:04         ` Joost Kremers
2024-09-21 22:31           ` João Távora [this message]
2024-09-21 22:46     ` Joost Kremers
2024-10-05  9:57       ` Eli Zaretskii
2024-10-19  7:03         ` Eli Zaretskii
2024-11-02 11:43           ` Eli Zaretskii
2024-11-02 13:26             ` João Távora

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALDnm534sTruDPQq4=1T8PBFEhgRCk+7HwxBxH3B_sebCTVMmw@mail.gmail.com' \
    --to=joaotavora@gmail.com \
    --cc=73355@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=joostkremers@fastmail.fm \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).