From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#47711: bug#48841: bug#47711: bug#48841: bug#47711: [PATCH VERSION 2] Add new `completion-filter-completions` API and deferred highlighting Date: Thu, 2 Nov 2023 15:24:05 +0000 Message-ID: References: <328f87eb-6474-1442-e1ca-9ae8deb2a84a@yandex.ru> <83fsvcbio7.fsf@gnu.org> <9f432d18-e70f-54c1-0173-1899fb66d176@gutov.dev> <877cnafv39.fsf@gmail.com> <9447dde3-b8e7-2ec0-9a9c-72c4cf9d12a8@gutov.dev> <7d14bc13-4419-816c-5708-c42988c39c02@gutov.dev> <5d0a78cc-4fa0-ef04-3462-1826f17d7d56@gutov.dev> <877cn8asud.fsf@gmail.com> <8734xtauqj.fsf@gmail.com> <5181f95e-61e7-c8c4-6389-44ee57e0c749@gutov.dev> <31cadbfd-d086-a04f-0ed9-17ce70b4282c@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20065"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Daniel Mendler , Eli Zaretskii , Stefan Monnier , 47711@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 02 16:25:02 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qyZZ7-0004zQ-OO for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 02 Nov 2023 16:25:01 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qyZYb-0002gq-Ap; Thu, 02 Nov 2023 11:24:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qyZYZ-0002gH-VY for bug-gnu-emacs@gnu.org; Thu, 02 Nov 2023 11:24:28 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qyZYZ-000668-MJ for bug-gnu-emacs@gnu.org; Thu, 02 Nov 2023 11:24:27 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qyZZ8-0006mQ-Kw for bug-gnu-emacs@gnu.org; Thu, 02 Nov 2023 11:25:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Nov 2023 15:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47711 X-GNU-PR-Package: emacs Original-Received: via spool by 47711-submit@debbugs.gnu.org id=B47711.169893870126048 (code B ref 47711); Thu, 02 Nov 2023 15:25:02 +0000 Original-Received: (at 47711) by debbugs.gnu.org; 2 Nov 2023 15:25:01 +0000 Original-Received: from localhost ([127.0.0.1]:55808 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qyZZ7-0006ly-6k for submit@debbugs.gnu.org; Thu, 02 Nov 2023 11:25:01 -0400 Original-Received: from mail-lf1-x12a.google.com ([2a00:1450:4864:20::12a]:47545) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qyZZ4-0006lT-Gn for 47711@debbugs.gnu.org; Thu, 02 Nov 2023 11:25:00 -0400 Original-Received: by mail-lf1-x12a.google.com with SMTP id 2adb3069b0e04-50930f126b1so1245516e87.3 for <47711@debbugs.gnu.org>; Thu, 02 Nov 2023 08:24:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698938657; x=1699543457; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=pDB5mgfgXIy8RtAvHbdKj50e+WyAV3ny+1tn1LTTWSU=; b=QTHftTPWBmyN5t6hCGO09aWlcRcIHVBmftB5wS/BNmvgyfmDjguFJOl/iv4HLO+JQd mV6wefq1TNu0nESCrnbYGgLIzxjb+JK5YFu6ih9BUwSBWe46tosuXTYCHwD1sAj3wfVp DTq0b83C/IXXfwJxObKNpnxDxA3HHqgfKigiYhAnmfhKusUh6YUTkcw8MkO5aPaSv3s9 UelxkTT2nQCv+REMee3dOoPhVvr1fkrIkrabwR46Rr0Je9NTZoHYDgcLD4q2pjll6A+1 f6SozFAtWv8Eveajhifs7fVpOAjfb2ub5jMubPQRvRR1JCKJ1gEnzgnqULCkdGlFv9q+ CmqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698938657; x=1699543457; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pDB5mgfgXIy8RtAvHbdKj50e+WyAV3ny+1tn1LTTWSU=; b=iuHh3qqvGrGmlZrWEx83s0oH/ZwYu2rpHYiO9QfJ84nhsEL0QdtT+2lQue3qgLxbte dFddXtHcfeKFM0k21D+FdUJSC4I1MO45az//spgF1PTBDErXAHHbIdwnV2gQERK55Z0s QsCYvHMeYjocxdFtHcmbhE5OH/PAF+SSwle5RmyKBZa3gqODlHR5jyvbIJMlcUHu5OMo SpP3DKz25uLLd7vMsGr8k0Fzf41Aa7+DVRuKJOfIfF08aOmsiJj3NRx5s+tN4ZhyO5Kb 9+eoy/53MlPwFEC4MVIQaVNMlng/kqU2cghlapUkN+Xuus8oC3kH18P9xViHLZ4tCHEe bsqQ== X-Gm-Message-State: AOJu0YwWa7c3s2bE5+evmjFQ7LaNOTN+GQGlqJRYL2v5NIZ8iVfys+dE Q34xagmBjy5PgpgOvwPSQq48QabGm8t9TLLXv7M= X-Google-Smtp-Source: AGHT+IFS7WLV6LekPrxpETWnlYnGQgm3PPrGLp9wk0JGMpWC1bBe5lW5zdRcpvEVrvUYZ4/j/MJ16zeR0OI3eadzAic= X-Received: by 2002:a05:6512:60f:b0:507:a9ae:5c2 with SMTP id b15-20020a056512060f00b00507a9ae05c2mr14295177lfe.44.1698938657118; Thu, 02 Nov 2023 08:24:17 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:273653 Archived-At: On Thu, Nov 2, 2023 at 2:40=E2=80=AFPM Dmitry Gutov wrot= e: > IOW, this whole approach results in stricter matching with fewer > results, so a smarter sort isn't that necessary. Just curious, so in orderless, what do I type to quickly select M-x vc-diff or M-x vc-version-diff or M-x vc-ediff? In flex I just type "vcdiff" and these results normally bubble to the top. > > I addressed all your docstring suggestions, fixed a bug and significant= ly > > simplified the code in the latest version of the patch. I also > > removed the instrumentation in icomplete.el. Patch attached here > > and pushed to feature/completion-lazy-hilit. > > Thank you. I don't see that the bug was, but deferring the scoring even > in the eager highlighting case looks sensible (why not, indeed, if the > performance is no worse). The bug was in the eager highlighting case. Wasn't sorting at all. Jo=C3=A3o