From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#47711: bug#48841: bug#47711: bug#48841: bug#47711: [PATCH VERSION 2] Add new `completion-filter-completions` API and deferred highlighting Date: Tue, 7 Nov 2023 12:13:05 +0000 Message-ID: References: <328f87eb-6474-1442-e1ca-9ae8deb2a84a@yandex.ru> <83fsvcbio7.fsf@gnu.org> <9f432d18-e70f-54c1-0173-1899fb66d176@gutov.dev> <877cnafv39.fsf@gmail.com> <9447dde3-b8e7-2ec0-9a9c-72c4cf9d12a8@gutov.dev> <7d14bc13-4419-816c-5708-c42988c39c02@gutov.dev> <5d0a78cc-4fa0-ef04-3462-1826f17d7d56@gutov.dev> <877cn8asud.fsf@gmail.com> <8734xtauqj.fsf@gmail.com> <5181f95e-61e7-c8c4-6389-44ee57e0c749@gutov.dev> <31cadbfd-d086-a04f-0ed9-17ce70b4282c@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2539"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Daniel Mendler , Eli Zaretskii , Stefan Monnier , 47711@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 07 13:14:41 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r0Kyf-0000Sj-JX for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 07 Nov 2023 13:14:41 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r0KyQ-0007zJ-Ak; Tue, 07 Nov 2023 07:14:26 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r0KyO-0007xP-U7 for bug-gnu-emacs@gnu.org; Tue, 07 Nov 2023 07:14:24 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r0KyO-0002Yv-Lh for bug-gnu-emacs@gnu.org; Tue, 07 Nov 2023 07:14:24 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r0Kz0-00086n-FF for bug-gnu-emacs@gnu.org; Tue, 07 Nov 2023 07:15:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 Nov 2023 12:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47711 X-GNU-PR-Package: emacs Original-Received: via spool by 47711-submit@debbugs.gnu.org id=B47711.169935924331076 (code B ref 47711); Tue, 07 Nov 2023 12:15:02 +0000 Original-Received: (at 47711) by debbugs.gnu.org; 7 Nov 2023 12:14:03 +0000 Original-Received: from localhost ([127.0.0.1]:41398 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r0Ky3-00085A-1K for submit@debbugs.gnu.org; Tue, 07 Nov 2023 07:14:03 -0500 Original-Received: from mail-lf1-x12b.google.com ([2a00:1450:4864:20::12b]:46518) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r0Ky1-00084T-Ba for 47711@debbugs.gnu.org; Tue, 07 Nov 2023 07:14:02 -0500 Original-Received: by mail-lf1-x12b.google.com with SMTP id 2adb3069b0e04-507e85ebf50so6920353e87.1 for <47711@debbugs.gnu.org>; Tue, 07 Nov 2023 04:13:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699359197; x=1699963997; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=vgiMu1AMcTgicKCCRb4bMzWPu6AUcTX5hSbH59MrO+I=; b=aHocNeDeAdvD9fRxIoE3TRt427NJ6I9mbFFcvcKfeWDwxq/aN5Dux0rsamkdGvMWwP 9T8ePq1H0Fw0ftvRaui0j3DviuUBPUx7oDRyT6C9amPczIOG7ITW8H0Jq8ad9AGJcZ7E hTgs7aL/K9aEaEWhGzker8Bqy3Mm/aZQSwRz+6xxP43iKuTswO0nbBftNpyHqWjHa3Aa jHceeQyLP3XWvalYzRuZJ4Lwm4Df0/SvKT4SfCTRSuIjtpyQMWH7yCvf3QUlIWdMDT7q Tvy57eZ/5jWNhwkw/us/pRX6KwrCVDnjs2cq51eF1LxMxTyS/frRl0UZ6BscWOnKqOrj PtiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699359197; x=1699963997; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vgiMu1AMcTgicKCCRb4bMzWPu6AUcTX5hSbH59MrO+I=; b=ubBB1LSOpReWkenp3/Ggpjx3ZLSqbi6mHlA1mno0dm4KsYmxR1clqkTzt6Q7v0KCCi BYkRIhU5w+zgRNs2KvmKjh1c1gQTrQfbc0ASn53yBlepJkfAxvOVF1bU5aNq5uk6ymbM H3LpeRDLgw4rwSA1FO16843xb4vRk8fuGSrTDIahKura1GBA3zDOjjR3RxqN830TWCSE 8ESO41XkgeeoY1htohbinGSAB0OzEwOI+TXSvsbYXxtzvLMdu5OXedzc6dYdCVosFnIe mymQkBLkYK3h67hhbjv0J5F0PxXRyk3SdtaQn/aQOOLCof8KIgPysgxJ6bqgWO5wukcD fU5A== X-Gm-Message-State: AOJu0YzPPCR5rNX+0G2FSLxcpinU/dGa0/XNiZyAd/edDOkHQTn1egyq er8jyntAaYz3KaQXo+H3PRd17VVP8eMPjbFILlU= X-Google-Smtp-Source: AGHT+IFXYIWUzsZtNi6GkFi98NBfmLM2bpy3fOSBxfTxZFKjobr8R0AqIL1XreEBOGoXGtUz9F6Avp+sgy5qw0Jl0u8= X-Received: by 2002:a19:6905:0:b0:507:a3ae:3252 with SMTP id e5-20020a196905000000b00507a3ae3252mr21028494lfc.27.1699359197092; Tue, 07 Nov 2023 04:13:17 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:273925 Archived-At: On Mon, Nov 6, 2023 at 7:39=E2=80=AFPM Dmitry Gutov wrot= e: > > On 06/11/2023 18:20, Jo=C3=A3o T=C3=A1vora wrote: > > On Wed, Nov 1, 2023 at 10:45=E2=80=AFPM Dmitry Gutov = wrote: > > > >> I guess we should wait a few days to see if anyone has more comments, > >> and then install this? > > Five days elapsed, and no more comments came in, so I addressed your > > comments and Eli's and I pushed this to master as > > dfffb91a70532ac0021648ba692336331cbe0499. Here's another place where completion-lazy-hilit could be leveraged: diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el index ca2b25415f1..bb2670bccf6 100644 --- a/lisp/minibuffer.el +++ b/lisp/minibuffer.el @@ -2067,7 +2067,7 @@ completion--insert-strings ;; when the caller uses tabs inside prefix. (setq colwidth (- colwidth (mod colwidth completion-tab-width)))) (funcall (intern (format "completion--insert-%s" completions-format)= ) - strings group-fun length wwidth colwidth columns)))) + (mapcar #'completion-lazy-hilit strings) group-fun length wwidth colwidth columns)))) (defun completion--insert-horizontal (strings group-fun length wwidth @@ -2378,6 +2378,7 @@ minibuffer-completion-help (end (or end (point-max))) (string (buffer-substring start end)) (md (completion--field-metadata start)) + (completion-lazy-hilit t) (completions (completion-all-completions string minibuffer-completion-table Any objections? Seems to speed it up when flex is the preferred completion style outside icomplete. These are average times collected from the instrumentation of the above completion-all-completions when doing a M-: (setq i TAB) I just used my normal Emacs session for this. with lazy hilit: 0.104536125 without lazy hilit: 0.172522571 Jo=C3=A3o