From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#53853: [PATCH] Don't use string-replace in flymake Date: Tue, 8 Feb 2022 09:54:04 +0000 Message-ID: References: <87r18e7fb7.fsf@gmail.com> <87zgn1ublj.fsf@gnus.org> <87mtj17oqg.fsf@gmail.com> <87ee4d7o3f.fsf@gmail.com> <875ypp7kmu.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000048917c05d77eb09d" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23746"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Brian Leung , Lars Ingebrigtsen , 53853@debbugs.gnu.org To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Feb 08 11:39:22 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nHNu5-00062J-GT for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 08 Feb 2022 11:39:21 +0100 Original-Received: from localhost ([::1]:48020 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nHNu4-0005ye-2j for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 08 Feb 2022 05:39:20 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:34932) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nHNCI-0004ak-7Y for bug-gnu-emacs@gnu.org; Tue, 08 Feb 2022 04:54:08 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51459) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nHNCE-0000MN-E6 for bug-gnu-emacs@gnu.org; Tue, 08 Feb 2022 04:54:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nHNCE-0005A5-Dl for bug-gnu-emacs@gnu.org; Tue, 08 Feb 2022 04:54:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Feb 2022 09:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53853 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 53853-submit@debbugs.gnu.org id=B53853.164431401319804 (code B ref 53853); Tue, 08 Feb 2022 09:54:02 +0000 Original-Received: (at 53853) by debbugs.gnu.org; 8 Feb 2022 09:53:33 +0000 Original-Received: from localhost ([127.0.0.1]:45356 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nHNBl-00059L-JS for submit@debbugs.gnu.org; Tue, 08 Feb 2022 04:53:33 -0500 Original-Received: from mail-oo1-f52.google.com ([209.85.161.52]:37538) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nHNBk-000597-Ur for 53853@debbugs.gnu.org; Tue, 08 Feb 2022 04:53:33 -0500 Original-Received: by mail-oo1-f52.google.com with SMTP id t75-20020a4a3e4e000000b002e9c0821d78so17006329oot.4 for <53853@debbugs.gnu.org>; Tue, 08 Feb 2022 01:53:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oNfpsnsEQo/VUyaMNiPLMn+UlkQdI0Qt+pzsJ9++48g=; b=dA4+8nyOBswFzt2eV2DRxp6BHv4iwtxh2QXf+oGZ1jvJOli26sfoSYg/sZopGHGZpC hkTcnRyCiTSJosqcfgEpd+14g4hn4GCWE630JG8fTWNRlSakvz11hJ1V3shpsb2kb8j9 OAxFGyfxce0qL2KvpJS1lwVqxSscOJYJkcuZ8mP/so0t3K7cES5XmX5E3oXeYHUYEx8q e+XfxQSKPNKDr3X4j4//68I7ZhOmwbFDq+W3LaNETMGYi5Q3kibbFHmTKsxjbQYNkdtm KiK9jyK9LY9I5h6tsPTStrc/gvavLG/nxQJK1qZdzziC08BPgXjcbx48PNBI57L84VKX NRsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oNfpsnsEQo/VUyaMNiPLMn+UlkQdI0Qt+pzsJ9++48g=; b=CoW5ABiqPgW3QUxkUtdR23wwfs7hCdJNeXCFimoZ7ige4dm/v9DHYNi2KUhdT7xTwo 76uMM4ARFhl8tpnv22C1ouRwpxAD+hjfANJykPv1Ijk6mZeGUQ1RVdflI6Q/LmL94pYP tnfa81xBjsDNhvu+ddYybHi5HS2pqTxDoohcohEza3B8yeUoRgnatrYLx8+++vu4ywzP jrHXhGBbBiQSBAovOiojC9ped8Jpu0jqX3qFy0qtEoNdQkZsTDEz9e/gqxibP1Z2kMjf e9AFRrGGIWi4GZBKmwIaAQuSxEJJrC5y0IeIh+9OvADUf0hiWL+mi6xkxMBFjwBis7Te Ht2A== X-Gm-Message-State: AOAM533EmcHs7aQThOGFBl3RnWkdUHzuGXAs5EWH/0aeNYr0G/upPg+M iflhY0kGNkM9orI7LlEXRaD5X1t2OMmknUka8uI= X-Google-Smtp-Source: ABdhPJze7ksU0HTRUYTG6d086czjI9vBzHr70kYQjtdgUBkS0uxd7kpsH++9U3VCSZ20t+cAHSkKU+Ean454Woxlpts= X-Received: by 2002:a05:6870:ea05:: with SMTP id g5mr108559oap.181.1644314006948; Tue, 08 Feb 2022 01:53:26 -0800 (PST) In-Reply-To: <875ypp7kmu.fsf@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:226354 Archived-At: --00000000000048917c05d77eb09d Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Feb 8, 2022 at 9:50 AM Robert Pluim wrote: > >>>>> On Tue, 8 Feb 2022 09:20:07 +0000, Jo=C3=A3o T=C3=A1vora > said: > > Jo=C3=A3o> I'm not in front of my computer right now, but as far as I > recall, there is > Jo=C3=A3o> a note in the preamble of flymake.el asking maintainers no= t to > use > Jo=C3=A3o> functionality incompatible with the given emacs dependency= . > > There is, and the current flymake.el says emacs-28. > Does it? That's news to me. It shouldn't, I think. That breaks a lot of downstream users, eglot.el most notably. I have to M-x vc-region-history that bit. Jo=C3=A3o --00000000000048917c05d77eb09d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Tue, Feb 8, 2022 at 9:50 AM Robert Pluim <rpluim@gmail.com> wrote:
>>>>> On Tue, 8 Feb 2022 09= :20:07 +0000, Jo=C3=A3o T=C3=A1vora <joaotavora@gmail.com> said:

=C2=A0 =C2=A0 Jo=C3=A3o> I'm not in front of my computer right now, = but as far as I recall, there is
=C2=A0 =C2=A0 Jo=C3=A3o> a note in the preamble of flymake.el asking mai= ntainers not to use
=C2=A0 =C2=A0 Jo=C3=A3o> functionality incompatible with the given emacs= dependency.

There is, and the current flymake.el says emacs-28.
Does it?=C2=A0 That's news to me.=C2=A0 It shouldn't, = I think.=C2=A0 That breaks a lot of downstream
users, eglot.= el most notably.

I have to M-x vc-region-his= tory that bit.

Jo=C3=A3o

<= div>
--00000000000048917c05d77eb09d--