From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#65418: 29.1; Eglot: support clangd inactiveRegions extension Date: Mon, 4 Sep 2023 11:51:33 +0100 Message-ID: References: <87edjw6wtz.fsf@betli.tmit.bme.hu> <87zg2fnwm0.fsf@gmail.com> <873504d1oe.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17836"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 65418@debbugs.gnu.org, Eli Zaretskii , Felician Nemeth , Philip Kaludercic To: Filippo Argiolas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 04 12:52:11 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qd7Bj-0004TM-4v for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 04 Sep 2023 12:52:11 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qd7Bb-0005gI-UN; Mon, 04 Sep 2023 06:52:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qd7Ba-0005f9-Jt for bug-gnu-emacs@gnu.org; Mon, 04 Sep 2023 06:52:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qd7Ba-00021q-BC for bug-gnu-emacs@gnu.org; Mon, 04 Sep 2023 06:52:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qd7Ba-0006JA-3z for bug-gnu-emacs@gnu.org; Mon, 04 Sep 2023 06:52:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Sep 2023 10:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65418-submit@debbugs.gnu.org id=B65418.169382471524234 (code B ref 65418); Mon, 04 Sep 2023 10:52:02 +0000 Original-Received: (at 65418) by debbugs.gnu.org; 4 Sep 2023 10:51:55 +0000 Original-Received: from localhost ([127.0.0.1]:48872 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qd7BS-0006Io-HD for submit@debbugs.gnu.org; Mon, 04 Sep 2023 06:51:54 -0400 Original-Received: from mail-lj1-x236.google.com ([2a00:1450:4864:20::236]:57798) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qd7BP-0006IZ-KX for 65418@debbugs.gnu.org; Mon, 04 Sep 2023 06:51:52 -0400 Original-Received: by mail-lj1-x236.google.com with SMTP id 38308e7fff4ca-2bd0d135ca3so21065571fa.3 for <65418@debbugs.gnu.org>; Mon, 04 Sep 2023 03:51:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693824705; x=1694429505; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=wqfdHOydkyfDzFrTknfEut4G+VC1mRX/D2tOrGYyx6k=; b=GhlRWx0AfUyZaJBvJsW/znw09EIQ7wOKBqhjTpB5dJbpVAgqy+dWV7DtmTzixrKdw/ QAEuTIFI8MxwcmGcxleDJWdiQAYVui7nE/hhSq/njyGo57PBuuVDlw1NzSMWylDupHGB 1jvRl1hnBy0RHS4AYF7TA6txNsHJ49AhfB/HOhF70u1GEOKHuBGOerrJ5mHKotSP3xov V5gDCKrI9TxkydXYu6jkSUJ4Jfb9SlcB9bxJ+cck7QTv+XMA1MVj4MnGB7a8bVORWNbU 2lfpT2yX13k5mzZmdxuuoptq8OsW2S2YKHyx4J+2AEOOxlvTiGAWbBaYoz9L2BEBmcrU /I5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693824705; x=1694429505; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wqfdHOydkyfDzFrTknfEut4G+VC1mRX/D2tOrGYyx6k=; b=C+2mw4o979w1BedRc+b2wdPBbOwp8UDKdm/mHTOopayTzXKid9GDZK7ODnDzgrxBI6 2XKX2DrBd+9SYEZhm48Mg7RVRLeHlIEFaCtMYGR6VkRilntcKptZXssknMzn7jQqzFrD AtiSJHQc6u9tE7U3zBEq/Zx4q/7js12LxTpjORGDpzN0FYhSHg8ZNgl+qIStt1vos7jb 2CbOE5u7SOCeGXRFRUGL9hvGgw/eBBG/UQmwVtUK0Zn/8ei3OMFljsot5VO7wyfSMmTV vrGZj59OO43P5PrKU9UFRMFT+mUiKWaaNJhw0gLceXB7bX8BC0D5Yq+RMwJtBGIQfdFK duRQ== X-Gm-Message-State: AOJu0YyiJ+80p4aODYonOiEFFAGmcZYYnHMvYkHx0rEi9thBcelX2/3v iLrEkMaycUJjCke5IKcF6Was9b71qOjqwyejpWw= X-Google-Smtp-Source: AGHT+IFTaYreyxBEjNtfgNIGHzX1My5wR9eQNqCJZakxEocaso+AhD9tcFKbBMu4fXutQGg6CtqzisHjGqwvB59DsTA= X-Received: by 2002:a2e:8805:0:b0:2b6:ea3b:f082 with SMTP id x5-20020a2e8805000000b002b6ea3bf082mr6357883ljh.38.1693824705049; Mon, 04 Sep 2023 03:51:45 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:269227 Archived-At: On Mon, Sep 4, 2023 at 5:09=E2=80=AFAM Filippo Argiolas wrote: > > On Mon, Sep 4, 2023 at 5:59=E2=80=AFAM Filippo Argiolas > wrote: > > > > On Mon, Sep 4, 2023 at 3:06=E2=80=AFAM Jo=C3=A3o T=C3=A1vora wrote: > > > > > > On Mon, Sep 4, 2023 at 2:05=E2=80=AFAM Jo=C3=A3o T=C3=A1vora wrote: > > > > > > > > On Thu, Aug 31, 2023 at 6:28=E2=80=AFPM Filippo Argiolas > > > > wrote: > > > > > > > > > > On Sun, Aug 27, 2023 at 3:58=E2=80=AFPM Jo=C3=A3o T=C3=A1vora wrote: > > > > > > Glad to help. You're lucky I'm not some kind of wine connoisse= ur ;-) > > > > > > Make a patch for that (and remember to also include the exporta= tion of > > > > > > the '--' symbols). > > > > > > > > > > > > > > > > Many thanks again! That code definitely made this work week more = enjoyable ;-) > > > > > > > > > > Sorry for the delay with the patch, little time left these days f= or > > > > > side projects or even trivial contributions like this. > > > > > See if the attached patches could do! > > > > > > > > They were very helpful. I just pushed heavily edited versions of > > > > them to master. I used them as a starting point and credited you a= s > > > > co-author (I could have done the other way round, crediting myself > > > > as co-author, but the changes I did were a bit too extensive for > > > > that). > > > > No problem for me, edit as much as you want! just glad to help. > > I'd be just as happy if you just thanked me in the commit message. > > By the way I looked at your doc version and very much approve it. The > one about public API I think I don't even deserve co-authorship :-D It's mainly because i started by applying your patch then doing multiple changes to them. My intuition also tells me that the remnants of both your contribution are indeed "trivial" (as measured both in absolute LOC and complexity) But I admit I'm not fully aware of how these things are counted "officially", so better safe than sorry and I reverted them. But I would very much like to re-revert of course, as this was a lot of work and is a pretty valuable change, IMO. Let's wait for Eli to explain how to proceed. Jo=C3=A3o