From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#62720: 29.0.60; Not easy at all to upgrade :core packages like Eglot Date: Tue, 18 Apr 2023 12:44:24 +0100 Message-ID: References: <87a5zj2vfo.fsf@gmail.com> <83wn2h5825.fsf@gnu.org> <87wn2gkhzr.fsf@posteo.net> <83cz485oxi.fsf@gnu.org> <87leiwdyff.fsf@posteo.net> <834jpk5hih.fsf@gnu.org> <871qkom3fj.fsf@posteo.net> <83mt3b4yfc.fsf@gnu.org> <87edonlsxi.fsf@posteo.net> <83jzyf4vzb.fsf@gnu.org> <871qknllkj.fsf@posteo.net> <83fs934pjf.fsf@gnu.org> <87wn2fk47y.fsf@posteo.net> <83sfd2g2ek.fsf@gnu.org> <875y9yfxrr.fsf@gmail.com> <87y1muefks.fsf@gmail.com> <834jpifizy.fsf@gnu.org> <83y1mue1qi.fsf@gnu.org> <83sfd2e01f.fsf@gnu.org> <1a5e5837-513b-84d8-3260-cdbf42b71267@gutov.dev> <83sfcz9rf2.fsf@gnu.org> <09a49ab9-ac72-36a9-3e68-9c633710eba7@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38041"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62720@debbugs.gnu.org, rpluim@gmail.com, philipk@posteo.net, monnier@iro.umontreal.ca, Eli Zaretskii , larsi@gnus.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Apr 18 13:45:15 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pojlq-0009gP-CE for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 18 Apr 2023 13:45:14 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pojlg-0005Lc-Ly; Tue, 18 Apr 2023 07:45:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pojle-0005L8-AW for bug-gnu-emacs@gnu.org; Tue, 18 Apr 2023 07:45:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pojle-0002f6-1g for bug-gnu-emacs@gnu.org; Tue, 18 Apr 2023 07:45:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pojld-0006hO-Kh for bug-gnu-emacs@gnu.org; Tue, 18 Apr 2023 07:45:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 18 Apr 2023 11:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62720 X-GNU-PR-Package: emacs Original-Received: via spool by 62720-submit@debbugs.gnu.org id=B62720.168181828325708 (code B ref 62720); Tue, 18 Apr 2023 11:45:01 +0000 Original-Received: (at 62720) by debbugs.gnu.org; 18 Apr 2023 11:44:43 +0000 Original-Received: from localhost ([127.0.0.1]:58025 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pojlL-0006ga-6D for submit@debbugs.gnu.org; Tue, 18 Apr 2023 07:44:43 -0400 Original-Received: from mail-oa1-f52.google.com ([209.85.160.52]:51458) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pojlJ-0006gL-8L for 62720@debbugs.gnu.org; Tue, 18 Apr 2023 07:44:42 -0400 Original-Received: by mail-oa1-f52.google.com with SMTP id 586e51a60fabf-18785f07525so216540fac.3 for <62720@debbugs.gnu.org>; Tue, 18 Apr 2023 04:44:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681818275; x=1684410275; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=B7heRkrC1ym20UYZnAcTfQMRpAUTeOk3yOFsNSxEWYc=; b=r9JxgVrj9A/TyGaVcrO1dysIOGSH2f2UP8Xq2eKY+G84ydN8HrojWCSpNmYjZOc3SF BJEdP8scOPN96yzxMAXVIZjh4U3JxyUOXHox47/vxovigeglYLvkAvcQ2b4tthRahwo/ E6UGtuyEKvbkomsF8G4BihS7oZ+Fb7Tub3F8MxgRqATNQZs+CzPPuPD+ZUi45JPs6AKr FFWFstP0uzCMheZY3f+QiqHqZExmXsDjVotwRRrkGrtbgwWFnD/YIWaaOwwFcUw4bri1 VTQzz2lZWghN/P44tc5QeJnG8sByCNt4RIAyIPeQj4irSxc1Noyb6G6+7XanZ18LXKT8 gYEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681818275; x=1684410275; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=B7heRkrC1ym20UYZnAcTfQMRpAUTeOk3yOFsNSxEWYc=; b=YLH/OnF+tGTCQLVG9pKaT+9jTgVL7XI0foPMN6Brx0kCWbq7isFZGHkJot2cUstvI+ 6z3zyH5fFiZdb0lDOeuMlxwNmnH5Vyx6Pn99VfXM1xPCdiyOrahODAIpvR0RLmUc+9bj 418MwRrvl0twjD3Nd5NR+JwJjeeIzDHOKXjLnAZFj/pVkF7HvqvSbZWs90KciiMM02Rt y/tan3UuLBbg950r+3lb76A9DCWwccLW4gJNJHyrQYthRRlscu/yvRrM0y/7CngHS3wl P5U9LRDomeP5++/Zb1m9Tlz4hriOztTveaxXlkUh0+QeZkK2aXVgxymDzKIVuDMUKChg DT8Q== X-Gm-Message-State: AAQBX9dQFWNi3JAaE41Ubfr188XDkZGM9oztQskv7c400/TYgWPBvRCH pNkswo/8aok1tSilQsykHjcBdeJpxP8ZvLWsV3Q= X-Google-Smtp-Source: AKy350bKrJxrFMUOG1hCDz20shbZSqJIdABH+nFLhdN0XTf26C8H5C1TwrCZLD2uadLg5Ak2UpJFhSoYTB6UPzHpxRE= X-Received: by 2002:a05:6870:3906:b0:187:9bf2:af63 with SMTP id b6-20020a056870390600b001879bf2af63mr928723oap.5.1681818275348; Tue, 18 Apr 2023 04:44:35 -0700 (PDT) In-Reply-To: <09a49ab9-ac72-36a9-3e68-9c633710eba7@gutov.dev> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:260219 Archived-At: On Tue, Apr 18, 2023 at 2:25=E2=80=AFAM Dmitry Gutov wro= te: > > It was about the criteria for which versions of core packages to ship > > with a release. > > I don't think we can get a single set of criteria across core packages. Agree. We should have categories and understand what is surprising or workflow-breaking and what is not. > BTW, if you recall the threads before Eglot was added, I was against > that, and one of the things I cited is an LSP client has inherently high > development velocity. Maybe the LSP community will settle/mature/stop > adding features one day, but it's not there yet. Very true, but the conclusion is only half-true. It didn't have to be like this: Eglot _can_ grow rapidly in master and and have its periodic stable releases. And in the major Emacs versions released to the public could have an even stabler release (because it went through more testing). This is just like any other :core package until now. The solution picked for this issue is bad in that it breaks some Eglot users workflows and expectations when using very common configuration recipes. We should revert it and pick a fix that relies on recognizing that there are different "sets of criteria" as you propose. One such fix remains uncriticized and unchallenged in this thread. But if that doesn't happen, we shouldn't make a bad situation worse, by backporting 100's of lines of code of Eglot and friends into Emacs 29. That's the polar opposite in the pursuit of stability. Hand-picked bugfixes for problems manifesting themselves in Emacs 29, sure! But wholesale changes are just asking for trouble and destroying the value of the pretest and RC periods. As bug#62907 shows, there are certain edge-case bugs due to refactorings in upcoming Eglot 1.15 that are not in 1.12.29 bundled with Emacs 29. Good! That's the way it should be. Let's not ruin that. > >> Because since we've decided in favor of stability of package.el, and > >> against eglot's easy upgradability, I would suggest to backport Eglot > >> 1.14 to emacs-29. > > > > I won't object. In fact, I asked up front why not. > > Note that that suggestion comes with a fix to eldoc which you so far > have rejected for emacs-29. ...to name but one change to the non-Eglot, already-there-in-Emacs-28, libraries Eglot depends on (or will depend on). I do think _that_ ElDoc fix should be just backported. It's not a complicated fix by any measure, it's easy to test, and it indeed has value and safety. Together with your similar fix for Company, it'll make Emacs 29 users happier. Jo=C3=A3o