From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#61726: [PATCH] Eglot: Support positionEncoding capability Date: Thu, 23 Feb 2023 12:24:19 +0000 Message-ID: References: <87a614g628.fsf@gmail.com> <83cz60r7hu.fsf@gnu.org> <871qmgfuz9.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17587"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 61726@debbugs.gnu.org, Eli Zaretskii To: Augusto Stoffel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 23 13:23:11 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pVAcx-0004LZ-NH for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 23 Feb 2023 13:23:11 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pVAcp-0002nJ-Ir; Thu, 23 Feb 2023 07:23:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVAco-0002mv-3a for bug-gnu-emacs@gnu.org; Thu, 23 Feb 2023 07:23:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pVAcn-0003tJ-Rn for bug-gnu-emacs@gnu.org; Thu, 23 Feb 2023 07:23:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pVAcn-0000vO-Me for bug-gnu-emacs@gnu.org; Thu, 23 Feb 2023 07:23:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 23 Feb 2023 12:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61726 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 61726-submit@debbugs.gnu.org id=B61726.16771549663530 (code B ref 61726); Thu, 23 Feb 2023 12:23:01 +0000 Original-Received: (at 61726) by debbugs.gnu.org; 23 Feb 2023 12:22:46 +0000 Original-Received: from localhost ([127.0.0.1]:33251 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVAcX-0000us-Nx for submit@debbugs.gnu.org; Thu, 23 Feb 2023 07:22:45 -0500 Original-Received: from mail-oa1-f42.google.com ([209.85.160.42]:45747) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVAcV-0000ue-9e for 61726@debbugs.gnu.org; Thu, 23 Feb 2023 07:22:43 -0500 Original-Received: by mail-oa1-f42.google.com with SMTP id 586e51a60fabf-172663f1956so5980967fac.12 for <61726@debbugs.gnu.org>; Thu, 23 Feb 2023 04:22:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=VnyVNj6XBMFn5wJ+p8zU2L4fm9vWYeghINKObGBbJEY=; b=J1mTYiouyHWTux67rcGTnlMI8lxHwDmWn4L3pIZSdk5ROxepeRibYaKaaG6KtZGJA8 q1kgfbnFTWmKZCCjK/vRQ21q9XqPYY3Sd/qSsJtoeou+Aq/8PvhNlNy8m7itzYowgVfL 8hbwiBw/hkw5GqWNAgTg7L3CheuVGfKGmz3Xh5FwWhncpAzI/FrKCfSd6CeXgQpmP4Pc GsSzbvmiQ83KcCEPnYFSLsyrbc2mRXrE9UrbVM21npeM1kVJBKaOA4a/5q9RYk8aM2rV LOplyBWT3HsmFFP2EB4f124Ai5MaT3MvBg2VbR79ogH9A+bRGKnwiFEDW8uYLGsaXgS1 u4mQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VnyVNj6XBMFn5wJ+p8zU2L4fm9vWYeghINKObGBbJEY=; b=BDBZc/9eXCn2JEn596qkMvKez79tJIadv7nx9oQ6JGhP7HB9PUlStpWSlytDVAT9TW seSXsaO2vRIncZP+Q01pOd7hBMaiG1zGoDOjp6iQ0wQFJ1Qed765hDLfFtpWsuX9nT4Y o1Kbsjy6i9E1nDu/bGeMUhV2466CpIAtcqGLX32Ekeaw1e+ubaMXmL+P/gG6DhUB24tG /Leuj6fJJW/mEZ/43eNeJ7MReU8PnKqER4/u1SDNwOuBn5aJ0CYRi4nzVmB5H5D4+qkX 6chwiLe+Li8DlSHxRBuNtJCE74X5mWE44id9cCnK8Zey8AGF27LHTusi6HtZLhhpY+kq 0f2w== X-Gm-Message-State: AO0yUKUipc8EPfvHUgKSpIHSowyChZoNNlmcSfGI73YvZUPXrgeogL4v DNDgG9Emy0Z0Dn09oeKWZaesXcpHP9DLZylZw9g= X-Google-Smtp-Source: AK7set8d3s5RIU92v1Go4THk2zP7XBvivyS8rCVRAjhHmpjLABOm+/FxsfU/cAwYYhJOH3NG+MWo3+sUSHRBTdxrkLQ= X-Received: by 2002:a05:6870:41d0:b0:172:8adb:8e44 with SMTP id z16-20020a05687041d000b001728adb8e44mr184857oac.215.1677154957650; Thu, 23 Feb 2023 04:22:37 -0800 (PST) In-Reply-To: <871qmgfuz9.fsf@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:256450 Archived-At: On Thu, Feb 23, 2023 at 12:04 PM Augusto Stoffel wrot= e: > > On Thu, 23 Feb 2023 at 11:32, Jo=C3=A3o T=C3=A1vora wrote: > IIUC correctly, clangd was the group that pushed for this new LSP spec, > but being a such a big project they surely support the official way of > counting. Yep, they do. This was a bug report from our end and they fixed it some time ago, IIRC. > Anyway, more than efficiency, this to me is an aesthetic question. The > UTF-16 way of counting of the original LSP spec is a totally misguided > idea and should be avoided. I agree that it is poor design. But if it works and isn't particularly slow, then I don't think it's a priority to change things in Eglot, mostly because that adds complexity for relatively little value. That it isn't "priority" doesn't mean I would oppose it if you work things out with an encoding expert like Eli and give it suitable testing. Jo=C3=A3o