From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#56407: 29.0.50; desktop.el shouldn't be saving/restoring eglot--managed-mode, which is not for interactive use Date: Wed, 6 Jul 2022 14:47:32 +0100 Message-ID: References: <87y1x7pd53.fsf@gmail.com> <83v8sb73ga.fsf@gnu.org> <87tu7vpc8y.fsf@gmail.com> <83tu7v6kjv.fsf@gnu.org> <83r12y7b0y.fsf@gnu.org> <83let676fe.fsf@gnu.org> <83h73u75bi.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000e7700105e32331a9" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37385"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 56407@debbugs.gnu.org To: Stefan Kangas , Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jul 06 15:48:42 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o95OQ-0009OL-RV for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 06 Jul 2022 15:48:38 +0200 Original-Received: from localhost ([::1]:57928 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o95OP-0001yY-LL for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 06 Jul 2022 09:48:37 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60052) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o95Ms-0000oK-VR for bug-gnu-emacs@gnu.org; Wed, 06 Jul 2022 09:47:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58988) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o95Ms-0002di-MJ for bug-gnu-emacs@gnu.org; Wed, 06 Jul 2022 09:47:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o95Ms-0004dL-I7 for bug-gnu-emacs@gnu.org; Wed, 06 Jul 2022 09:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 Jul 2022 13:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56407 X-GNU-PR-Package: emacs Original-Received: via spool by 56407-submit@debbugs.gnu.org id=B56407.165711520117781 (code B ref 56407); Wed, 06 Jul 2022 13:47:02 +0000 Original-Received: (at 56407) by debbugs.gnu.org; 6 Jul 2022 13:46:41 +0000 Original-Received: from localhost ([127.0.0.1]:52885 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o95MW-0004cj-Vh for submit@debbugs.gnu.org; Wed, 06 Jul 2022 09:46:41 -0400 Original-Received: from mail-oi1-f180.google.com ([209.85.167.180]:46929) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o95ML-0004cK-TH for 56407@debbugs.gnu.org; Wed, 06 Jul 2022 09:46:40 -0400 Original-Received: by mail-oi1-f180.google.com with SMTP id i3so19900346oif.13 for <56407@debbugs.gnu.org>; Wed, 06 Jul 2022 06:46:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NJht2/lqVEOV92Ldx2fCC3kxX8MuCEm7ODd9s4lPZRs=; b=alOlQSlGsMqd0VxWZ8a6xj7NsXJa9LprihEeJp2wF9Bi+bScU4vsi1YPg++wE4+MPA 2eVO0vb/B3lf3TKeA2CNi3BSmB5awbGqRVQ0VqAe0/0cctdAVPs8rRUDM+sVE9NXmWak nE1YhJwqs6/BpODOnRhhPeFlek5cRnrsoDy3qevSVb9bB82QxYQJhfsZofv21ZCQETyg gP8NfoCOGlpCu/0P/rSnuywHlUTSX0RBLETk5G5oSDqPk6k8gfNIrMhKcHDE2AqnmwZv r9tVE3QDZPZeyW4gplhXjrNdQhOAF5ZhtMHq3zzGcCQ+NjGIeqEK9N94pDztlbjomrg0 9GYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NJht2/lqVEOV92Ldx2fCC3kxX8MuCEm7ODd9s4lPZRs=; b=m4O5iwwvLyrxOzKl2KrzRhKNW5ByNefwMy/1vtUamboXXHYHEYeT7TKQxO9KIu+jMe mmpzgmH/8Ojyk7u0TnCiI05VbQKhyaBLkydxOxhsY/V+G6ufcpKz2kuWmgiicCt2wItJ WC2nVqCk9/AnTMqUmbyBhKtwKCeZOEvI3Lcv2VIU8whxAB2kz/g9q9vAlPz0K1xmYbI0 a3Slo3scEwulR5WlOx8bFLw1tmxuVj2xvXJVraYjVCB5Lc6PttHHFcWf1c5z4frCWNS6 qOHj2FVEPe6lD6pSUvXXQPCb3m4f0Wpj+W9xFMhr9fpYg0h/qTxTTo6aZf+6J1jem52u ui7w== X-Gm-Message-State: AJIora8jYeiRLIWfj9xIZd6rNzlEW4uoUFPxYzWFcwXWbgrpbD6E3nrz TjF3IeCfbfWF9AcbKZqMsIFNHfOOIEn3gpvw36c= X-Google-Smtp-Source: AGRyM1vBEG5NA9lz+3G7I7YWa2z3x+kc4q+StqxZDB2r5dA2ce3rNdajpV3UNYhTGFLfrK5zMUSCJbaNf7t+bzB/HcA= X-Received: by 2002:aca:4b90:0:b0:335:b574:6108 with SMTP id y138-20020aca4b90000000b00335b5746108mr20635760oia.19.1657115184163; Wed, 06 Jul 2022 06:46:24 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:236246 Archived-At: --000000000000e7700105e32331a9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Jul 6, 2022 at 2:40 PM Stefan Kangas wrote: > > (eval-after-load 'desktop > > ...) > > `with-eval-after-load' is nicer, IMO. > > > Then again, eval-after-load shouldn't be used in packages, so I've read > somewhere > > (manual?). > > See the last paragraph in (info "(elisp) Hooks for Loading") > Don't hold me in suspense! :-) what does it say vis-a-vis use in libraries? Maybe we should just use it. If it works, it's the easiest one and not terribly ugly. Why is it the easiest one? Because I've just remembered an obvious drawback of the symbol-property approach: it will only work on Emacs trunk, _unless_ we make the little dance (that I've done a few times) of making desktop.el a GNU ELPA :core package and making eglot.el depend on that package (which is different from _requiring_ the load of that package)= . Lars, what do you think? Jo=C3=A3o --000000000000e7700105e32331a9 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Wed, Jul 6, 2022 at 2:40 PM Stefan Kangas <stefan@marxist.se> wrote:
>=C2=A0 =C2=A0(eval-after-load 'desktop
>=C2=A0 =C2=A0 ...)

`with-eval-after-load' is nicer, IMO.

> Then again, eval-after-load shouldn't be used in packages, so I= 9;ve read somewhere
> (manual?).

See the last paragraph in (info "(elisp) Hooks for Loading")
<= /blockquote>

Don't hold me in suspense! :-) what doe= s it say vis-a-vis use in libraries?

Maybe we shou= ld just use it. If it works, it's the easiest one and not terribly
=
ugly.

Why is it the easiest one?=C2=A0 = Because I've just remembered an obvious
drawback of the = symbol-property approach: it will only work on Emacs trunk,
= _unless_ we make the little dance (that I've done a few times) of makin= g
desktop.el a GNU ELPA :core=C2=A0 package and making eglot= .el depend on
that package (which is different from _requiri= ng_ the load of that package).

Lars, what do y= ou think?

Jo= =C3=A3o
--000000000000e7700105e32331a9--