From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#74338: 29.1; JSON RPC timeout too short in some cases Date: Sat, 23 Nov 2024 19:53:23 +0000 Message-ID: References: <80qbjyjjod3.fsf@eurocontrol.int> <86bjyil0pg.fsf@gnu.org> <86plmmkrna.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19681"; mail-complaints-to="usenet@ciao.gmane.io" Cc: jurgen.de-backer.ext@eurocontrol.int, Daniel Pettersson , 74338@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 23 20:54:23 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tEwCy-0004uB-Sc for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 23 Nov 2024 20:54:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tEwBl-0002cv-FS; Sat, 23 Nov 2024 14:53:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tEwBj-0002cl-Ag for bug-gnu-emacs@gnu.org; Sat, 23 Nov 2024 14:53:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tEwBj-0000UD-1Q for bug-gnu-emacs@gnu.org; Sat, 23 Nov 2024 14:53:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:From:In-Reply-To:References:MIME-Version:To:Subject; bh=eCk5UvRF2/X3Ria/kZH3pfoP7LEsTgUN/mvp2WmwgVA=; b=CmyzlKYtfDvYXx6MJF6N5c8xQJyeKU6Xfd8nVwbgSBB4tBdy2gbKWeyaa21MOGU+3m9azv7FKBLwTyZkkyYGDlCJL1isuSbpLuY8iKRBPOOT2tu+RbUm/ytIPi8XNndTRP/YycaHMLvkktBAJxWMRYq1yva+tDPgq2rt4LTWxuSFSIdI1oUolL/Kulh144z97veVGbNNSgT5x7yBFUuj624dQDfzDOSluzsMzxTBYITnX/pDc/IAPUd8OtQhVJvE5ySRN+kZ1sS8sUdZeYS+u5xns5Cj8FCAktzX/XWnRJ6di+sw1yOBcJkCK5GXGf5mFiRtq17J3c/x0fThM8kAoQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tEwBi-0002Ws-Q3 for bug-gnu-emacs@gnu.org; Sat, 23 Nov 2024 14:53:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 Nov 2024 19:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74338 X-GNU-PR-Package: emacs Original-Received: via spool by 74338-submit@debbugs.gnu.org id=B74338.17323915669575 (code B ref 74338); Sat, 23 Nov 2024 19:53:02 +0000 Original-Received: (at 74338) by debbugs.gnu.org; 23 Nov 2024 19:52:46 +0000 Original-Received: from localhost ([127.0.0.1]:59230 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tEwBS-0002UN-0U for submit@debbugs.gnu.org; Sat, 23 Nov 2024 14:52:46 -0500 Original-Received: from mail-ot1-f43.google.com ([209.85.210.43]:61938) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tEwBP-0002UB-1m for 74338@debbugs.gnu.org; Sat, 23 Nov 2024 14:52:44 -0500 Original-Received: by mail-ot1-f43.google.com with SMTP id 46e09a7af769-71d40fdde2fso86524a34.3 for <74338@debbugs.gnu.org>; Sat, 23 Nov 2024 11:52:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732391502; x=1732996302; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=eCk5UvRF2/X3Ria/kZH3pfoP7LEsTgUN/mvp2WmwgVA=; b=RjxdQHFtcRGsJDDMjLy63Tqlhe6hxJOXiX4bYeMkvvZyV4nYyG9jVoh+GOW5yNOOuz nai3VTex4HAif1L8nVprfTj1mt/3ad89NUgB9wHSczUOHktrmZmVo4cauSqZeGD29fel z9q+labD6qIHaOF+7QLXTbbBA/rU+p8grkZqTNlT/+OJ8Uek3VTlyslUApLeQmKuTdCg kdJFwhX9bAt0Es/cWOmoxZ0WikrQUZtDjpWHi98FF88d64DFAJeiBzaV98GL/S9+ubuB HW7H+PPPbKZPqqfizfxPF1iDl5yYveD7kO5qH0i0J6pAPm/PPv9/bc16fdm+bre4wZtJ C3Pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732391502; x=1732996302; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eCk5UvRF2/X3Ria/kZH3pfoP7LEsTgUN/mvp2WmwgVA=; b=xDsvZnc3mBolECSG0MT066hXlsWMC5HiyndsvNN6DuXeJgYwy7sMXV+G058daqwvdR 5/Y4LRZk7pojvRyl9JwlneFBaSjrDxPuO3VEi2fBKVJMmNdrPvQVpUHQ4HEiFblgNwtw uwn57cjxH4dnxsPuWFDjysWIFfMFQBtbZhwt2UoLIaiVw8Uea+BVDF6G76jL0xTHZCSC BnuHyPuZBNmetNX6+A1BQVMUOo8BrbDzgeCibmPOVTKtiZZWN/ziwCnbuKO4VwiGU5TS JheCdvwja10K3CQsaJ0MZ+eE2zCRyv8MpeQ+Rw9+JPVg4u8hAUgdf6bGgAnsWnxd/jky nqog== X-Forwarded-Encrypted: i=1; AJvYcCVFMJyVRUdO7mikWZ0uVGU9S0KgfsitNS0Lr4bCg8qQS3PotMi5J/KJ00aRXZaWANjByn/Wag==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwstHeMglwmI524pxw2wGY0nvOQrshq6acnqjWNPwRyjcisMafA 5oGsp30K+K1KrI67k4VJEfXyIdnJES8YbTgoPQBsw9PGRS7v48SNqLw2TfeJ6Hwu/pDa48CY8yD A75zQSy4U9FiOsdkO/u1Wnq84xy0= X-Gm-Gg: ASbGncvz4wjy7SVFBfajAQmcnLB1kZRc2tMnSh1UvXOGzp6rgqVGppUk4eBqghZiXVy XLko9Y/dqdwNoXDwgv8Q1oUuWV+K/qw== X-Google-Smtp-Source: AGHT+IFnwghQxf5tq5BlHzePUepPJDnPu3SBxrrlhai2IIBDapJKWnSRtpUMjCfk/Fn996eNPstBwnT8NxMnvrXjfjg= X-Received: by 2002:a05:6830:3903:b0:717:d558:ca70 with SMTP id 46e09a7af769-71c04b8b716mr8163130a34.7.1732391502290; Sat, 23 Nov 2024 11:51:42 -0800 (PST) In-Reply-To: <86plmmkrna.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:295867 Archived-At: On Sat, Nov 23, 2024 at 1:26=E2=80=AFPM Eli Zaretskii wrote: > > > From: Daniel Pettersson > > Cc: Jurgen De Backer , > > 74338@debbugs.gnu.org > > Date: Sat, 23 Nov 2024 01:23:16 +0100 > > > > Eli Zaretskii writes: > > > > >> Date: Wed, 13 Nov 2024 12:43:20 +0000 > > >> From: Jurgen De Backer via "Bug reports for GNU Emacs, > > >> the Swiss army knife of text editors" > > >> > > >> > > >> Hi, > > >> When using emacs together with eglot/ada_language_server, > > >> some requests may take longer than the 10 seconds specified in > > >> jsonrpc.el (defconst jsonrpc-default-request-timeout 0). > > >> It would be better to be able to change this default value. > > > > > > Daniel, any comments or suggestions? Maybe we should make that > > > variable a defcustom? > > > > No real harm in converting it, it might be better of it was configured > > on eglot as eglot-default-request-timeout but that would require some > > work in eglot I believe. The argument against it is that it could > > have unintended consequences for other users of jsonrpc, but I think > > it's something we can live with. > > Jo=C3=A3o, any reasons not to make this variable a defcustom? Not at all, if you're talking about jsonrpc-default-request-timeout, but that's up to Daniel jsonrpc.el maintainer. I'm against introducing eglot-default-request-timeout . If your servers are really that slow, just increase the default timeout (what's the harm?) or set jsonrpc-default-request-timeout buffer-locally in eglot-managed-mooe. Jo=C3=A3o T=C3=A1vora