From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#70541: track-changes-mode logs warnings (with input method, in Eglot buffer) Date: Sun, 5 May 2024 14:55:06 +0100 Message-ID: References: <86ttjr2pzw.fsf@gnu.org> <86edau3gyy.fsf@gnu.org> <8634ra36ny.fsf@gnu.org> <861q6ou2cs.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000963d180617b54a4a" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20792"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Richard Copley , 70541-done@debbugs.gnu.org, Eli Zaretskii To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun May 05 15:56:14 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s3cLe-0005CJ-Dz for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 05 May 2024 15:56:14 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s3cLU-0003ay-JU; Sun, 05 May 2024 09:56:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s3cL5-0003Gm-8r for bug-gnu-emacs@gnu.org; Sun, 05 May 2024 09:55:39 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s3cL5-0003h4-0W for bug-gnu-emacs@gnu.org; Sun, 05 May 2024 09:55:39 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s3cLS-0008JM-E2 for bug-gnu-emacs@gnu.org; Sun, 05 May 2024 09:56:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 May 2024 13:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70541 X-GNU-PR-Package: emacs Original-Received: via spool by 70541-done@debbugs.gnu.org id=D70541.171491730231918 (code D ref 70541); Sun, 05 May 2024 13:56:02 +0000 Original-Received: (at 70541-done) by debbugs.gnu.org; 5 May 2024 13:55:02 +0000 Original-Received: from localhost ([127.0.0.1]:59884 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s3cKT-0008If-Q5 for submit@debbugs.gnu.org; Sun, 05 May 2024 09:55:02 -0400 Original-Received: from mail-lf1-x130.google.com ([2a00:1450:4864:20::130]:45153) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s3cKQ-0008IN-6M for 70541-done@debbugs.gnu.org; Sun, 05 May 2024 09:55:00 -0400 Original-Received: by mail-lf1-x130.google.com with SMTP id 2adb3069b0e04-51f2ebbd8a7so1261694e87.2 for <70541-done@debbugs.gnu.org>; Sun, 05 May 2024 06:54:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714917268; x=1715522068; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ilguV9rNs+FYimtqzJTcI/60Dcx+t5YV+3qGJTci+no=; b=e1VBavJJGc6bk2daQwIHWNCAz6DDQy7VhFeAw+V5XRLj4x7GYCnz7LWYo6HJ9KM6/w UQz4TSNfs/IDM3JH2U3C+WXp8xgKSBN0vc6VENOp0HFuNU5IYyNyoIi1+Hz7njuLWJJJ 2Yuvum2/nzTudkGkMos9UsnbjB507lx+kU72X2x0xB2DoA/siW4T8EJYwJEaYvkc/9bf aJLe9BKDxbVhIEtdW1sLYpSay3rVFx9mnW2C/dvNSlmggQDKH0u5CqDf3HuBeE5E+qyz nFNlkcCpAfBJBr8ThObAqon98PdWqxS4xzcGTHSJU+xLjezoeNCE9I9fEbV228Znu1zs SgVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714917268; x=1715522068; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ilguV9rNs+FYimtqzJTcI/60Dcx+t5YV+3qGJTci+no=; b=w0dbWT2hqmDpbIjGEEZC1hjYC7mHSL88AeLd7N2dbk04lYik6KdNESS1Ln4ufS1cY5 dGpy2E7BayTPBGObEGV5J72tK915IM/MEmJJPyi+Y/izS4yA43Y+lEJpx4lsmuv7LpMI k0SBzPiNvvduHvOKe5UlGkuUrTlG3MTKkpraQYUjhTBFnsOkIDiJkqC+yvoi0e8slNwV fwTr4z/GgDGQkDwSTfoE2aavx7EpDqU0WOksR/hVqNUBYJK0Cqn0txNk5t1KB3eqJVXr GGCvCLhmuEoYab7Osr9e/R+Io8UvsBqisXm5vMGVvyt2Q4rRP/6NfMsIGKgEhIItAAbW eOow== X-Forwarded-Encrypted: i=1; AJvYcCUcRtCy9pI3YB3SR/3fb8h0yDJNoQh4E4iOUsZJBUybqwCtzFyDD/JYVUCvwtwLmp1ETIqdUxLerVoKkp7GzoxM3ZKhuKjLtxvT6g== X-Gm-Message-State: AOJu0Ywni4cah5ytCV/B+PM7qdT0A9AL4ClY0SqNy0QIUDkElX/iTnlu t/eAfPV6l0ukCQi1lOlxlBqofq3w+AVqx15Tm+2Ay3PiXOwNxmGLYM6cmmiQOdnGDfQ0gekOsXe qjnu3gYDhbJI64UkKc2bvIqtfr1A= X-Google-Smtp-Source: AGHT+IEbhwG8b5RnaX3U0cpTnC/nrqetH1S1z57wjNV82+uxbefIwr6FGMT0UUg1nMHdflRIQG4/RLi85oy4fh4E7+4= X-Received: by 2002:ac2:4568:0:b0:51b:fe4b:da45 with SMTP id k8-20020ac24568000000b0051bfe4bda45mr4715965lfm.38.1714917268140; Sun, 05 May 2024 06:54:28 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:284502 Archived-At: --000000000000963d180617b54a4a Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, May 5, 2024 at 2:40=E2=80=AFPM Stefan Monnier wrote: > > Seems good, thanks. > > Great, closing, > Is this really the final word on this whole topic? The current solution involves a one shot addition to `post-command-hook` in Eglot and is really ugly. Can you really really no better solution so that Eglot is only compelled to send changes to the server once track-changes.el announces it safe to do so (and gives the change to send while it's at it? Also, tangentially , can we get rid of the fboundp's and make the next GNU ELPA version run the same code as Emacs master's by depending on track-changes.el GNU core? Also also, can you fix indentation in the function that you recently touched in Eglot? (same goes for Philip, but I'll contact him separately). Jo=C3=A3o --000000000000963d180617b54a4a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

On Sun, May 5, 2024 at 2:40=E2=80=AFPM Stefan Monnier <monnier@iro.umontreal.ca> wrot= e:
> Seems go= od, thanks.

Great, closing,

Is this really the fina= l word on this whole topic?=C2=A0=C2=A0 The current solution involves a one=
shot addition to `post-command-hook` in Eglot and is really ugly= .=C2=A0 Can you really
=C2=A0really no better solution so that Eg= lot is only compelled to send changes to the=C2=A0
server once tr= ack-changes.el announces it safe to do so (and gives the change=C2=A0
=
to send while it's at it?

Also, tangentia= lly , can we get rid of the fboundp's and make the next GNU=C2=A0
=
ELPA version run the same code as Emacs master's by depending on= =C2=A0
track-changes.el GNU core?

Also a= lso, can you fix indentation in the function that you recently touched=C2= =A0
in Eglot? (same goes for Philip, but I'll contact him sep= arately).

Jo=C3=A3o

=
--000000000000963d180617b54a4a--