From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#42777: 28.0.50; Obsolete eldoc-message function used in CEDET Date: Sun, 30 Aug 2020 14:54:29 +0100 Message-ID: References: <874kpbetd6.fsf@gnus.org> <87sgc69zaz.fsf@gmail.com> <87wo1gs0tw.fsf@gnus.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000009c534e05ae18a0cb" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24008"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 42777@debbugs.gnu.org, Stefan Kangas To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 30 16:29:08 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kCOKS-00068z-3y for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 30 Aug 2020 16:29:08 +0200 Original-Received: from localhost ([::1]:45772 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kCOKR-0004Dj-6X for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 30 Aug 2020 10:29:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46546) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kCOKM-0004Dc-0f for bug-gnu-emacs@gnu.org; Sun, 30 Aug 2020 10:29:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38930) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kCOKL-00073C-OI for bug-gnu-emacs@gnu.org; Sun, 30 Aug 2020 10:29:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kCOKL-0004IJ-K4 for bug-gnu-emacs@gnu.org; Sun, 30 Aug 2020 10:29:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 30 Aug 2020 14:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42777 X-GNU-PR-Package: emacs Original-Received: via spool by 42777-submit@debbugs.gnu.org id=B42777.159879772216478 (code B ref 42777); Sun, 30 Aug 2020 14:29:01 +0000 Original-Received: (at 42777) by debbugs.gnu.org; 30 Aug 2020 14:28:42 +0000 Original-Received: from localhost ([127.0.0.1]:50476 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCOK2-0004Hi-6R for submit@debbugs.gnu.org; Sun, 30 Aug 2020 10:28:42 -0400 Original-Received: from mail-qt1-f181.google.com ([209.85.160.181]:38603) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCOK1-0004HU-0H for 42777@debbugs.gnu.org; Sun, 30 Aug 2020 10:28:41 -0400 Original-Received: by mail-qt1-f181.google.com with SMTP id e5so3053004qth.5 for <42777@debbugs.gnu.org>; Sun, 30 Aug 2020 07:28:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=smJtChhxL2qSCm/a4zJbYu8T7t80w/p1KaLHLcQ7wJs=; b=eunqZf4g73YMM3FtiRB0UVNNBbbYAFHZ5U4ruAj/0YBsMQgdARbVSLRnV//4dGc3MQ t/Cma+CYNtWF1umkMXAAsuiPd6RQgrC7I49Z9SbaWWz7UD4ufeToEPonXL11hzULJekr 9K07VHGQH0gZQt+vmRfy9MRD3OUxMvbvRH85LQt1cQ+ZTVANfvcud6CJvdzA8ota+rTZ zVSoYYIyPX9gK79bdjZ8MzNVvZsWub0FY+ZesszXwS5OMpIIsKQWVWkv/bNn4s9C2NWb CijgkO/I+MgtrQYKGfLp24EZ7Ou0s6ZqK0SpPYbi8Az9yYL10UMi+aV+xDNOrBtLGuSn UMcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=smJtChhxL2qSCm/a4zJbYu8T7t80w/p1KaLHLcQ7wJs=; b=XaR5ggOJMGLvwyhrWEgVFUnBGFuJq7w2H7kEddNrFA/GSHnrV3Ztcuh9KQdyMHi5VT kaPKJ2AdZSOnzU6LbuVjeu8G9TnkHgw0qTIKhgSEJ0oNAtQvOfUuWc7ImgYULnkHYSDC JMjWfNvm2kmOQO0j9zgO4To8pfIVucOQsrQaRC5pot1HRKqDZi8IYZ8KOnqk8BCWLuMa kr7SfFIQw4FsILJvxdMJU4hSSRtgPEWF46UQw2KQ6wRxsNy1AsFV7LZoW8YwH61jl2+3 FpEP4gZs/ZRhN+N5B2iFz0+JHWRKCd4EBHnG+MQ+EIdOabFNV1ANUeT8SEpDJvBftFHp RTKw== X-Gm-Message-State: AOAM531HGNeG+50ZJPRKrvbJMlyiqUiqy93MKaBOYW3QaX7i/11Qc6PC e/YqfXHl/LPwdghLcs2zX1YB4QF24/uvuUgI3Savu9JL X-Google-Smtp-Source: ABdhPJxXDWcePIKK+2vz7wp8BHa1oTlSTLZ7P81SG0AHbClFYAO0MlR1A+Kg6qoq1B92mKuZogcmNnvOx6XsVOokdeo= X-Received: by 2002:a02:6995:: with SMTP id e143mr8019952jac.78.1598795680599; Sun, 30 Aug 2020 06:54:40 -0700 (PDT) In-Reply-To: <87wo1gs0tw.fsf@gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:186698 Archived-At: --0000000000009c534e05ae18a0cb Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, Aug 30, 2020 at 2:47 PM Lars Ingebrigtsen wrote: > > Lars, you want to fix the compilation warning or something else? The > > function is obsolete, but it leep working. The only "fix" is to follow > > the advice in the warning message. > > If the function is obsolete, all in-tree callers should be fixed. ...unless that code is used in another non emacs-master context. I seem to recall that having happened with Gnus once. Let's hope it's not the case of CEDET, in which case the solution is to shoosh the byte-compiler in that particular spot. I'm > not familiar enough with eldoc to do so, though. > No problem, I'll do it. It's not hard, though, and the docstrings should guide anyone to do the same. > > I don't know why this particular compilation warning didn't pop up > > earlier, I don't recall it. > > It's been there ever since you obsoleted eldoc-message, of course. :-) > This is odd because I did get a line from Eli to fix some compilation after my changes, and these were not among them. I wonder if this file is always byte-compiled. Thanks, Jo=C3=A3o --0000000000009c534e05ae18a0cb Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Sun, Aug 30, 2020 at 2:47 PM Lars Inge= brigtsen <larsi@gnus= .org> wrote:
=C2=A0
> Lars, you want to fix the compilation warning or something else?=C2=A0= The
> function is obsolete, but it leep working.=C2=A0 The only "fix&qu= ot; is to follow
> the advice in the warning message.

If the function is obsolete, all in-tree callers should be fixed.=C2=A0

...unless that code is used in another non em= acs-master context. I
seem to recall that having happened wi= th Gnus once.=C2=A0 Let's hope
it's not the case of CEDET= , in which case the solution is to shoosh
the byte-compiler in th= at particular spot.

I'm
not familiar enough with eldoc to do so, though.

<= /div>
No problem, I'll do it.=C2=A0 It's not hard, though, and = the docstrings
should guide anyone to do the same.
= =C2=A0
> I don't know why this particular compilation warning didn't po= p up
> earlier, I don't recall it.

It's been there ever since you obsoleted eldoc-message, of course.=C2= =A0 :-)

This is odd because I did get a line= from Eli to fix some compilation
afte= r my changes, and these were not among them.=C2=A0 I wonder if this file
is always byte-compiled.

Thanks,
Jo=C3=A3o
--0000000000009c534e05ae18a0cb--