From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#62116: RFE: eglot: support window.showDocument LSP RPC Date: Mon, 8 May 2023 17:36:43 +0100 Message-ID: References: <87jzznxx8f.fsf@gmail.com> <83fsabwhpg.fsf@gnu.org> <87v8j7vy48.fsf@gmail.com> <83r0tuv62t.fsf@gnu.org> <874jp8gu8a.fsf@betli.tmit.bme.hu> <838re3jowg.fsf@gnu.org> <87ttwqsow9.fsf@gmail.com> <87ttwpbpaj.fsf@betli.tmit.bme.hu> <875y93arek.fsf@betli.tmit.bme.hu> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24617"; mail-complaints-to="usenet@ciao.gmane.io" Cc: sebastian.poeplau@mailbox.org, adonovan@google.com, 62116@debbugs.gnu.org To: Felician Nemeth Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 08 18:37:15 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pw3rP-0006Gz-8w for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 08 May 2023 18:37:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pw3rD-0004EX-L8; Mon, 08 May 2023 12:37:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pw3rC-0004EP-U1 for bug-gnu-emacs@gnu.org; Mon, 08 May 2023 12:37:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pw3rC-0006cu-Lt for bug-gnu-emacs@gnu.org; Mon, 08 May 2023 12:37:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pw3rC-0005Gk-6u for bug-gnu-emacs@gnu.org; Mon, 08 May 2023 12:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 May 2023 16:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62116 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 62116-submit@debbugs.gnu.org id=B62116.168356382120247 (code B ref 62116); Mon, 08 May 2023 16:37:02 +0000 Original-Received: (at 62116) by debbugs.gnu.org; 8 May 2023 16:37:01 +0000 Original-Received: from localhost ([127.0.0.1]:41459 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pw3rA-0005GV-MW for submit@debbugs.gnu.org; Mon, 08 May 2023 12:37:00 -0400 Original-Received: from mail-oo1-f43.google.com ([209.85.161.43]:49491) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pw3r9-0005GI-Dr for 62116@debbugs.gnu.org; Mon, 08 May 2023 12:36:59 -0400 Original-Received: by mail-oo1-f43.google.com with SMTP id 006d021491bc7-546ee6030e5so2389784eaf.3 for <62116@debbugs.gnu.org>; Mon, 08 May 2023 09:36:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683563814; x=1686155814; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=+JiKMihkHJCn04d9s6i0nV55HOWdq2LjaDSjZ7ruTJM=; b=AE+IzwGHu+mfO9Mb1Agm6Xz6l1j74gV9/CBgeXiAPiY94rQlKEARYQ7jGHcdqHfflb tuuMsnbXpQ9LNy1PeQWUI65gTX/Ymzp9UiDDF+8KD2haT/0z/JR3l9Qc1t0DNUIBLTvY nH/uFjizeEKmHcLSlnZSc9m4djDy+pkgAq+ZllNjv11zXQLKPByOWgJMp5xjM9W1n9cw 7M7lXbo+NWC8hURyJ+pGZudluCfHseOS1eiIt8HCE8CMCyuRjwBCxIjYeR+1lBalkfeX tzze8Yfgcyl6etnPNsvFWhXkt+ZkhuHLIjkODpttUieVk5A0e/Yo84oXjH6mQUmoxWHU XeNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683563814; x=1686155814; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+JiKMihkHJCn04d9s6i0nV55HOWdq2LjaDSjZ7ruTJM=; b=O74haJaESLrc5iAGgFdDGVEZ7JEzr8Y1QouzSjkIOWSf831mue0h/LdjQJ2L78apUE P7dj6DiEBCzPHBdWHRJbGMqVbp69K6YPvcbHjRQnk0PDhuFkV+74uWAfTWpfTYK8Y/dn KGYHx8UfxiGuy9/7OdXSuSZvBbyRdTrvdX1SjBonqNocvQxx8bW0rQTiGSj8VmphrVW4 cLnFr/R2/5Si3owwEu9cURMsSo3RhzifdoP2Yc89/teki7eRzOsqalD1j3UJqxFxkqiX 3bX10Fp0d67oUnwLJbcl8P3H7T+Acd/0KxcQEecpHyeGzAwbZ7whS2vl1GBd4pxDrq/S T97w== X-Gm-Message-State: AC+VfDy5mOdjIQEVktZX0B42UQpk6yzxbMcYCsmYuScobb4yKlyaAmv1 oYvRnSocmaH8ZwXOn1VxbqWjvGl/6bb5rr2ZLPWS4g7K X-Google-Smtp-Source: ACHHUZ5j8obZEHdaQvbX3Lc35aDUboXGzz7XBtTG6iY9vVv4adBZYINVG9IYp8X5A9DkkQ1jFe7kDUkOhLhz2WY+3QY= X-Received: by 2002:a05:6808:8c4:b0:38e:b9b:a85c with SMTP id k4-20020a05680808c400b0038e0b9ba85cmr4994423oij.53.1683563813863; Mon, 08 May 2023 09:36:53 -0700 (PDT) In-Reply-To: <875y93arek.fsf@betli.tmit.bme.hu> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261348 Archived-At: On Mon, May 8, 2023 at 2:23=E2=80=AFPM Felician Nemeth wrote: > > Felician Nemeth writes: > > > If I understand it correctly, you argued that if takeFocus is false, > > Eglot should still show the requested file, but the point should remain > > were it was. I think you're right, but I haven't updated my patch yet. > > It is enough to call display-buffer. I've attached the new patch and a > simple test that can be run with "emacs -Q -l test.el". > > Since it advances the status quo, can this be merged? If not, how > should we proceed? Haven't looked at it, but I'd say yes. However, Alan Donovan has replied recently, with a recipe showcasing his particular use case. I dont' have time to try it right now, but if you could try his recipe/use case with your solution, it would be great. One note that I didn't yet reply to is that IMO (likely in Alan's opinion too), it does make sense to raise the frame. The showDocument may indeed come from somewhere else which is not Emacs at all. I used to work with Common Lisp IDEs like that allowed the application being developed to issue requests to the editor and pop it up to the user. It was extremely convenient. Jo=C3=A3o