From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#62741: 30.0.50; Eglot jdtls project test: pass on emacs-29, fail on master Date: Mon, 10 Apr 2023 13:00:32 +0100 Message-ID: References: <87pm8dne2a.fsf@tcd.ie> <87zg7gna2m.fsf@gmail.com> <875ya4k5t6.fsf@tcd.ie> <87r0ssm9ra.fsf@gmail.com> <83e7126a-d0b0-b3a7-7cb1-809c041ba622@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9314"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Basil Contovounesios , 62741@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Apr 10 14:01:20 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1plqD2-0002Fn-GX for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 10 Apr 2023 14:01:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1plqCy-00015D-Qw; Mon, 10 Apr 2023 08:01:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1plqCn-0000zY-M0 for bug-gnu-emacs@gnu.org; Mon, 10 Apr 2023 08:01:11 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1plqCk-0002YH-Fz for bug-gnu-emacs@gnu.org; Mon, 10 Apr 2023 08:01:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1plqCk-0007Ug-3k for bug-gnu-emacs@gnu.org; Mon, 10 Apr 2023 08:01:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 10 Apr 2023 12:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62741 X-GNU-PR-Package: emacs Original-Received: via spool by 62741-submit@debbugs.gnu.org id=B62741.168112805328784 (code B ref 62741); Mon, 10 Apr 2023 12:01:02 +0000 Original-Received: (at 62741) by debbugs.gnu.org; 10 Apr 2023 12:00:53 +0000 Original-Received: from localhost ([127.0.0.1]:34466 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1plqCa-0007UC-Jh for submit@debbugs.gnu.org; Mon, 10 Apr 2023 08:00:52 -0400 Original-Received: from mail-oi1-f171.google.com ([209.85.167.171]:39761) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1plqCX-0007Tr-LX for 62741@debbugs.gnu.org; Mon, 10 Apr 2023 08:00:51 -0400 Original-Received: by mail-oi1-f171.google.com with SMTP id bx42so19401520oib.6 for <62741@debbugs.gnu.org>; Mon, 10 Apr 2023 05:00:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1681128044; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=LVNrIwVi3rfes3hoQTRNqgZ0RE6GYze10K28FK5/BXY=; b=PdYhrwv3n+WPMTqPQL6KNlZ5cLUsKNSEhpwZZDaNqaaWaqAFHmZOpi1tfYgvEi5//d boOTanUbDVlpnhnieq/7J+IPs2zE9II/aR/oQkSulQAirWr9K2n20ZtFS/4Bpcxws1ms IEHqd4e7zmu7HRhe6ktDLs2v38kz31xkqU7nfj9wBgpoaDksvafz3mkmbG5NbxoHDJym QxhS4kxpK57CQ9jQOHCQ50TsSQCycSG+vcAlDJ4JcVXEhc1lDgjKG1LVhcBWEbFCVYKA XqMKBh3GGLnpExACCnAdq8/cIB8uNWl7UjrVjGb0zqq8w++znMp1LTKrebeCMlB0gihp Uxpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681128044; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LVNrIwVi3rfes3hoQTRNqgZ0RE6GYze10K28FK5/BXY=; b=6x1hrHEry7HG7n36dXh/i8hJgmUD8z58Br/7dMSr7B1Gcjr0XJG8i6cLTIUrmOA0Zp +PXo8Vb0hJuYrndcEyXP0rvoayG9Gp/LdW5Kmp+alhoOza8rcZ558Rc2X4QdlcBoUd86 7qIJAljaeZmjeJAKo4diBZyxJzuAygbyWNrdl9UT3MJNjFo7NdOto+GJSxvbxiDzMYKo scPgybAXtvW86B6YZQbXi95XLQrq4gqOobPTDYJXWEqlqLY1+N6oggS6EsrzThIWTdCG idpZPoOuwYHMeImPzKkl1mzYvjSRUQyFHuLryrbdqauU0LTE7vCKBRrSm5DXUnqUWidE ajTQ== X-Gm-Message-State: AAQBX9dIndWE5B1DAz85XFVovq9Ria+lmdT3j1zs39J9DGaTWqt7a6bB cnfy60RcRAIWYgDJsAxKXzIW3uLb3WuWLvhheWc= X-Google-Smtp-Source: AKy350aKh9CUgh1pmTzV+ZSD4kdesEbRLwXr1vKyDnFWMfh0bffbz4GmPROM5/J/v6M+k4tSE76EArVQ9OH8lenq4As= X-Received: by 2002:a05:6808:2195:b0:386:a109:57c8 with SMTP id be21-20020a056808219500b00386a10957c8mr2417097oib.5.1681128043924; Mon, 10 Apr 2023 05:00:43 -0700 (PDT) In-Reply-To: <83e7126a-d0b0-b3a7-7cb1-809c041ba622@gutov.dev> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:259565 Archived-At: On Mon, Apr 10, 2023 at 12:56=E2=80=AFPM Dmitry Gutov wr= ote: > > Hi! > > On 10/04/2023 11:17, Jo=C3=A3o T=C3=A1vora wrote: > > This is very odd then. Why would project-files fail in the face of > > (presumably) a perfectly well-behaved Git repository? > > > > Pasting the backtrace here for Dmitry to have a look. > > > > Test eglot-test-eclipse-connect backtrace: > > string-match("\0" nil 0) > > split-string(nil "\0" t) > > project--vc-list-files("/tmp/eglot--fixturernYTOR/project/" Git nil) > > #f(compiled-function (dir) #)("/tmp/egl= ot--fixturernYTOR/project/") > > mapcan(#f(compiled-function (dir) #) ("= /tmp/eglot--fixturernYTOR/project/")) > > #f(compiled-function (project &optional dirs) #)((vc Git "/tmp/eglot--fixturernYTOR/project/")) > > apply(#f(compiled-function (project &optional dirs) #) (vc Git "/tmp/eglot--fixturernYTOR/project/") nil) > > project-files((vc Git "/tmp/eglot--fixturernYTOR/project/")) > > > > It would seem that the problem here is there are no files versioned yet= , > > so this expression in project--vc-list-files > > > > (apply #'vc-git--run-command-string nil "ls-files" args) > > > > Returns nil. > > > > But I cannot reproduce this locally. > > I haven't been able to reproduce this locally either. If I just use a > repo after 'git init', the return value of vc-git--run-command-string > (inside project--vc-list-files) is an empty string, not nil. > > Could this be that the repo in the test isn't actually initialized? Or > maybe there's something different in the test environment. My Git > version is 2.37.2. In the GitHub CI, Basil used both strategies, iow he invoked "git init" in a directory that already had an empty ".git" directory. Maybe the Git version in GitHub's ubuntu machines doesn't react to that the same way my Git version does (which is to not be bothered by the existing directory, and do its work all the same). I don't think this is extremely important though. It'll pop up eventually if it is a real problem. Jo=C3=A3o