bug#34294: 27.0.50; flymake-start-on-save-buffer has no effect

["João Távora" <joaotavora@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1537 bytes --]

On Sun, May 5, 2019 at 9:10 PM Juri Linkov <juri@linkov.net> wrote:

> > I have flymake-start-on-save-buffer customized to 't' to check syntax
> > only when a buffer is saved, but it still checks the unfinished work
> > while edits are in progress, showing the errors that make no sense
> > until the buffer is saved, even when
> flymake-start-syntax-check-on-newline
> > and flymake-start-on-flymake-mode are nil.
> >
> > Is it possible to customize flymake to kick in only on saving?
>
> Pushed to master changes confirmed by João.
>

I guess I can't complain much, since I've been largely absent due to
absolute lack of time, and very late on the review of these patches.
I also think we're conflating lots of different stuff on this issue, which
makes it difficult for me to follow.

Anyway, your initiative got my attention.  Do you remember what I
wrote previously?

> [jt] I would even go as far as obsoleting the variable entirely, and
> use make-obsolete-variable instead: there's no real reason
> why newline should be given special treatment.  And users
> that need this for some obscure reason can probably plug it
> in post-self-insert-hook.

> If you obsolete the variable, you can remove it from the
> manual, too.

I still think this is the best option, so if you didn't already push that,
I would be thankful that you do. It should solve your issue and make
the code and manual simpler.

And maybe consider opening different bugs for the other issues?

Thanks,
-- 
João Távora

[-- Attachment #2: Type: text/html, Size: 2195 bytes --]