From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#53853: [PATCH] Don't use string-replace in flymake Date: Tue, 8 Feb 2022 09:58:06 +0000 Message-ID: References: <87r18e7fb7.fsf@gmail.com> <87zgn1ublj.fsf@gnus.org> <87mtj17oqg.fsf@gmail.com> <87ee4d7o3f.fsf@gmail.com> <875ypp7kmu.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000b5948a05d77ebe6c" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="689"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Brian Leung , Lars Ingebrigtsen , 53853@debbugs.gnu.org To: Robert Pluim , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Feb 08 11:43:08 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nHNxk-000AcI-IT for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 08 Feb 2022 11:43:08 +0100 Original-Received: from localhost ([::1]:53904 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nHNxj-0001rC-5g for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 08 Feb 2022 05:43:07 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:35684) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nHNG6-00019V-A6 for bug-gnu-emacs@gnu.org; Tue, 08 Feb 2022 04:58:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51469) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nHNG5-00014N-Rb for bug-gnu-emacs@gnu.org; Tue, 08 Feb 2022 04:58:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nHNG5-0005Gt-PG for bug-gnu-emacs@gnu.org; Tue, 08 Feb 2022 04:58:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Feb 2022 09:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53853 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 53853-submit@debbugs.gnu.org id=B53853.164431425820232 (code B ref 53853); Tue, 08 Feb 2022 09:58:01 +0000 Original-Received: (at 53853) by debbugs.gnu.org; 8 Feb 2022 09:57:38 +0000 Original-Received: from localhost ([127.0.0.1]:45366 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nHNFi-0005GF-Bl for submit@debbugs.gnu.org; Tue, 08 Feb 2022 04:57:38 -0500 Original-Received: from mail-ot1-f46.google.com ([209.85.210.46]:41630) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nHNFe-0005G1-NW for 53853@debbugs.gnu.org; Tue, 08 Feb 2022 04:57:37 -0500 Original-Received: by mail-ot1-f46.google.com with SMTP id b12-20020a9d754c000000b0059eb935359eso12859359otl.8 for <53853@debbugs.gnu.org>; Tue, 08 Feb 2022 01:57:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pM6SjsQRigyrIxp1PZxR510d2ht+dBrk0viloMApvEY=; b=cKMM7teUutc55nq8/bXZOOMU/NwMXAUklVKuqCR10df1Gh57AkGfmUBk6yI7p+0InN xSMSL/aJrO89p+Sa73DpuIJRN7Xu3woZfjK/QInRb4gbs9GToe/cGRX4UM14PA4iWa5b hMLreV/h+S4PO3XUfg6qj3uyEsv2qrTOTfR2VlgCf/ES6YpnSbl/0fX+QLLPlCCA2M2I 4Ur79rCCCj0VuJWvFrnwwgR2SbnCO9AOar1YJViteHwP5tKNKj45rzJS0cjc9Rv1kuql xsvsnatizqgCaISbPXwT+fAnz6SbxcShP0Ggj+BHluFw4OojIOSjTvnrRW+2Lc2XdDoH OeIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pM6SjsQRigyrIxp1PZxR510d2ht+dBrk0viloMApvEY=; b=EtXF07lV/w0uNPH6KVVoOwkQHRgorr+xIYtmPa7R1LNXbZC86NoxmMk5B86H0yYrOH lOJr0FM+/Gtee2dcbsb1g1j8edlfZz6kEkIUn2n7t7S84Hoc9nPKq8WDj5u9HQdiQSXp XQ86jTf5qmKT9hIAWDsYdbIm/HVPh7R07HFHkdfdxPSN97BQiXs9dUTqrf4jdAQg72Mw 7ppbZ3pJBwbhRyDoRSp+tEVsAWdRoLQ+p2AgVJNudi0puPTc/noqJFKUAncrE6BV181P Ip7/wdmMuHQLttziZzgkmUCGjSRBa4S9drh2cdxULB/MmDkKMTQtKJ/YLtmPzvAoSLAt T9fA== X-Gm-Message-State: AOAM530AUC44x4fga0tmRO4d2htKwxSe2UzjfuXnaJ9DwFpH1fM84q5h e4zrA70BwmcLGnz8MNwhwbgg4tkGlOj1sU16/Mo= X-Google-Smtp-Source: ABdhPJySfdviDsJUjzc2PZuY6OF/uOGlCHKUG1BCc+KBONsswKGtKLQa+uPT50jJZejxIbr9Oz+kOWW8qdO8JWAl6l0= X-Received: by 2002:a9d:4806:: with SMTP id c6mr1461391otf.317.1644314248974; Tue, 08 Feb 2022 01:57:28 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:226356 Archived-At: --000000000000b5948a05d77ebe6c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Eli, how are you? I hope well. This change: commit 6b8957852476e4ba31873424aa8f81d9e55bc34c Author: Eli Zaretskii Date: Thu Dec 9 17:01:57 2021 +0200 ; * lisp/progmodes/flymake.el: Update the minimum Emacs version. diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el --- a/lisp/progmodes/flymake.el +++ b/lisp/progmodes/flymake.el @@ -9,1 +9,1 @@ -;; Package-Requires: ((emacs "26.1") (eldoc "1.1.0") (project "0.7.1")) +;; Package-Requires: ((emacs "28.1") (eldoc "1.1.0") (project "0.7.1")) breaks "downstream" users of flymake.el as a "core" package, eglot.el most notably. Can you explain it? I'm not 100% sure if we have discussed this before. If we have, I'm very sorry, but I forgot the context. Thanks, Jo=C3=A3o On Tue, Feb 8, 2022 at 9:54 AM Jo=C3=A3o T=C3=A1vora = wrote: > On Tue, Feb 8, 2022 at 9:50 AM Robert Pluim wrote: > >> >>>>> On Tue, 8 Feb 2022 09:20:07 +0000, Jo=C3=A3o T=C3=A1vora < >> joaotavora@gmail.com> said: >> >> Jo=C3=A3o> I'm not in front of my computer right now, but as far as = I >> recall, there is >> Jo=C3=A3o> a note in the preamble of flymake.el asking maintainers n= ot to >> use >> Jo=C3=A3o> functionality incompatible with the given emacs dependenc= y. >> >> There is, and the current flymake.el says emacs-28. >> > > Does it? That's news to me. It shouldn't, I think. That breaks a lot o= f > downstream > users, eglot.el most notably. > > I have to M-x vc-region-history that bit. > > Jo=C3=A3o > > > --=20 Jo=C3=A3o T=C3=A1vora --000000000000b5948a05d77ebe6c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Eli, how are you?=C2=A0 I hope well.
This change:

commit 6b8957852476e4ba3= 1873424aa8f81d9e55bc34c
Author: Eli Zaretskii <eliz@gnu.org>
Date: =C2=A0 Thu Dec 9 17:01:57 2021 +020= 0

=C2=A0 =C2=A0 ; * lisp/progmodes/flymake.el: Update the minimum Em= acs version.

diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes= /flymake.el
--- a/lisp/progmodes/flymake.el
+++ b/lisp/progmodes/flym= ake.el
@@ -9,1 +9,1 @@
-;; Package-Requires: ((emacs "26.1"= ) (eldoc "1.1.0") (project "0.7.1"))
+;; Package-Req= uires: ((emacs "28.1") (eldoc "1.1.0") (project "0= .7.1"))

breaks "downstream" users o= f flymake.el as a "core" package, eglot.el
most notably= .=C2=A0

Can you explain it?=C2=A0 I'm not= 100% sure if we have discussed this before.
If we have, I'm = very sorry, but I forgot the context.

Thanks,
<= /div>
Jo=C3=A3o

On Tue, Feb 8, 2022 at 9:54 AM Jo=C3=A3o T=C3= =A1vora <joaotavora@gmail.com> wrote:
On Tue, Feb 8, 2022 at 9:50 AM Robert Pluim <rpluim@gmail.com> wrote:
>>>>> On Tue,= 8 Feb 2022 09:20:07 +0000, Jo=C3=A3o T=C3=A1vora <joaotavora@gmail.com> said:

=C2=A0 =C2=A0 Jo=C3=A3o> I'm not in front of my computer right now, = but as far as I recall, there is
=C2=A0 =C2=A0 Jo=C3=A3o> a note in the preamble of flymake.el asking mai= ntainers not to use
=C2=A0 =C2=A0 Jo=C3=A3o> functionality incompatible with the given emacs= dependency.

There is, and the current flymake.el says emacs-28.
Does it?=C2=A0 That's news to me.=C2=A0 It shouldn't, = I think.=C2=A0 That breaks a lot of downstream
users, eglot.= el most notably.

I have to M-x vc-region-his= tory that bit.

Jo=C3=A3o

<= div>


--
Jo=C3=A3o T=C3=A1vora
--000000000000b5948a05d77ebe6c--