From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#68547: [PATCH] ; Fix 'mode-line-format-right-align' with ElDoc Date: Sun, 21 Jan 2024 08:52:33 +0000 Message-ID: References: <83cytwtjiw.fsf@gnu.org> <83plxvsweh.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15745"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 68547@debbugs.gnu.org To: Eshel Yaron Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 21 09:53:24 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rRTZz-0003pR-Q3 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 21 Jan 2024 09:53:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rRTZc-0005pV-Bt; Sun, 21 Jan 2024 03:53:00 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rRTZa-0005ow-QN for bug-gnu-emacs@gnu.org; Sun, 21 Jan 2024 03:52:58 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rRTZa-0007Lf-IP for bug-gnu-emacs@gnu.org; Sun, 21 Jan 2024 03:52:58 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rRTZd-0008AC-SM for bug-gnu-emacs@gnu.org; Sun, 21 Jan 2024 03:53:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 21 Jan 2024 08:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68547 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 68547-submit@debbugs.gnu.org id=B68547.170582717531366 (code B ref 68547); Sun, 21 Jan 2024 08:53:01 +0000 Original-Received: (at 68547) by debbugs.gnu.org; 21 Jan 2024 08:52:55 +0000 Original-Received: from localhost ([127.0.0.1]:36578 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rRTZW-00089p-Pz for submit@debbugs.gnu.org; Sun, 21 Jan 2024 03:52:55 -0500 Original-Received: from mail-lf1-x12c.google.com ([2a00:1450:4864:20::12c]:46426) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rRTZU-00089b-Hn for 68547@debbugs.gnu.org; Sun, 21 Jan 2024 03:52:53 -0500 Original-Received: by mail-lf1-x12c.google.com with SMTP id 2adb3069b0e04-50ea98440a7so2072303e87.1 for <68547@debbugs.gnu.org>; Sun, 21 Jan 2024 00:52:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705827163; x=1706431963; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=70e0O0FF09pUvoIAEz+iZYkRj9+32lmiiUH2mYupxjU=; b=lPFkBGsDi16xSGiVyalw83kxt3QscN7JHACWhReTfPwSM7HVomAJwM4eG3+u6pBFkd 9XuRL5uo5/Ajd3ljqZMpvACDlJazpq5YJwYH/r40U8n7tlAl1Nda+dCqUIKEIHS3fKYT zogXdRI8Pe6mrzZmcgCKs0mF55/LaMg4L+cddhIRScazdx/DS7VTKg/aOMZjAGySJdWO XbnnHXhjxnL4crrrGdpEqRAXlqRCssI3iChRajsXZy5HTPAp27wE1zR4qyouCUjMgnNe MfhEuWAiPpPyg/JLBvV8/1ty3rhy5OWFTu0ClvkXOMM/UyywJKqpC42yYfBmXNX+pNNN 72mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705827163; x=1706431963; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=70e0O0FF09pUvoIAEz+iZYkRj9+32lmiiUH2mYupxjU=; b=NcdwiYYNZ3HXXJbmOyWdxqDICvZtvSDnOy+Y5Jx07/5xGx7xLrDaEDKjLfAg548YvQ 6UH9wbJ2C/W8VuA8Az4l9m0GTYlvjL3h2tvXpejLhgEWX4RDDcwI8ktGIluFfJPqk6T1 KOZCpi2Drof49VnjZL/7aQ2fbRgXqiubXLjU5zB6L3kuym/hY72lwAeuV661kzMxxUkV rvZTQkVKK0isRXKYJclvdkYk9wT3VeVfW6rTqfqcs8xdvc5p8VijBK47auJK7vMIi9nx tdPGD5rWyeZLSakoYQSg0AH0Cg4kP3yT2uFUfe/sGTJdMZ6qeAJeIeirE1rctRir1mBr qmGQ== X-Gm-Message-State: AOJu0YwyQVmazLbYQix810SMoNncjAyNHYniyLta3W1zkKLMdbiHtVZy mTuu5WmBCG7YGN7cQqr51DAoryzKdjk6VPlOh/krrfxRWEihO/dCCc0qwEfyExkrDTiltW1Wfyu aPJ32NaxyhskxakeTi9JfWwsc7T8= X-Google-Smtp-Source: AGHT+IGXB84ZTWvVBOmONcQlP0r1LrVZujsiqEtSxR3K4GVSdNGjTDy5HI/BmkisOhQsTFkUcrVXRZDdo45VOkCrXU8= X-Received: by 2002:a05:6512:3c8d:b0:50e:80fe:add8 with SMTP id h13-20020a0565123c8d00b0050e80feadd8mr689470lfv.41.1705827163044; Sun, 21 Jan 2024 00:52:43 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:278657 Archived-At: On Sun, Jan 21, 2024 at 8:34=E2=80=AFAM Eshel Yaron wro= te: > I tried your new patch, and it works well, AFAICT. Two suggestions: > > 1. This patch omits a space that would appear before the info on the > mode line. I like that bit of padding, so I suggest restoring it :) OK. > 2. In `eldoc--message-in-mode-line`, `add-hook` and `remove-hook` can be > called with non-nil LOCAL argument to further localize the effect, > although I'm not sure that makes a real difference in practice. I tend to think it would break your pathological use cases of shuffling buffers above the minibuffer while it is ongoing, no? Two or more separate transient cleanup lambdas can appear in those cases, no? Jo=C3=A3o