From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#58790: Eglot URI parsing bug when using clojure-lsp server Date: Wed, 23 Nov 2022 12:54:09 +0000 Message-ID: References: <87cza40xgs.fsf@dfreeman.email> <83edubrvf0.fsf@gnu.org> <87cz9v9irh.fsf@gmail.com> <83o7terf9a.fsf@gnu.org> <87k042tqze.fsf@dfreeman.email> <87fseqtpiu.fsf@dfreeman.email> <875yfm8lzf.fsf@gmail.com> <83wn82osoo.fsf@gnu.org> <871qq8xfzr.fsf@gmx.de> <87mt8uwo2q.fsf@dfreeman.email> <87zgcs6nvb.fsf@gmx.de> <87r0y3luad.fsf@dfreeman.email> <87iljf72ua.fsf@gmx.de> <87a64qykcf.fsf@gmx.de> <8735ab12pr.fsf@gmx.de> <720bcf72-e944-4978-982f-4b6fa8b31e5c@gmail.com> <86o7sxg7u7.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000fe41af05ee22c487" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21707"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Felician Nemeth , Danny Freeman , 58790@debbugs.gnu.org, Arash Esbati , Michael Albinus , Stefan Kangas , Dmitry Gutov , Eli Zaretskii To: Richard Copley Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 23 13:54:20 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oxpGd-0005TF-6K for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 23 Nov 2022 13:54:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oxpGQ-0001HR-Al; Wed, 23 Nov 2022 07:54:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxpGM-0001Gs-PQ for bug-gnu-emacs@gnu.org; Wed, 23 Nov 2022 07:54:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oxpGM-00048u-Aq for bug-gnu-emacs@gnu.org; Wed, 23 Nov 2022 07:54:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oxpGM-0004WO-7T for bug-gnu-emacs@gnu.org; Wed, 23 Nov 2022 07:54:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Nov 2022 12:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58790 X-GNU-PR-Package: emacs Original-Received: via spool by 58790-submit@debbugs.gnu.org id=B58790.166920799317300 (code B ref 58790); Wed, 23 Nov 2022 12:54:02 +0000 Original-Received: (at 58790) by debbugs.gnu.org; 23 Nov 2022 12:53:13 +0000 Original-Received: from localhost ([127.0.0.1]:54111 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxpFY-0004Uv-Pw for submit@debbugs.gnu.org; Wed, 23 Nov 2022 07:53:13 -0500 Original-Received: from mail-ot1-f41.google.com ([209.85.210.41]:42666) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxpFW-0004UU-BI for 58790@debbugs.gnu.org; Wed, 23 Nov 2022 07:53:12 -0500 Original-Received: by mail-ot1-f41.google.com with SMTP id a13-20020a9d6e8d000000b00668d65fc44fso11132662otr.9 for <58790@debbugs.gnu.org>; Wed, 23 Nov 2022 04:53:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=o1Lk7MA+D6b045u6SiQ26BrYMW3aKrKa1MlcOzOpDNU=; b=g1U4z11wrMChui5kY1u3HeAA93Xsk0Tgmx/o3fyTOEzd5YQ+/GKu9qavHhuqI8tHFS 8TSmo2p3/NvfJZqq+ykmPcA+SJar2303kwhuk/Ri1/RxNFL7f2WalvDBOMmT37oos1hJ p1i2SmjD9QTVT9kmjm6CIpx/FOpm1LpV4jv0/NjsWv7Dn9oPA3mo3Hug7HSMPx7/jMvA g1peovx/MVpeZUEIOtgYPMROxvpKTrF1HBeVIUyaAFP7ijkJU7BdZteOQ/Yi+QJ+xkYE F+A7b6Hag5EvZW8h0w+a1P4K/oNAG4mZ3XZDJviHAV9zOCRCuGQfhiq/MXS0yodYZxN6 B2fA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=o1Lk7MA+D6b045u6SiQ26BrYMW3aKrKa1MlcOzOpDNU=; b=NsdAXYMCLiuunORSL+RJHQi/G77CAGZBpRWYDezTApeSto597u3U4qJ3sfHbXn0Qen cc0mgc7QCmSWiWxAyZk7bgeuMwBZQlrBEI5qF7gAFxBoX3FAp3fjc8f4LUEw9FR+Wm5b k9Es8+fCwftYfZi1erOh8Ueac3PwIXoff640KdVXQcuSmdkj4oJ5OlFEya1dJImNrXPO dzmpnLpkhA3PzFVZVQaBYuXONnQuFd5f7v2MXinqrV50KcnA079dSlk/Mzrksv5muIKL f1qLDaxyRYROovoQW1cNEb60jcayJNSX/UKBCbkpIOQmMxu/tbY/jrGG614zb18h0/kY zgpg== X-Gm-Message-State: ANoB5pmh7vqms0yIJc0t74R7ZleLWuStsCYrEHbzNd23BYEbHtioXhGw 9YXaj7GRndL1wWTMBCaWjsNV+ZWSUS7GiECP01U= X-Google-Smtp-Source: AA0mqf7iflDXZ2SQDgnuT4hrOtI/YBUV4MybKtqW3RtQn7bsICaqw7k2BH1ci3E4R7K7Y97yIdI98QF1FX/fq04qo44= X-Received: by 2002:a9d:4f07:0:b0:66c:64d6:1bb4 with SMTP id d7-20020a9d4f07000000b0066c64d61bb4mr14268122otl.201.1669207984847; Wed, 23 Nov 2022 04:53:04 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248737 Archived-At: --000000000000fe41af05ee22c487 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Nov 23, 2022 at 12:49 PM Richard Copley wrote: > > Thanks, yes. > > > > So either url-generic-parse-url and url-type is fixed in url-parse.el= , > or > > > we must add some Windows-specific guards in eglot.el. Or likely > > > both, since url-parse.el is not a :core ELPA package. > > I don't think "url-generic-parse-url" needs any fix. It is for parsing a > URL, > not deciding if something is a URL. > That's... arguable. But OK, if we go with that, then we need a function to decide if something is an URL, because it's exactly what we're aiming for to do here. But let's continue in the other bug report: I've CC'ed you in my last message. Jo=C3=A3o --000000000000fe41af05ee22c487 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Wed, Nov 23, 2022 at 12:49 PM Richard = Copley <rcopley@gmail.com> w= rote:

Thanks, yes.

> > So either url-generic-parse-url and url-type is fixed in url-pars= e.el, or
> > we must add some Windows-specific guards in eglot.el.=C2=A0 Or li= kely
> > both, since url-parse.el is not a :core ELPA package.

I don't think "url-generic-parse-url" needs any fix. It is fo= r parsing a URL,
not deciding if something is a URL.

Tha= t's... arguable. But OK, if we go with that, then we need a function to=
decide if something is an URL, because it's exactly what we&= #39;re
aiming for to do here.

B= ut let's continue in the other bug report: I've CC'ed you in my= last
message.

Jo=C3=A3o
<= /div>
--000000000000fe41af05ee22c487--