From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#54488: 29.0.50; move-to-column/overlay-related regression in latest master, perhaps 28? Date: Wed, 23 Mar 2022 11:08:55 +0000 Message-ID: References: <87bkxzdccp.fsf@gmail.com> <831qyvfpv4.fsf@gnu.org> <83fsnbfd72.fsf@gnu.org> <8735jbc6gj.fsf@gmail.com> <6095582d-7065-8089-e8c7-857f070f8ce2@yandex.ru> <87y212b9nt.fsf@gmail.com> <83a6difahu.fsf@gnu.org> <835yo6f5tu.fsf@gnu.org> <834k3qf48k.fsf@gnu.org> <87r16uavhm.fsf@gmail.com> <83zglidnbs.fsf@gnu.org> <83y212dj2w.fsf@gnu.org> <83mthhe3rp.fsf@gnu.org> <87fsn9f07t.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000059be1005dae0be72" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34109"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 54488@debbugs.gnu.org, Dmitry Gutov To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Mar 23 12:12:22 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nWyua-0008hT-Fz for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 23 Mar 2022 12:12:20 +0100 Original-Received: from localhost ([::1]:51574 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nWyuZ-0004GE-1g for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 23 Mar 2022 07:12:19 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:34534) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nWyrQ-0007yb-7Z for bug-gnu-emacs@gnu.org; Wed, 23 Mar 2022 07:09:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48994) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nWyrO-0005t3-A3 for bug-gnu-emacs@gnu.org; Wed, 23 Mar 2022 07:09:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nWyrO-0008A1-1v for bug-gnu-emacs@gnu.org; Wed, 23 Mar 2022 07:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Mar 2022 11:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54488 X-GNU-PR-Package: emacs Original-Received: via spool by 54488-submit@debbugs.gnu.org id=B54488.164803369231298 (code B ref 54488); Wed, 23 Mar 2022 11:09:02 +0000 Original-Received: (at 54488) by debbugs.gnu.org; 23 Mar 2022 11:08:12 +0000 Original-Received: from localhost ([127.0.0.1]:42891 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWyqa-00088k-7j for submit@debbugs.gnu.org; Wed, 23 Mar 2022 07:08:12 -0400 Original-Received: from mail-oi1-f170.google.com ([209.85.167.170]:43877) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWyqY-00088U-6O for 54488@debbugs.gnu.org; Wed, 23 Mar 2022 07:08:10 -0400 Original-Received: by mail-oi1-f170.google.com with SMTP id w127so1238794oig.10 for <54488@debbugs.gnu.org>; Wed, 23 Mar 2022 04:08:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=n16kfbXc3Fd9kHxxsrmKz3Olb0sl4A8KsCKeLQ8/udw=; b=gC6THfF9qia0J2+o0FMg1tPdQZVhANbXIq9LY+WX6MaRyDBNNpMzViVMeKFFqXeQW/ jebOJFkpiYEPjwO+mtb+BenY/DeGF/rhJictguE4sRrxn5vetwPgshEu4oYH34prhRsZ h4QGTMBcWc08AhMoHPNUgrAjbUC2/xixSiZgevTGb6bHz0Mo4qkrFDI/Z0pJY6CRJI/B IkHYYJqPe9+T5pc3aVcYpY+QqWS/5C5nRhBAEPQzrFzH09HxNKOlfpV3C2R+YI1D3msq JRcZSoUr+U1dQ6/WvDmmzBHdeHnVB3ed5RkbjOWo+4857QtYxtA2XHgAwbfCQ5LTXiKi JgJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=n16kfbXc3Fd9kHxxsrmKz3Olb0sl4A8KsCKeLQ8/udw=; b=yCCY8r50WEWb1xP95cPKKF4l/hsyCvsB6EHYsVdcEKPUoe5xD2BmtKMQ3z9DIBffZ8 PSaQ1VlcXx6ZW8hlTBnl7z5sHUsal0ZYb3q52TubCAq1xU/haSSuLwQQ7nxg/h5Qlrkz ee+LXzfnECV+7u46rd9VDa6n03ZkcL3qPrVWe/IpZhC7kVyO4zKlYfc+jPS1Qm/wUkCv i7RM+qkLn7bdN7YAl8oCMUHtS0ObEe2L2IF9vkzaU8KY/YL82vZq4Seblm1jkrkcowBo QhdB0B9RyhI1AVDIdIDDUO6O4pDFHBG9bbcho3qrNhkF+xhDzJMRvNcXikwof7nQO6nq Gjdg== X-Gm-Message-State: AOAM53309/UntMbYxpf1Q5xxMxsVSk3qqNH8swrn6b3aDkxpF6CkceV1 AIqPlb3rwmDWsatDD0KUTlpABSmqo88eeLBUtp8= X-Google-Smtp-Source: ABdhPJw9lbyTl9czA1BoqFk1bfgQKe1NA871ghStzy3yDwidY/hbPotmrM6UzMQrCj0LsW8uTv5gzLdM1MPNAQ5PUgI= X-Received: by 2002:aca:2b0d:0:b0:2d9:dc99:3898 with SMTP id i13-20020aca2b0d000000b002d9dc993898mr4067552oik.209.1648033684634; Wed, 23 Mar 2022 04:08:04 -0700 (PDT) In-Reply-To: <87fsn9f07t.fsf@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:228795 Archived-At: --00000000000059be1005dae0be72 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Mar 23, 2022 at 10:09 AM Jo=C3=A3o T=C3=A1vora wrote: > Eli Zaretskii writes: > > PS: I do invite you to read that old Eglot issue. Since you're an > expert on coding system conversion, maybe you know of a better, faster > way to find the correct LSPish column in an Emacs buffer. Maybe the > whole search idea is completely overwrought. > These issues may give additional context about the need for this particular move-to-column dance. https://github.com/joaotavora/eglot/issues/125 (the one I gave you already) https://github.com/joaotavora/eglot/issues/124 (the bug that prompted the 125 fix) https://github.com/joaotavora/eglot/issues/361 (an easier to grasp manifestation of the problem) Also, I think the current fix of Eglot is decent. It will be slower when there are company-mode overlays, but those are in much lower numbers compared to LSP-abiding positioning requests. And some seem to be moving away from company-mode and its overlay-based completion display anyway. So this is not urgent. But I still do think there was a regression in Emacs somewhere: I've described an unequivocal reproduction recipe, just not something that can be shared among us, due to technical (or licensing) hurdles. Jo=C3=A3o --00000000000059be1005dae0be72 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Wed, Mar 23, 2022 at 10:09 AM Jo=C3=A3= o T=C3=A1vora <joaotavora@gmail.= com> wrote:
Eli Zaretskii <eliz@gnu.org> writes:

PS: I do invite you to read that old Eglot issue.=C2=A0 Since you're an=
expert on coding system conversion, maybe you know of a better, faster
way to find the correct LSPish column in an Emacs buffer.=C2=A0 Maybe the whole search idea is completely overwrought.

These issues may give additional context about the need for this part= icular
move-to-column dance.

https://github.com= /joaotavora/eglot/issues/125 (the one I gave you already)
<= div>https://gith= ub.com/joaotavora/eglot/issues/124 (the bug that prompted the 125 fix)<= /div>
https:= //github.com/joaotavora/eglot/issues/361 (an easier to grasp manifestat= ion of the problem)

Also, I think the curre= nt fix of Eglot is decent.=C2=A0 It will be slower when there are
company-mode overlays, but those are in much lower numbers compared t= o LSP-abiding
positioning requests. And some seem to be movi= ng away from company-mode
and its overlay-based completion d= isplay anyway.=C2=A0 So this is not urgent.

But I = still do think there was a regression in Emacs somewhere: I've describe= d an
unequivocal reproduction recipe, just not something that can= be shared among us,
due to technical (or licensing) hurdles= .

Jo=C3=A3o
--00000000000059be1005dae0be72--