From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#50946: Emacs-28: Inadequate coding in hack-elisp-shorthands Date: Sat, 2 Oct 2021 16:02:05 +0100 Message-ID: References: <831r54einq.fsf@gnu.org> <871r54xnds.fsf@gmail.com> <87ee933bcj.fsf@gmail.com> <83pmsnbnci.fsf@gnu.org> <83k0ivbjbu.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9386"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 50946@debbugs.gnu.org, Stefan Monnier To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 02 17:04:53 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mWgZI-0002KB-S7 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 02 Oct 2021 17:04:52 +0200 Original-Received: from localhost ([::1]:39744 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mWgZH-0003tL-Tz for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 02 Oct 2021 11:04:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52014) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mWgXW-0000Q2-J7 for bug-gnu-emacs@gnu.org; Sat, 02 Oct 2021 11:03:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48699) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mWgXW-0006QV-6C for bug-gnu-emacs@gnu.org; Sat, 02 Oct 2021 11:03:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mWgXW-0005e4-2c for bug-gnu-emacs@gnu.org; Sat, 02 Oct 2021 11:03:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 Oct 2021 15:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50946 X-GNU-PR-Package: emacs Original-Received: via spool by 50946-submit@debbugs.gnu.org id=B50946.163318694321645 (code B ref 50946); Sat, 02 Oct 2021 15:03:02 +0000 Original-Received: (at 50946) by debbugs.gnu.org; 2 Oct 2021 15:02:23 +0000 Original-Received: from localhost ([127.0.0.1]:60245 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mWgWs-0005d2-Op for submit@debbugs.gnu.org; Sat, 02 Oct 2021 11:02:23 -0400 Original-Received: from mail-pg1-f171.google.com ([209.85.215.171]:35594) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mWgWq-0005co-93 for 50946@debbugs.gnu.org; Sat, 02 Oct 2021 11:02:21 -0400 Original-Received: by mail-pg1-f171.google.com with SMTP id e7so12264469pgk.2 for <50946@debbugs.gnu.org>; Sat, 02 Oct 2021 08:02:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=V3WuqQXCvIcIZucXIjVAYBa6iA+BzwviCVtkXRQaxII=; b=GTmE2pAYyMnXVRceatGneJOn5HpItIxsFp1oB5s+yDnjmyCm+nAh7SNmgx9BXETFls oDgM5V98ebzeaVSS+enBP+/OmfIl2BrnBZEvN67c4zmm1NujFpue+xvBBR72TQOzvxjI GMIM8y1yf11tiC8RWNnj4wsd+ApAo9voNABCgpjnVMyNcIB/TxkKIKcvlpGIJtfYZUoO jfEcO4E1fAOhq7wn7poDGaIRxS3qz72bzogkTQ9UEfqfFUCBhQPYYPfi06Svf5fAIWlx 9IvanaxWGvkDTBzUUAG4d+Siex4M9Hu0xDTm2wqUvaFpjGRO2ZLgeU1bOpmnO4CYiHrQ fzKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=V3WuqQXCvIcIZucXIjVAYBa6iA+BzwviCVtkXRQaxII=; b=ZpBinSGgCjvh6RnX91QOM1x6nTIZ29pebkt/IVXu+yFZpPjB4IyRb+y/vwOluEya5y ZHmjgzF1nQ5e9i2BLDpMKxKdqIKu1WcAIfbd41KtSNIlvSuyTrBcGCFOHwVFXlgNt2k8 e+xrBfnJKKQ2dYeUVvbVnDrqPMOUx/AzkPFqdKfsD5s/fIpfRborOrhsjvt++r9GIQ/V 3Un/7qCBed4+GLHzU845zzj7PT3AHWxEhIbq9laaDoA3dg2jauxeyuopz+Qv7xtYIPai 8aZdv/Wk5IrYDHU5mAiTSfeEs4jeqaBoW/QzmRf4EpsQTdneMZpqWnmmkrks1hjoYq0F dDGQ== X-Gm-Message-State: AOAM531Z9q16xkdVbi1eu71RTk2jELyml/bXIW0VPMf+MnwtN98OFLcR kG4NNi85uWC+wKEuMtrb0Wwg1Cyr0/EA68a79jw= X-Google-Smtp-Source: ABdhPJxhP4rQwfn61wqQrncwHvJRwDfGqx21AXd24Xeyto+V/2U8FBpQR0ifrLDbETVKmiC+iZF7jubCU21IPYu3QVk= X-Received: by 2002:a63:4c5c:: with SMTP id m28mr3127142pgl.67.1633186934376; Sat, 02 Oct 2021 08:02:14 -0700 (PDT) In-Reply-To: <83k0ivbjbu.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:216167 Archived-At: Eli, You can reopen this bug if you want. Eventually, hack-elisp-shorthands wil= l go into load-with-code-conversion or something just before it evaluates the buffer (and thus calls 'read'). I just didn't do it yet because this is re= ally the most puny of issues right now, IMO. Stefan is also thinking that l-w-c= -c needs to be updated regarding the lexical-binding local variable, too. And doing that will also enable shorthands to be configured in other parts of the buffer, not just the end section. Jo=C3=A3o On Sat, Oct 2, 2021 at 3:19 PM Eli Zaretskii wrote: > > > Date: Sat, 2 Oct 2021 13:57:21 +0000 > > Cc: joaotavora@gmail.com, 50946@debbugs.gnu.org > > From: Alan Mackenzie > > > > > If you want me to take your critique seriously, please be specific: > > > what are the aspects of that function that you think lack attention t= o > > > detail, and what detail? > > > > The five aspects I enumerated on my original bug report. Not checking > > for a properly formatted Local Variables: section > > That is not part of the function in question, is it? It's in > hack-local-variables--find-variables, which we use everywhere. > > > not checking for lower-case in that variable being searched for > > That's also in hack-local-variables--find-variables, right? > > > not going back at least 3000 characters > > That is now fixed, right? > > > Additionally, the original code didn't check for a page boundary. > > No longer relevant, right? > > > What worries me is that this lack of attention to detail might extend t= o > > the new code in lread.c, or the documentation page. > > You are welcome to point out specific issues with that. > > > I still think somebody who isn't Jo=C3=A3o and isn't me should check > > this. > > I did that when reviewing the commit. > > > I worry, to a lesser degree, it is not entirely clear whether setting > > the elisp-shorthands variable in the first line of a short file should > > be valid or not. I don't think the current hack-elisp-shorthands is > > careful enough about this. > > Why does it matter? > > > > And while at that, please try to distinguish between general problems > > > of hack-local-variables--find-variables, which affect all of Emacs, > > > and hack-elisp-shorthands, which is specific to this feature. > > > > I think all the things I've said in this bug report are about > > hack-elisp-shorthands and the other new code/doc in this feature. > > See above: I don't think I agree. > > > > So the invitation to calm down goes both ways here. Please focus on > > > technical issues and leave ad-hominem out of this, okay? > > > > Is this bug to be fixed completely, or are the edge cases just to be > > ignored as unimportant? That is the current technical issue as I see > > it. I really don't want to fix the bug myself, but am prepared to do s= o > > if nobody else is. If you think the bug indeed needs completely fixing= , > > please reopen it - there's no point in me trying to reopen it again. I= f > > you don't, just leave things the way they are. > > Please forget what happened before, and let's pick up from the above > points I mention. What else needs to be fixed in shorthands.el, and > why? --=20 Jo=C3=A3o T=C3=A1vora