From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#61943: 29.0.60; icomplete--in-region-setup should activate icomplete-fido-mode-map too Date: Sat, 4 Mar 2023 11:30:48 +0000 Message-ID: References: <87o7p9u29j.fsf@melete.silentflame.com> <87h6v1s0p4.fsf@melete.silentflame.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23284"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 61943@debbugs.gnu.org, juri@linkov.net To: Sean Whitton , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 04 12:30:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pYQ5i-0005uA-BJ for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 04 Mar 2023 12:30:18 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pYQ5W-0004IN-KC; Sat, 04 Mar 2023 06:30:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pYQ5T-0004Hs-Ty for bug-gnu-emacs@gnu.org; Sat, 04 Mar 2023 06:30:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pYQ5T-00058T-JY for bug-gnu-emacs@gnu.org; Sat, 04 Mar 2023 06:30:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pYQ5T-0000Tz-5O for bug-gnu-emacs@gnu.org; Sat, 04 Mar 2023 06:30:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Mar 2023 11:30:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61943 X-GNU-PR-Package: emacs Original-Received: via spool by 61943-submit@debbugs.gnu.org id=B61943.16779293501752 (code B ref 61943); Sat, 04 Mar 2023 11:30:03 +0000 Original-Received: (at 61943) by debbugs.gnu.org; 4 Mar 2023 11:29:10 +0000 Original-Received: from localhost ([127.0.0.1]:35319 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYQ4b-0000SB-TQ for submit@debbugs.gnu.org; Sat, 04 Mar 2023 06:29:10 -0500 Original-Received: from mail-oi1-f176.google.com ([209.85.167.176]:43731) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYQ4a-0000Rw-CF for 61943@debbugs.gnu.org; Sat, 04 Mar 2023 06:29:08 -0500 Original-Received: by mail-oi1-f176.google.com with SMTP id bk32so3692110oib.10 for <61943@debbugs.gnu.org>; Sat, 04 Mar 2023 03:29:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1677929343; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=XMRZoXUjWBmIBHq44MSkXzMOBiqLbamI1WuyyrPvrrU=; b=b3t8RgvD6tmJT0dl4krXPU96pQQLc+EaWoXQCqIOE4TqgEfGEPGSylYow8JZgAkTW3 g6IIEJMd5Y40Wdr0EMlgglfL6RZYecKrwZ3kHvDcYCaArlx3EAp2fjFjWIR7U5E4jQQJ xSLCc+0fIsGltK/osIDITtCxFN8EXzPos0s8P1HMJjk6kc0GmqxbEC1GAwpqQg0liWVF KNK06/6ds31CqFIdmpKNc8yqtCayx1bweCoIy0kUNEQQ/GPSH6so9Cg4EtKgIMLM2POw DAcHYcgHnvaoOm3gTA/P1uf39zzbK5w5j+8OA8hQ6UWbjg3IhTPr9pXJLF61UvF5H0pe PbhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677929343; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XMRZoXUjWBmIBHq44MSkXzMOBiqLbamI1WuyyrPvrrU=; b=640MveCGmm305s8mW9ctUHLA8y2SHKzJpTrBMGvkwPea8QWFIvmKZRHFS0dD8vQKC6 bUALxuWEYa2ThWiD+fv6DukRRHdy0ivwm45VPaXolqDEGUktuaN8F/t1DX2UoIl35U6x OvpEQBIcYl+Mk/8+9SyDnnbvZc5sJZGm/I98Y6AgLERh+7fmlj4zwQAMv5VTRl7nf9Gf xYNAlTfk9TlajPzfC54uC6aKSCMLNHVgLsmg5nOSBKYFoq9H7ta3UgD/h8ahtECfktfn 3VXFVGpWSRaGiJmmIJH+a39GH8oCr8JGqBHgGY9Qofr8rVOX4daApfkHB0ePJ9nMH7II k8lA== X-Gm-Message-State: AO0yUKXIGYbOmPC102uVzsN2g/zLTqbkCPVffFkbEYerTZZ+ZhFQIfVh Tot7slXwkpxRCEvE4IUsxi8HST1jDshLiE0E0hg= X-Google-Smtp-Source: AK7set/36x4f5lBnbFuGEfrsd6ki0a9Vfl4GxVK3Irq6WcUCWgGrHwFyVUIFu54zc7L9YWOwrVvXkwn9ZlL8zvq4mgY= X-Received: by 2002:aca:1c09:0:b0:384:2019:c201 with SMTP id c9-20020aca1c09000000b003842019c201mr1523637oic.8.1677929342682; Sat, 04 Mar 2023 03:29:02 -0800 (PST) In-Reply-To: <87h6v1s0p4.fsf@melete.silentflame.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:257270 Archived-At: On Sat, Mar 4, 2023 at 2:35=E2=80=AFAM Sean Whitton wrote: > > Hello, > > On Fri 03 Mar 2023 at 11:18AM -07, Sean Whitton wrote: > > > X-debbugs-cc: juri@linkov.net, joaotavora@gmail.com > > > > Many thanks to Juri and Joao for fixing #45763! It's a whole new world= ! > > > > I am a fido-mode user. I noticed that my custom bindings for the > > fido-mode minibuffer don't work for in-buffer completion. I think that > > icomplete--in-region-setup should compose in icomplete-fido-mode-map, i= n > > addition to icomplete-minibuffer-map, in the case that fido-mode is on? > > I noticed that icomplete-hide-common-prefix etc. are wrong too. > I think that icomplete--in-region-setup also needs to do something > equivalent to the setq-local in icomplete--fido-mode-setup. Yes, Sean, please report an Emacs -Q recipe for what you are trying to get working. I've now found a way to test this, and I was surprised at how easy it was, but also skeptical. As I remember analyzing it more than a year ago, and finding this a reasonbaly hard job. Also it seems to be completely broken for fido-vertical mode and icomplete-vertical-mode, so I think an approach that takes these cousin modes into consideration. All in all, I'm not sure we should be shipping this half-baked enhancement for emacs-29, at least not in this phase. I propose we revert it in emacs-29. I propose we revert it from there, keep the changes in master, and focus on making it more consistent there.