From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#64428: [PATCH] Fix flymake mode line scrolling with pixel-scroll-precision-mode Date: Fri, 7 Jul 2023 12:37:44 +0100 Message-ID: References: <87zg4eq8xn.fsf@catern.com> <83ilaxij8c.fsf@gnu.org> <833521i1ag.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25675"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Spencer Baugh , 64428@debbugs.gnu.org, sbaugh@catern.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 07 13:46:32 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qHjux-0006Sn-DC for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 07 Jul 2023 13:46:31 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qHjnl-0006LD-KM; Fri, 07 Jul 2023 07:39:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qHjnj-00060G-IE for bug-gnu-emacs@gnu.org; Fri, 07 Jul 2023 07:39:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qHjnj-00015z-1l for bug-gnu-emacs@gnu.org; Fri, 07 Jul 2023 07:39:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qHjni-0001dY-IW for bug-gnu-emacs@gnu.org; Fri, 07 Jul 2023 07:39:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 07 Jul 2023 11:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64428 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64428-submit@debbugs.gnu.org id=B64428.16887298986238 (code B ref 64428); Fri, 07 Jul 2023 11:39:02 +0000 Original-Received: (at 64428) by debbugs.gnu.org; 7 Jul 2023 11:38:18 +0000 Original-Received: from localhost ([127.0.0.1]:42684 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qHjmy-0001cX-B6 for submit@debbugs.gnu.org; Fri, 07 Jul 2023 07:38:18 -0400 Original-Received: from mail-oo1-f54.google.com ([209.85.161.54]:47593) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qHjmj-0001bq-IL for 64428@debbugs.gnu.org; Fri, 07 Jul 2023 07:38:15 -0400 Original-Received: by mail-oo1-f54.google.com with SMTP id 006d021491bc7-558a79941c6so1247739eaf.3 for <64428@debbugs.gnu.org>; Fri, 07 Jul 2023 04:38:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688729876; x=1691321876; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=VucNqITgwjW5avN4duLBawwGl8RFhb6aHTL6ufkhB18=; b=X9rehElB9UySeZP3sh0Hot5SuejnYJZXw654W5I2tb+aM8FJ6ISYJBpdldYx2dI4kw H7Y9M5L8ms2nu3k7vNTHCML37MyumVC/Hg3BdtJ673SC4LrsiWU68DoykSvyIA5amgOB 4tSEGteMNRBqzjujcZHZ5yPSvexmqguDurckt4qZ455K7ESMVzGpfDoANDhrbXhqgna8 786dE4hTrDrRm4c7wi5gX7T5JnCTw9CtoCx39bWwESrpFSxMplGKhFDtNWUUW9OzYR9o /wg49CxMVy7/IGp86Vt+YXMl+8KVBeaIkOlvT1yu4aNg0zCuU8Of9ntfU+6yR+pgRrZw Swng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688729876; x=1691321876; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VucNqITgwjW5avN4duLBawwGl8RFhb6aHTL6ufkhB18=; b=NhaALcsACgc0HxZoJMXCpj4TIdCN8uPdUzM3vjiE6BdDSPd9jIkqn5ZZAJtTGByfW4 IncRxDHg4VbWHjK6GngmmoA2MmzzQOIXMm+6rD9Lpt5v54Bn9YtfmhrVVfu9A08O9sGk 2tGNVVIm3cBRG7iU/6bZatsdL4QnusUTvi5e66/QIhmzMdbcEWH1GfgQx+a9AUOrBj85 P5Sz2vc+BFATvkSTBwIbedtZaQFzCqRoSCiOX9f4D1T7Pji8IvewqettgyWx+mZ1GJ9x /cqL6MrtIS5SUlG7UrQW5DdPOI9PRWb10OpxtWh+8wLhEH/bKmCZ12FxFi1Xw71PudfF fETg== X-Gm-Message-State: ABy/qLYzp8zJbyhfEqWdCgG22N+765540OBpoTbbGftzprGIf88/HpCH ++AJialg7n7Y7svSSHo4GYl5TB47K09gFen5wAs= X-Google-Smtp-Source: APBJJlHDmW29duEJ8QlodnxlQYwTLpm/gVvLKAVSf3wanetS2eyxYg5iJIhwOCFuF846v4wMaCt2vl6wg4UMlycsemo= X-Received: by 2002:a4a:334e:0:b0:560:befd:6d6a with SMTP id q75-20020a4a334e000000b00560befd6d6amr3341234ooq.7.1688729875749; Fri, 07 Jul 2023 04:37:55 -0700 (PDT) In-Reply-To: <833521i1ag.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264717 Archived-At: On Thu, Jul 6, 2023 at 3:04=E2=80=AFPM Eli Zaretskii wrote: > > > From: Spencer Baugh > > Cc: sbaugh@catern.com, 64428@debbugs.gnu.org > > Date: Thu, 06 Jul 2023 09:16:41 -0400 > > > > Eli Zaretskii writes: > > > > >> * lisp/progmodes/flymake.el:(flymake--mode-line-counter-scroll-prev, > > >> flymake--mode-line-counter-scroll-next, > > >> flymake--mode-line-counter-map): Add. > > >> (flymake--mode-line-counter): Use new keymap and include 'type as a > > >> property in the mode-line. > > > > > > Thanks. Any reason you couldn't simply add more events to the > > > existing code? > > > > Two reasons: > > > > 1. I initially did that but it made the code uglier. Also, this code i= s > > run every time the mode-line is updated, and adding more of that seems > > bad. > > > > 2. This makes describe-key work better and makes it possible for users > > to configure the scroll direction or add more bindings for different > > things. > > This means your changeset is actually two different loosely-related > changes. The one that refactors the original code needs approval from > Jo=C3=A3o (CC'ed). Once Jo=C3=A3o is happy with that refactoring, I'm ok= ay with > adding the extra events to it. Hi Eli, Spencer, I've reviewed the code. I understand Spencer's rationale for the small refactoring and I'm OK with it. However I didn't test. I'd say it's better for this new capability to go to master, though with some minimal testing (say, at least in tty as well as graphical mode) it shouldn't be really dangerous for emacs-29 either. Jo=C3=A3o