From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#61350: Eglot over Tramp freezes with large project Date: Tue, 7 Mar 2023 13:33:48 +0000 Message-ID: References: <87y1ootw2t.fsf@gmail.com> <87a613f0b7.fsf@gmx.de> <87r0udvmzr.fsf@gmx.de> <878rglxrzm.fsf@gmail.com> <87cz5wmjbx.fsf@gmx.de> <87h6v8f7u9.fsf@gmail.com> <87o7pflfcd.fsf@gmx.de> <87wn43e9ht.fsf@gmail.com> <874jr6oont.fsf@gmx.de> <87sfeqd4zi.fsf@gmail.com> <877cw1swjm.fsf@gmx.de> <87k0016dgo.fsf@gmx.de> <1458446553.50372.1677606917251@office.mailbox.org> <87ilfkh89k.fsf@gmail.com> <87y1ofct83.fsf@gmx.de> <87356n8kja.fsf@gmail.com> <877cvvfnp6.fsf@gmx.de> <54377687.213790.1678016749459@office.mailbox.org> <87356jfktc.fsf@gmx.de> <87a60ovi90.fsf@gmx.de> <31964054.380679.1678194256931@office.mailbox.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18560"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Michael Albinus , 61350@debbugs.gnu.org To: Thomas Koch Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Mar 07 14:35:25 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pZXTQ-0004aI-26 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 07 Mar 2023 14:35:24 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pZXT5-0007t4-Ic; Tue, 07 Mar 2023 08:35:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZXT4-0007so-AK for bug-gnu-emacs@gnu.org; Tue, 07 Mar 2023 08:35:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pZXT4-0004sz-1l for bug-gnu-emacs@gnu.org; Tue, 07 Mar 2023 08:35:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pZXT3-0003Xk-Ka for bug-gnu-emacs@gnu.org; Tue, 07 Mar 2023 08:35:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 Mar 2023 13:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61350 X-GNU-PR-Package: emacs Original-Received: via spool by 61350-submit@debbugs.gnu.org id=B61350.167819604813557 (code B ref 61350); Tue, 07 Mar 2023 13:35:01 +0000 Original-Received: (at 61350) by debbugs.gnu.org; 7 Mar 2023 13:34:08 +0000 Original-Received: from localhost ([127.0.0.1]:44823 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZXSB-0003Wb-SZ for submit@debbugs.gnu.org; Tue, 07 Mar 2023 08:34:08 -0500 Original-Received: from mail-ot1-f46.google.com ([209.85.210.46]:43901) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZXSA-0003W5-M6 for 61350@debbugs.gnu.org; Tue, 07 Mar 2023 08:34:07 -0500 Original-Received: by mail-ot1-f46.google.com with SMTP id 32-20020a9d0323000000b0069426a71d79so7118532otv.10 for <61350@debbugs.gnu.org>; Tue, 07 Mar 2023 05:34:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678196040; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Cj1JQ0EUiwpSR1KfvOA1b038aSu1i9jx9rYfOY97Go0=; b=JLz/zCaD/aA3MyN62mWQIbwRdolMA5mdUOd9j0h3wnV5oeXj07XbjIcybOjZoe0gUd 4Q0ssUeYl651z0Z8Qdl2X/BSZoky9nyYrF+5uPeeqaE0Dbkg3a0Fho5/QpXnL34wvoRQ iO5oWjrxqd5k2EyIrJt9sA7AfFHEMVzJlhGsZBHw7Fzr9OWwznJv1sxY7H3NGIU0DIoG pjCuI7w3L9u9F35NJD01Xn6y+fj3hc+UTsJjCYMsKL2nv5MpIaXSp5k0oNso60NuwC4z tT+pv7f+gVj2fi5bzch+q8XJ+ZjJ5wLQxfH5kycWydxBBh/seLos4RQyzaCAA4GsqvPx oudQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678196040; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Cj1JQ0EUiwpSR1KfvOA1b038aSu1i9jx9rYfOY97Go0=; b=FA7iAOTTsmiVekdI9RFtgdqB/fsRGYz9M7+ZuTaTp0RQe5yQZc3cSAPVi/JIVDgqR7 u9we+ZQgKeOuaBASD+6fuySPmo8nY1gnh0b0IesZ1nqDRpNWcO1nEh6kVkhjrwPZ1K9N 9EhXTk9ZU6yUaL/RO3ed/oDUIXZOjjPOBpkLwEx4sk3joBIQGvZunjLfUAc3+60qZdBe xBMI6fDNEXZVpzoWd8CZXyhozQGG+kH8HAiZIIJNJ7ndmaFM4QsOAM7gs3KfeonzHPgx +1fqbveKKCHCZq1nQOA6Xlt8OPkRVjM4Bm6nHtCI5S4KbrspjBfv3BvglHV+H8zwQi2z ammA== X-Gm-Message-State: AO0yUKUvyTdya9HhMLOce2c7hfgq5pSG4TfTVHcCxIai+r6Lit6z1Y+g DHGuzmVySEXbSBO+OREAZkiaBE6sov5Y4D6WRsI= X-Google-Smtp-Source: AK7set+tbLqk9EPUCcEqxrII6ADAaGdxD17Qwe5QvYoS/AaOIiJVL/0vWI9+R6IQb9zfJwm0iPrncjgv3yRi48sPzsA= X-Received: by 2002:a9d:7194:0:b0:68b:d3f1:aa1b with SMTP id o20-20020a9d7194000000b0068bd3f1aa1bmr4715176otj.3.1678196040392; Tue, 07 Mar 2023 05:34:00 -0800 (PST) In-Reply-To: <31964054.380679.1678194256931@office.mailbox.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:257453 Archived-At: On Tue, Mar 7, 2023 at 1:04=E2=80=AFPM Thomas Koch wrote: > > Thanks Michael! What is the advantage of this patch over just removing th= e JUST-THIS-ONE argument? > In both cases tramp is triggering accept-process-output for processes it = does not own. Yes, I also ask myself that question. Though here, Tramp has "shared" ownership of them, sort of, so it's more conservative when compared to the current mechanics. Michael, your patch goes in the right direction but AFAIR a single accept-process-output is not guaranteed to bring into the process filter all the buffered data. In "40.9.4 Accepting Output from Processes": [In accept-process-output, ] If PROCESS is non-=E2=80=98nil=E2=80=99 then this function does not return until som= e output has [^^^^^^^^^^^^^^^^^] been received from PROCESS or PROCESS has closed the connection. Note "some", not "all". So while less common, I think the hang can still happen. So maybe you meant: (while (accept-process-output p 0 nil t)) as suggested in that section? Jo=C3=A3o