From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#67870: 29.1; Eglot missing or un-findable advertised feature Date: Mon, 18 Dec 2023 17:00:27 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24570"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 67870@debbugs.gnu.org To: Dave Abrahams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 18 18:02:14 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rFH0O-00066t-No for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 18 Dec 2023 18:02:12 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rFGzF-0005iN-Gg; Mon, 18 Dec 2023 12:01:01 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rFGzE-0005i5-EZ for bug-gnu-emacs@gnu.org; Mon, 18 Dec 2023 12:01:00 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rFGzE-0005aI-5q for bug-gnu-emacs@gnu.org; Mon, 18 Dec 2023 12:01:00 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rFGzF-0004ni-Qz for bug-gnu-emacs@gnu.org; Mon, 18 Dec 2023 12:01:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Dec 2023 17:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67870 X-GNU-PR-Package: emacs Original-Received: via spool by 67870-submit@debbugs.gnu.org id=B67870.170291885017240 (code B ref 67870); Mon, 18 Dec 2023 17:01:01 +0000 Original-Received: (at 67870) by debbugs.gnu.org; 18 Dec 2023 17:00:50 +0000 Original-Received: from localhost ([127.0.0.1]:33424 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rFGz3-0004TQ-ME for submit@debbugs.gnu.org; Mon, 18 Dec 2023 12:00:50 -0500 Original-Received: from mail-lj1-x22a.google.com ([2a00:1450:4864:20::22a]:47262) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rFGz1-0004Da-2Y for 67870@debbugs.gnu.org; Mon, 18 Dec 2023 12:00:47 -0500 Original-Received: by mail-lj1-x22a.google.com with SMTP id 38308e7fff4ca-2cc3647bf06so36018281fa.2 for <67870@debbugs.gnu.org>; Mon, 18 Dec 2023 09:00:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702918839; x=1703523639; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=vadV8t+EZF8hBh3JTNZMPz7Yb4M+m7EtQ7lKTiTtYVU=; b=R5/xWR8y8+f0tQycrYM+JMIx5WPHBCcX8KU3z7/QjOi3RInVvYm6p8WMt9jfLTcyYg cU3GPJp+VJOUXfBY34p5CWMJOwWTEr805MP2saVboFX7n0vVpFLf0nKfTmh+M/Erfcc8 de2/DR9TuMW/UvT13GpyWLGbrXkKK1DBwwrIzj/NBppeELuGXNoaN6qs1Q/GSThGRaLX GQuhnKO3TgMkVpo2tfbAFyNyH8JftwvQiiO5bc8qZ+sUs8rGpqloA96sjPq0QIvdgV2l Lp6ohbFZI2JMcpEd1JAxD36WnpQ8MbMrY+ezG/Srh7gekW3vsU0pfvskkcwH0qI+Yfbt Qapg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702918839; x=1703523639; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vadV8t+EZF8hBh3JTNZMPz7Yb4M+m7EtQ7lKTiTtYVU=; b=Wg744ps4VqJ1ciEp1I9A1wTFLDMTGZvP/gdtAbpmBTSVzQisn5wZzTPJWpHQBRtTKs F8IHRWQBdoFiwP2xdLGYoDN/WHsFhe0dyC+Rcls+qosiR+Ss/VtoftplqPgp/EkcPgqK zWl3zx1B9wE9N775w5f57Nyha6PhKM+5KAGxbipBjX7IwNkbAZvFwqpgy5eyrMOG20Fe C9VnbIIgFvMHFJKMLvo3OHiGDT2tzxJp8QV/2G6xnRigDFHh4Mmp62aGp74tCg610Ank lYtkEuMmxmcY3bQgKfXqUCTY8Gp5C6mukpSD3+uQNKAU6lrtf1p7qyujygnstpOpguJh iWKQ== X-Gm-Message-State: AOJu0Yzxt78Rn5C4n4d4Lw3S0P3pQ7nuNIvmWay9vn463Y+DZILCXMJc Vyn422wg6JYWfrUOJ17zBjVxuWXpuh5yh9eBj5U= X-Google-Smtp-Source: AGHT+IEzC9sXq3hO2+B4RJ17VLGPxI/2cdnzMa+6nwMTWOJVFnXLG0LAsUXy/UeYi+zx9TLcYA5NeWiXcSZb5m2P0AM= X-Received: by 2002:a2e:8610:0:b0:2cc:5fda:5bd7 with SMTP id a16-20020a2e8610000000b002cc5fda5bd7mr1147800lji.99.1702918838651; Mon, 18 Dec 2023 09:00:38 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:276466 Archived-At: On Sun, Dec 17, 2023 at 7:40=E2=80=AFPM Dave Abrahams w= rote: > The info page for Eglot says: > > 3.1 Eglot features: > > =E2=80=A2 On-the-fly diagnostic annotations with server-suggested fixe= s, via > the Flymake package (*note (flymake)Top::). > > But I can find no evidence of the support for server-suggested fixes > either in flymake or in eglot itself. I am working with an LSP server > that offers fix-its but can't find any way to apply them. Isn't very hard to find in "3.3 Eglot commands" IMO =E2=80=98M-x eglot-code-actions=E2=80=99 =E2=80=98M-x eglot-code-action-organize-imports=E2=80=99 =E2=80=98M-x eglot-code-action-quickfix=E2=80=99 =E2=80=98M-x eglot-code-action-extract=E2=80=99 =E2=80=98M-x eglot-code-action-inline=E2=80=99 =E2=80=98M-x eglot-code-action-rewrite=E2=80=99 These commands allow you to invoke the so-called =E2=80=9Ccode actions= =E2=80=9D: requests for the language server to provide editing commands for correcting, refactoring or beautifying your code. These commands may affect more than one visited file belonging to the project. The command =E2=80=98eglot-code-actions=E2=80=99 asks the server if th= ere [are] any code actions for any point in the buffer or contained in the active region. If there are, you have the choice to execute one of them via the minibuffer. A common use of code actions is fixing the Flymake error diagnostics issued by Eglot (*note (flymake)Top::). Clicking on a diagnostic with =E2=80=98mouse-2=E2=80=99 invokes =E2=80=98eglot-code-= actions-at-mouse=E2=80=99 which pops up a menu of available code actions. The variable =E2=80=98eglot-diagnostics-map=E2=80=99 can be used to control the mou= se binding. Other commands execute a specific code action. For example, =E2=80=98eglot-code-action-organize-imports=E2=80=99 rearranges the pr= ogram's =E2=80=9Cimports=E2=80=9D--declarations of modules whose capabilities = the program uses. > Either what's meant by this should be clarified, leading to discoverable > instructions for exploiting the feature, or the text should be removed. That's just a summarized list of the main features, a detailed description doesn't of how to use the feature doesn't belong there. But patches welcom= e for a link down to 3.3 (and fixing the typo while you're at it). Jo=C3=A3o