From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#52342: [PATCH] Add Texinfo support for Flymake Date: Tue, 7 Dec 2021 23:46:08 +0000 Message-ID: References: <3948b4c7-bd61-e2f8-6b02-6057631139cb@protonmail.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000db6ec605d296fa71" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4848"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Kangas , 52342@debbugs.gnu.org To: Okamsn , Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Dec 08 00:47:26 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mukBB-00010A-41 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 08 Dec 2021 00:47:25 +0100 Original-Received: from localhost ([::1]:58804 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mukB9-0002aP-S6 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 07 Dec 2021 18:47:23 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:54462) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mukAo-0002a5-FS for bug-gnu-emacs@gnu.org; Tue, 07 Dec 2021 18:47:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55683) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mukAo-0000F1-7e for bug-gnu-emacs@gnu.org; Tue, 07 Dec 2021 18:47:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mukAn-0005mK-VK for bug-gnu-emacs@gnu.org; Tue, 07 Dec 2021 18:47:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 Dec 2021 23:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52342 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 52342-submit@debbugs.gnu.org id=B52342.163892078722150 (code B ref 52342); Tue, 07 Dec 2021 23:47:01 +0000 Original-Received: (at 52342) by debbugs.gnu.org; 7 Dec 2021 23:46:27 +0000 Original-Received: from localhost ([127.0.0.1]:38993 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mukAE-0005lB-S8 for submit@debbugs.gnu.org; Tue, 07 Dec 2021 18:46:27 -0500 Original-Received: from mail-qk1-f181.google.com ([209.85.222.181]:43605) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mukAC-0005kv-Hz for 52342@debbugs.gnu.org; Tue, 07 Dec 2021 18:46:25 -0500 Original-Received: by mail-qk1-f181.google.com with SMTP id 193so472895qkh.10 for <52342@debbugs.gnu.org>; Tue, 07 Dec 2021 15:46:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DtZqnCDvB+eJG6/UV0t4m5OnyZqfJJoAf/uXI1wo65o=; b=QSfFt2cUhoQL5eacJ1eaTUKzEQs6AOVo5hp1EIDETfbPa8KmePY/zOeZCkExPV+q0P Qu0eMh1XDn0C6G9yVr01VsvQRpgq2ThUSDR8vWyxNIA5Sm++OdVI0MaWFHI7LFBM0A2P hXVG9D0WgeTmbPax3vqQywTOhAk89eoLwLjXolLc5Qcsu3jScniFQ+iXOe2QkoKksBfK sKKURGja8PIh15YNhFulJl5S2jBEX9/oeCce84GJTe1+3hTM5+DXZ7s+sBSB+5T91KP1 /3dgamixZ30biKJeY+p4BL9M/gYz5iWA5Nv8DLtuochoE6rlc5A7zDnhphV6HVvYYrAk K0tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DtZqnCDvB+eJG6/UV0t4m5OnyZqfJJoAf/uXI1wo65o=; b=Ei2HtQQ/YIM3aVMx7mO5mHkyLJ9oYuYQop6XGqdnUpl8BG6oC4pf90+VQ02pvEVbFC LObjI6dIMWohnr0BAaqOUucEyjE39Um32vbJviEzwVj8xkT3Md7UnqwWHytReAL48blX 8CGx3RcC3Il6PqdFjMjK1zo8m/ObfRNBzagnvOpBDYCtx+LJOYgTOW6TbYwpuYL6xo9c UJAMzLlMyUQraj+0XvL6DFXSOkJ8hNI0K+gA4ku6lgZeCxTkhyruq4IKs0RtERXP1vS8 G98/7g1vUfV154d5C2y7R2f3fywjmOZ1FvegzYsUV610UA5TT9d2TFAQPjtiMOYOq6BD Dm3w== X-Gm-Message-State: AOAM533JeuX8sG61TEP/U3Jw4mwydbClDkVNlPUbd+XXb4T2//XNqNr+ Y5u4X+8GoqI3BuRymAGC6ZJTCgojVJC2vENROcUPRm9p5hk= X-Google-Smtp-Source: ABdhPJwVbrJdt73jqBcYRQmHN7K5KtM2QVPBfOZbM4vjWBiiZREsonp/mhwCisVCxU1PHXWJ3ncFzy6cSEGCopF/WGc= X-Received: by 2002:a05:620a:1a92:: with SMTP id bl18mr2860905qkb.488.1638920779164; Tue, 07 Dec 2021 15:46:19 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:221890 Archived-At: --000000000000db6ec605d296fa71 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Dec 7, 2021 at 11:43 PM Jo=C3=A3o T=C3=A1vora wrote: > > On Tue, Dec 7, 2021 at 11:39 PM Okamsn wrote: > >> On 12/7/21 09:23, Jo=C3=A3o T=C3=A1vora wrote: >> > Not sure about the eval-when-compile for require. It was my >> > expression that require is always "when compile". >> > >> > I've unfortunately been a little away from Emacs lately. >> > >> > Jo=C3=A3o >> >> My understanding is that `eval-when-compile` is used to make sure that >> macro definitions are available during compilation and that the >> libraries are not loaded when `texinfo.el` is loaded. The macros in the >> patch are `rx`, `cl-loop`, and `flymake-log`. >> > > require is always `eval-and-compile` (sorry if I misled you earlier). > It's OK to use `eval-when-compile` when needing `cl-loop` from `cl-lib` > if _all_ you need form `cl-lib` is indeed macros. > > But for flymake, you need the actual runtime things too, right? So > I think plain require is better and simpler > Hmmm, on second thought, it you're planning on relying on autoloads for ultimate loading lazyness.... Hmm, maybe you're right... Jo=C3=A3o --000000000000db6ec605d296fa71 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Tue, Dec 7, 2021 at 11:43 PM Jo=C3=A3o T=C3=A1vora <joaotavora@gmail.com> wrote:
=

On Tue, Dec 7,= 2021 at 11:39 PM Okamsn <okamsn@protonmail.com> wrote:
On 12/7/21 09:23, Jo=C3=A3o T=C3=A1vora w= rote:
> Not sure about the eval-when-compile for require.=C2=A0 It was my
> expression that require is always "when compile".
>
> I've unfortunately been a little away from Emacs lately.
>
> Jo=C3=A3o

My understanding is that `eval-when-compile` is used to make sure that
macro definitions are available during compilation and that the
libraries are not loaded when `texinfo.el` is loaded.=C2=A0 The macros in t= he
patch are `rx`, `cl-loop`, and `flymake-log`.

require is always `eval-and-compile` (sorry if I misled you earlier)= .
It's OK to use `eval-when-compile` when needing `cl-loop` f= rom `cl-lib`
if _all_ you need form `cl-lib` is indeed macros.

But for flymake, you need the actual runtime things = too, right? So
I think plain require is better and simpler

Hmmm, on second thou= ght, it you're planning on relying on
autoloads for ultimate= loading lazyness.... Hmm, maybe
you're right...

Jo=C3=A3o
--000000000000db6ec605d296fa71--