From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#33992: 27.0.50; xref-find-definitions wastes too much space Date: Wed, 20 Mar 2019 23:23:43 +0000 Message-ID: References: <87muoe7jrs.fsf@mail.linkov.net> <87a7hp43a5.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000475bf005848eea30" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="235727"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 33992@debbugs.gnu.org, Dmitry Gutov To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Mar 21 00:25:15 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h6kaA-000zCb-J5 for geb-bug-gnu-emacs@m.gmane.org; Thu, 21 Mar 2019 00:25:14 +0100 Original-Received: from localhost ([127.0.0.1]:56502 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h6ka9-0002gY-Au for geb-bug-gnu-emacs@m.gmane.org; Wed, 20 Mar 2019 19:25:13 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45559) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h6ka0-0002gB-Lw for bug-gnu-emacs@gnu.org; Wed, 20 Mar 2019 19:25:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h6kZz-0007GE-B0 for bug-gnu-emacs@gnu.org; Wed, 20 Mar 2019 19:25:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38934) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h6kZy-0007Ex-9I for bug-gnu-emacs@gnu.org; Wed, 20 Mar 2019 19:25:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h6kZy-0006Bn-16 for bug-gnu-emacs@gnu.org; Wed, 20 Mar 2019 19:25:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 20 Mar 2019 23:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 33992-submit@debbugs.gnu.org id=B33992.155312424223695 (code B ref 33992); Wed, 20 Mar 2019 23:25:01 +0000 Original-Received: (at 33992) by debbugs.gnu.org; 20 Mar 2019 23:24:02 +0000 Original-Received: from localhost ([127.0.0.1]:52478 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h6kYz-0006A0-On for submit@debbugs.gnu.org; Wed, 20 Mar 2019 19:24:02 -0400 Original-Received: from mail-qt1-f170.google.com ([209.85.160.170]:46388) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h6kYx-00069l-RI for 33992@debbugs.gnu.org; Wed, 20 Mar 2019 19:24:00 -0400 Original-Received: by mail-qt1-f170.google.com with SMTP id z17so3647380qts.13 for <33992@debbugs.gnu.org>; Wed, 20 Mar 2019 16:23:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8glv0c4iMZiuBLEWOnx4RdybsoRKs/KAs83TRP18Zc8=; b=D6wbmLpVQ8KaPy/XXBm5/yTEJl7eIhJDGbKZIkww7I8MQJLzUysLfpkdWMHw2TUQ66 A56UIKA57UicbC1d/lzo2IqdnSwTJXnPqjMox41UIS6oVat603mWUD4VsIgNNPjaOz00 IV27rTHnOuckeeqxG2/mYkre0RjDtYxBr1IKgkN7mlU3hdumIW/CLPn/3wwzDpsUwuFd 0BfFlJZgFvJx3ug5A/bTfXX/MbtdQhe1ySp2BXAX23aVhYBBlST4WlV1bDka7SPlNuQ8 bdcg8OHuTpmdq0N+0tVsRHr7B3qCm/EdLh5Xq2dpVriSK2DP7Je+A23f/XAZOlbDiNS8 IH1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8glv0c4iMZiuBLEWOnx4RdybsoRKs/KAs83TRP18Zc8=; b=BIcishlqphxZ4zuFfJmJhy1LUMAUAQuQpR/hzMFs1WERplLyyQ1V0gqN1HMHB1hgEu Kqsu09gtcyrrOsj8MZ02A8CNAG1Jk8DJVIvG6E/BMt0H1IRdgwJSnvqRMH7kS4bW4soi cIl9ijHcjgZNMP9wLiDQfoJbPev/Vt4whBCuzG5t4P4YrlsL3unBADPZlWNsLYwaP6YA 1nAjrcmJrIDP709wduFYwvp1EniD2zXb97UlVeUue/erzY9BgMFNBFUFkHFFu/wGFn3k a+Y5VYKC3cErdV7FYXlf9y/z5rNC/6n0tUuRnC+5BdiB5QHRpskcpXZoxOp0+sal2ZOV TeNw== X-Gm-Message-State: APjAAAXUtacCf1SKpKkm1yGIGgMPrFPNPy3hWK8jAO2SKrsVUJ0Z4EUg AKbeGOMaOOpeMjDvkN/sUouyvKysQwXw48pLgyQ= X-Google-Smtp-Source: APXvYqz6V04AV88MsPquF6yoI8FRo0Zzpb7rBRKmr/2aRaUJRVOt5RboeLcD2LrAi7chOXms/f2fpwA8okDIHjyFHDM= X-Received: by 2002:a0c:a423:: with SMTP id w32mr586257qvw.104.1553124234319; Wed, 20 Mar 2019 16:23:54 -0700 (PDT) In-Reply-To: <87a7hp43a5.fsf@mail.linkov.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:156555 Archived-At: --000000000000475bf005848eea30 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Mar 20, 2019 at 10:35 PM Juri Linkov wrote: > >> As noted in bug#33870 the buffer produced by xref-find-definitions > >> (bound to =E2=80=98M-.=E2=80=99) has a transient nature like the *Comp= letions* buffer. > >> Therefore it makes sense not to waste its space needlessly: > > > > It doesn't make sense to review this patch until the patch that fixes > 33870 > > has been produced. > > Since the patch from bug#33870 has been already committed, > this bug#33992 is undeadlocked now. > > The problem with xref-find-definitions is its unexpected outcome: > sometimes it pops up a window, sometimes doesn't. > > It's like Russian roulette: pull the trigger, bang and there is > a hole in the screen that takes the form of glaringly empty space. > I understand, but somehow I'm not very offended by that. It's just something I've grown so used to, even before xref. Just C-h f to a function description of which you know nothing of the length and boom, a lot of empty space too. While I do vaguely remember being annoyed by it many years ago, I don't now. And for xref I like to see it well highlighted away from any other text, so I can easily count the references. Displaying next to the minibuffer are would surround it with more noise. It's just the way I work. Fortunately now it is customizable, right? How about adding an entry to the manual, in the xref section, mentioning a couple of commands or customization variables that can be used to get the interface that you prefer, Juri? Jo=C3=A3o --000000000000475bf005848eea30 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Wed, Mar 20, 2019 at 10:35 PM Juri Lin= kov <juri@linkov.net> wrote:
>> As noted in bug#33870 the buffer produced by xref-find-= definitions
>> (bound to =E2=80=98M-.=E2=80=99) has a transient nature like the *= Completions* buffer.
>> Therefore it makes sense not to waste its space needlessly:
>
> It doesn't make sense to review this patch until the patch that fi= xes 33870
> has been produced.

Since the patch from bug#33870 has been already committed,
this bug#33992 is undeadlocked now.

The problem with xref-find-definitions is its unexpected outcome:
sometimes it pops up a window, sometimes doesn't.

It's like Russian roulette: pull the trigger, bang and there is
a hole in the screen that takes the form of glaringly empty space.

I understand, but somehow I'm not very offe= nded by that.=C2=A0 It's just
something I've grown so use= d to, even before xref.=C2=A0 Just C-h f to
a function descr= iption of which you know nothing of the length
and boom, a l= ot of empty space too.

While I do vag= uely remember being annoyed by it many years ago,
I don't now= . And for xref I like to see it well highlighted away from any
other text, so I can easily count the references.=C2=A0 Displaying next = to the
minibuffer are would surround it with more noise.

It's just the way I work.=C2=A0 Fortunately = now it is customizable, right? How about
adding an entry to the m= anual, in the xref section, mentioning a couple of
commands or cu= stomization variables that can be used to get the interface
that = you prefer, Juri?

Jo=C3=A3o
--000000000000475bf005848eea30--