From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#66144: 29.1; eglot-shutdown request params violate JSONRPC Date: Sat, 14 Oct 2023 19:33:09 +0100 Message-ID: References: <83bkd1sjr1.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28980"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 66144@debbugs.gnu.org To: Javier Olaechea Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 14 20:31:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qrjPw-0007Qz-5V for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 14 Oct 2023 20:31:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qrjPO-0007cn-4O; Sat, 14 Oct 2023 14:30:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qrjPL-0007cB-B9 for bug-gnu-emacs@gnu.org; Sat, 14 Oct 2023 14:30:39 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qrjPK-0004nd-Us for bug-gnu-emacs@gnu.org; Sat, 14 Oct 2023 14:30:39 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qrjPi-0005UP-8n for bug-gnu-emacs@gnu.org; Sat, 14 Oct 2023 14:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Oct 2023 18:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66144 X-GNU-PR-Package: emacs Original-Received: via spool by 66144-submit@debbugs.gnu.org id=B66144.169730825521086 (code B ref 66144); Sat, 14 Oct 2023 18:31:02 +0000 Original-Received: (at 66144) by debbugs.gnu.org; 14 Oct 2023 18:30:55 +0000 Original-Received: from localhost ([127.0.0.1]:50497 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qrjPb-0005U1-5U for submit@debbugs.gnu.org; Sat, 14 Oct 2023 14:30:55 -0400 Original-Received: from mail-lf1-x12b.google.com ([2a00:1450:4864:20::12b]:55413) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qrjPZ-0005Tm-7T for 66144@debbugs.gnu.org; Sat, 14 Oct 2023 14:30:53 -0400 Original-Received: by mail-lf1-x12b.google.com with SMTP id 2adb3069b0e04-507a0907896so1121224e87.2 for <66144@debbugs.gnu.org>; Sat, 14 Oct 2023 11:30:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697308223; x=1697913023; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=nH293QJWMCEPn8Kh+xylCDHIS4yTeX8Hew6f1eyij/E=; b=GEjhdfj5k9V1Lxx0ZrpGxiKMSuWqhy351qdbBJ1nlSKIauMU9Ue+agTpFP+DToOwe5 GzsZSQJurtwF68rWl3EamS3Zl+ilMM439ERwOoIsfv8g/qI96muaH8qvYnpOtShrYd8X t+B7xVaeTNekakSfVhV7K7F4uMfuiXmNZdtxWembMzl6jjWGd/bARp3QIzoWxdK2MkZV EDef+6MM3gB67KqkINPqcsST/8ZqvrzsD6/Yn5zI3x3gihiiJEKrd+xlFsYgNWwV9Ko1 4TtKDut6ZR3Z7UACKzsrWy9ovDY1IVvutkos+v5hC4bg2hx+1YV0ic28AqsGisUJz1Yl VLug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697308223; x=1697913023; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nH293QJWMCEPn8Kh+xylCDHIS4yTeX8Hew6f1eyij/E=; b=j3UynnQj2cnhN8H1P5pi9Txc3i1xc3SihvBIZSkxmoti+pS1MRPV8J1xIvfYqoVL+a X3TJjVoTY6GwDk1/gZ4AzvyqSHnHV737zu7Mh7KQnZ2YYunkXgFrww+HGtclQuQ1k5Rl 8Pek7fgltESpwtbgyrtizn6+k3pW01MAgcqeVKH79JGOlFitrl0dNpziWkk5f6cQt/F6 wTQC1g++KXNH8NRl/kINpslUPaeWhx6wD4y9i/Nkm1Xzl4/UOJRyVdXVVa07xM68gvB2 nezsLIkWgOwTcOSuvL0nJQmoKrZCpAwiPIU00Qp3M0iATLl43GO1msg782jP+TuFZyT0 gHEw== X-Gm-Message-State: AOJu0YyE2Tponckz2XS1SAHQtBMdOAsLbGvnI4XMX4CfworXVG244Y5r 2h7VBnXI/kzCGrGy3+seeyb5d87soGQU6wF0t5s= X-Google-Smtp-Source: AGHT+IG+tbouCmx0JXUuC3n4ltseTw2MrvCIHbjm5Mq/LXTCprE3begSN0FkbFills5xWFwxNVayelcpVZXIra3s2PA= X-Received: by 2002:a05:6512:1155:b0:502:fdca:2eaa with SMTP id m21-20020a056512115500b00502fdca2eaamr29112938lfg.52.1697308223261; Sat, 14 Oct 2023 11:30:23 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:272456 Archived-At: On Sat, Oct 14, 2023 at 7:02=E2=80=AFPM Jo=C3=A3o T=C3=A1vora wrote: > > On Sat, Oct 14, 2023 at 6:19=E2=80=AFPM Javier Olaechea wrote: > > > > > If you can find some Eglot use case that is actually hurt by this, we= can reopen. > > > > The OP has an Eglot use case that is hurt by this, they cannot shutdown= the ocamllsp server. Because when they call M-x eglot-shutdown, eglot send= s an invalid request. The server dies instead of returning a response and t= hen eglot restarts the server. > > But what OP? I don't see this message, can you point to it? OK, I see the message now. In that case that changes things. One of the misbehaving servers has to correct itself. I'd say it should be gopls. Unless that has already happened. Can you test gopls shutdowns with your patch Javier? Jo=C3=A3o