From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#42149: Substring and flex completion ignore implicit trailing =?UTF-8?Q?=E2=80=98any=E2=80=99?= Date: Wed, 14 Oct 2020 09:39:47 +0100 Message-ID: References: <87k0znsdjb.fsf@gmail.com> <87sgbsv7gg.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000000885d905b19d7afa" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3321"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 42149@debbugs.gnu.org, Stefan Monnier To: Dario Gjorgjevski Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Oct 14 10:41:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kScLO-0000lR-95 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 14 Oct 2020 10:41:10 +0200 Original-Received: from localhost ([::1]:60660 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kScLN-000106-Ab for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 14 Oct 2020 04:41:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37286) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kScLG-0000zz-Aj for bug-gnu-emacs@gnu.org; Wed, 14 Oct 2020 04:41:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38471) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kScLG-0001eu-1t for bug-gnu-emacs@gnu.org; Wed, 14 Oct 2020 04:41:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kScLG-0006AK-0l for bug-gnu-emacs@gnu.org; Wed, 14 Oct 2020 04:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 14 Oct 2020 08:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42149 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 42149-submit@debbugs.gnu.org id=B42149.160266480723630 (code B ref 42149); Wed, 14 Oct 2020 08:41:01 +0000 Original-Received: (at 42149) by debbugs.gnu.org; 14 Oct 2020 08:40:07 +0000 Original-Received: from localhost ([127.0.0.1]:50017 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kScKN-000693-2C for submit@debbugs.gnu.org; Wed, 14 Oct 2020 04:40:07 -0400 Original-Received: from mail-io1-f49.google.com ([209.85.166.49]:33273) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kScKK-00068N-Oa for 42149@debbugs.gnu.org; Wed, 14 Oct 2020 04:40:05 -0400 Original-Received: by mail-io1-f49.google.com with SMTP id r4so4149247ioh.0 for <42149@debbugs.gnu.org>; Wed, 14 Oct 2020 01:40:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7WL6XVTvzXvOHZ9Z2fRiWuvFwv2i3OXHuz385T5JLF8=; b=WSaCiDxo95JDj3pWnlElm1oE4LdVf94izMh9tAL68cDb3GJ2CcwV/9upRCA2q1IYVk qp1WB1s6orHBqx9wV2uyTMnez/FAoV+yQzBj/daHTpsHidJhvtKaTLnThGhxaSXQ4+UG feNlbO3rBWiXZTph+JtvfspxPXzw/cR0y1rs3xH5xqf34YwII0EN4R3h7jTMXzw2EWzu Y/10unwaWebz9Ozqkg18/SXobwJxMQAd3C+anSU21XaBMLwFCrvW/DYYfLE99xATexYC wqBjCs01A+yrshcmeV/xMzK0ROKE+S7FOmos3HMtnFoHkEvWrpzr+s2ks16+F8Q5FTTl ctcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7WL6XVTvzXvOHZ9Z2fRiWuvFwv2i3OXHuz385T5JLF8=; b=bOxeavlY27GqaMubpmY6JmzrG6j4zogdR49LmruNInq57Y2xlaxkx9/coMJkyPvTt1 imU2oD9WaSU4SwnC2ba8WONfZofMZ4v9uz4tc9XzzswIs0+sX/jaDJK1KMhdYrmCXVjJ g2YeaGK1v3db8UeiC6i5GWyUpMy6FgdSVe4GGQDabKJHIYOFHraIaGA0ms7T8Xr6OmSm eqxaCi3YZ3/ZVLxWY4xxKBsC52yjN9ATQfGw9W67qGFCQoH26tEEI/K+cjEKjcjPKCjS WpH6LojF4tdZLkxS8EwuSdpd5FuPXpGG33eyCclJY1AuAFCI46+j27rWLz7vAXZ6BENf LMOg== X-Gm-Message-State: AOAM533AxoX+HNsBdF5MkT/DeDXJnWJJDM/A5VKvrlLxtXujvtTb/Pzv qp1m5u/1bfrroBN/7eTrjmJCFVpcZ7g4D9/ncCs= X-Google-Smtp-Source: ABdhPJw7nvZjs6cxTb95jYsAOMc9B+K0fbGDubDK0Dfl8MIghTJHsyroCA8eh9sHw+Bwv97IbiK4qAw9CVH5H7R+30U= X-Received: by 2002:a05:6602:2354:: with SMTP id r20mr2081988iot.165.1602664798912; Wed, 14 Oct 2020 01:39:58 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:190492 Archived-At: --0000000000000885d905b19d7afa Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Dario, Sorry for the delay in handling this. I haven't had time to look into it in detail, which I must do since it is reasonably complex. However it looks good on the surface and from what I remember your original bug report holds water. I have two questions and a nitpick: 1. Question: if I compile and/or evaluate the changes to the test/lisp/minibuffer-tests.el file but _don't_ compile the changes to the lisp/minibuffer.el file, will they expose this bug and this bug only? In other words, will I get exactly the same failures that you describe originally in this issue and will that fact be apparent in the failure message(s)? 2. Question: are the changes to completion-pcm--optimize-pattern an optimization or does the fix above depend on them? If the former, could you make it a separate commit? 3. Nitpick: the commit message is broadly according to the format, but I find it hard to parse its intentions. Though conventions vary, I usually like to format the commit message like in this example which separates the what, the why and the how. "Fix the thing imperatively because racecar (bug#12345) Before, when the user did foo the system stupidly behaved bar. Now it's much better, it does baz. I fixed this by doing quux and quzz * file (function): use more intense quuxing." Jo=C3=A3o --0000000000000885d905b19d7afa Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Dario,

S= orry for the delay in handling this.

I haven&#= 39;t had time to look into it in detail, which I must do since
it= is reasonably complex.=C2=A0 However it looks good on the surface
and from what I remember your original bug report holds water.
<= div>
I have two questions and a nitpick:

=
1. Question: if I compile and/or evaluate the changes to the
test/lisp/minibuffer-tests.el file but _don't_ compile the change= s
to the lisp/minibuffer.el file, will they expose this bug and t= his
bug only?=C2=A0 In other words, will I get exactly the s= ame failures
that you describe originally in this issue and = will that fact be
apparent in the failure message(s)?
<= div>
2. Question: are the changes to completion-pcm--optimize= -pattern
an optimization or does the fix above depend on them?=C2= =A0 If the
former, could you make it a separate commit?

3. Nitpick: the commit message is broadly according to= the
format, but I find it hard to parse its intentions. Tho= ugh
conventions vary, I usually like to format the commit me= ssage
like in this example which separates the what, the why= and
the how.

"Fix the thing im= peratively because racecar (bug#12345)

Before, whe= n the user did foo the system stupidly behaved
bar. Now it's = much better, it does baz.

I fixed this by doing qu= ux and quzz

* file (function): use more intens= e quuxing."

Jo=C3=A3o


--0000000000000885d905b19d7afa--