From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#72705: 31.0.50; eglot--dumb-tryc Filters out too much Date: Tue, 20 Aug 2024 10:40:01 +0100 Message-ID: References: <54dacc71-4395-431f-abc4-c60dc070cb03@gutov.dev> <0ff5f767-be87-4d64-964c-0a20fa776acf@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35632"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 72705@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 20 11:40:38 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sgLLx-00096c-KU for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 20 Aug 2024 11:40:37 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sgLLg-0007s2-VQ; Tue, 20 Aug 2024 05:40:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sgLLf-0007rq-NG for bug-gnu-emacs@gnu.org; Tue, 20 Aug 2024 05:40:19 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sgLLf-00061o-EX for bug-gnu-emacs@gnu.org; Tue, 20 Aug 2024 05:40:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:From:In-Reply-To:References:MIME-Version:To:Subject; bh=4hABxycDZc18QRd7ndWj1tWcDVA2+zA4ImAjCWKrN/Q=; b=e1eIswuS10tUrb5s/wRh7xAA+a7KaC+0Ckxy191XfsGXb9ZQrZ7XmYim7t8G9m7Lq4hhesi0tb50e2GgpAQBfvpYrIM6wnWIc5nFpbJM+PoWza05Bbnp8JoVu0sj5i5FjjMXKzDBeQSdb/Li+6vMXf37tMnwzrxRMDVZRggu9pnc+4CTKzJpvnlMY4P2rAjHo2LGG73VtxYPobudabyD3x0dfW4EMvqzj92aq/BwqZ5IBtURvAmjeqZr2pCqgNtlBYynQCAlnYSoNPOmjFmiYjHg3s3Tp2/tUT4zqO7MhBO9lctcnSlD7ALfKhf0jLfcy2hL4NpPZiJTmDTHKzXGtw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sgLMM-0004H9-7G for bug-gnu-emacs@gnu.org; Tue, 20 Aug 2024 05:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 20 Aug 2024 09:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72705 X-GNU-PR-Package: emacs Original-Received: via spool by 72705-submit@debbugs.gnu.org id=B72705.172414683716388 (code B ref 72705); Tue, 20 Aug 2024 09:41:02 +0000 Original-Received: (at 72705) by debbugs.gnu.org; 20 Aug 2024 09:40:37 +0000 Original-Received: from localhost ([127.0.0.1]:59902 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sgLLw-0004GE-Tf for submit@debbugs.gnu.org; Tue, 20 Aug 2024 05:40:37 -0400 Original-Received: from mail-oi1-f176.google.com ([209.85.167.176]:58804) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sgLLu-0004Fu-Og for 72705@debbugs.gnu.org; Tue, 20 Aug 2024 05:40:35 -0400 Original-Received: by mail-oi1-f176.google.com with SMTP id 5614622812f47-3db19caec60so3360030b6e.1 for <72705@debbugs.gnu.org>; Tue, 20 Aug 2024 02:39:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724146726; x=1724751526; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=4hABxycDZc18QRd7ndWj1tWcDVA2+zA4ImAjCWKrN/Q=; b=QXt250aG4fkcuWcn5tpqsg4CD/09/VE7XW9o91yj9fxRjEXTDgupfeEmkjsTcFtCYe xbJQoerdBMVAulZ4Ipc9BXcbB/NQ5kte7BdOKIEPaYLdPlwOz0L6spZV8ab3Ov3hCLfI equO9v2850dU/Lu6BYlHwxzBCFxA7pv1RBKPeNehS5bcuqWbgvO5N7pYC2cX+N7Nfhf8 Z9T7y9rSwXAjRh5MLUMkrMuHgGZpI1wVC6qSqZsz0rvAkm7W8LPVCDxYt/FW4N7Ph+lv FXPlemyZadA63FlaZ/7C8KDY1bx5BB7XMCiVJI/LzCR5E413d7nuJtDitq0+zoQjcn9g 4gzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724146726; x=1724751526; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4hABxycDZc18QRd7ndWj1tWcDVA2+zA4ImAjCWKrN/Q=; b=WoO6bkM/FBGzHxRGp2Ogn1UpA5ZWi+HMY+IpdfPhE6QiUQJEgCmGKAB9GNRoH5rNse OSdiI+lZIP/rqnXvQdof+dLysQOn08ZO1x4OEw1mJG7alh810SHbzC8vXvZyiAgnD+Vz u5j8VqfjliXq5tFVqqeSb5kRdhPga3BMixJzJ/O/U4/C1mM88yroAKq/i752UrtSyyt5 5PGQBSvL5/aNmTQ6cP8JZkzZMugoAJXsy//qLTtCxuTTmq+cUrISe8PGUcsjTWFmGiJV 8SiuXfYeeLE6plnFeB1hLPTZo97x2fHGNtLOIKc6P+qhp8bGPg6p0ip51vg2QvraiAlz SpKg== X-Gm-Message-State: AOJu0YxBX8iDebVE5DBY+85bx61vNSw0Gj9FRF7fdgrqiESK/B6xTZ+w MLaL02CHUa6+u7/E7pcpde2TMQggs5yzsVfIrw2DkXKJom0Sr6xFIRXLvpxOgubChmebajYiYWy WGFLrFSQ8wlY1ZyrediiioIP18io= X-Google-Smtp-Source: AGHT+IFbAUjzIBjJ1hdeG0aV5UPsoN34hWglZcVDZEIxQAmgncuMg8ExKRXtgCb0gRzdazia2jWn0p5HX23IZ9nrNDg= X-Received: by 2002:a05:6808:150e:b0:3d9:3649:9087 with SMTP id 5614622812f47-3dd3af827f1mr17913189b6e.41.1724146725974; Tue, 20 Aug 2024 02:38:45 -0700 (PDT) In-Reply-To: <0ff5f767-be87-4d64-964c-0a20fa776acf@gutov.dev> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:290429 Archived-At: On Tue, Aug 20, 2024 at 3:08=E2=80=AFAM Dmitry Gutov wro= te: > So far I've tested with gopls and clangd (when writing the new tests), > typescript-language-server and rust-analyzer. That's pretty good. If you could add pylsp or pyright (basedpyright), I'd feel even more confident. > All right. > > The proposed change doesn't alter the kinds of strings that are > inserted, only the cases when that happens. When the added predicate > returns nil, we fall back to the next clause; and the check at the end > also allows us to return nil, which is useful in certain rare contexts. I don't have time to spend examining these details, just the final outcome is relevant: partial completions cannot be inserted, but fragments of a completion can be completed to a fully formed completion (eventually running exit-function then). > The report that's referenced in the 3 commits your mentioned does seem > to have regressed is https://github.com/joaotavora/eglot/issues/1339 > not to the original behavior (exit-function still works), but C-M-i > changes buffer text to > > v.call1234.1234567890 I don't have time to investigate right now, but indeed that issue there wer= e two consecutive fixes: the first one (which you say "still works") and a se= cond one which I eventually reverted because it fixes some things and broke others. So is the regression you mention in relation to the current Eglot state or to that intermediate state? Regardless, if possible, make an automated test and mark it "expected failing" to record this fact. > I suppose that could be fixed by moving some matching logic from the > style into the completion table. Not sure how important/realistic the > example is, although somebody did report it... I'd have to have a clearer view on what exactly has regressed and what has advanced. Then a better decision can be made. Thank you for this work. Jo=C3=A3o