From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#70958: 30.0.50; eglot-managed-mode hooks not called on shutdown Date: Mon, 27 May 2024 22:05:28 +0100 Message-ID: References: <86y17yz5sr.fsf@gnu.org> <87ed9np6n8.fsf@betli.tmit.bme.hu> <877cffp38y.fsf@betli.tmit.bme.hu> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2188"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 70958@debbugs.gnu.org, Eli Zaretskii , Troy Brown , Stefan Monnier To: Felician Nemeth Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 27 23:07:49 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sBhZN-0000Ka-8T for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 27 May 2024 23:07:49 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sBhYZ-0001uf-J9; Mon, 27 May 2024 17:06:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sBhYU-0001tb-98 for bug-gnu-emacs@gnu.org; Mon, 27 May 2024 17:06:55 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sBhYT-00023J-NY for bug-gnu-emacs@gnu.org; Mon, 27 May 2024 17:06:54 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sBhYc-0006go-JO for bug-gnu-emacs@gnu.org; Mon, 27 May 2024 17:07:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 27 May 2024 21:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70958 X-GNU-PR-Package: emacs Original-Received: via spool by 70958-submit@debbugs.gnu.org id=B70958.171684402025695 (code B ref 70958); Mon, 27 May 2024 21:07:02 +0000 Original-Received: (at 70958) by debbugs.gnu.org; 27 May 2024 21:07:00 +0000 Original-Received: from localhost ([127.0.0.1]:45353 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sBhYa-0006gK-46 for submit@debbugs.gnu.org; Mon, 27 May 2024 17:07:00 -0400 Original-Received: from mail-lf1-f41.google.com ([209.85.167.41]:58470) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sBhYX-0006fl-PM for 70958@debbugs.gnu.org; Mon, 27 May 2024 17:06:58 -0400 Original-Received: by mail-lf1-f41.google.com with SMTP id 2adb3069b0e04-5295a66e775so223948e87.0 for <70958@debbugs.gnu.org>; Mon, 27 May 2024 14:06:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716843943; x=1717448743; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=haoTbYkVFrZTKbwJRED/EbuFxbMtQhkjoQ8X1lUHT1k=; b=XOhbaF9yqkR0/BQZIRS8TGFwohO9JDXnaOgMZmnTYXhC8Ecu9e7Dtocrg2Pc5qJpfu yswKKXcidFEB4Na5Bh7a5byN52oAXbfP6dgpaWB0TU6OOUlqYo0qFVDwrmzh7eEk+L2U rooTlxLS5wq7h+gIcZblZ0ORh9H6r18qeYCwpBy+KJmmYnNw2HgtvfnRxQWD/cMqQCef gyIpJNGQqSjTUz6hz6BdbJHywXnCDwoAESWUEcANr7e2o0/gSush8KouqsL/Fql9GNlA H22OrZWiFn6BONIulKKNxU0MwC7Y3kIZzIz+mHzAKvMtp32uQsXs9nPkDzBhuUjtcQeO gzjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716843943; x=1717448743; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=haoTbYkVFrZTKbwJRED/EbuFxbMtQhkjoQ8X1lUHT1k=; b=diwAvpovAagn2pwC55sKEM9Tdf0RjhxctHlvywT4PKjTAHobH1zVjok6zZ/3RX6hm4 tWRM04EgaSwXgVmoPxjT1Zrsc6e7oVaaflocdUrLJ9j1vO62koK6u7zosLoa5XSugeSH H4Vobt/kPK1mdm5QhUiGGWDtVRF981YbD0hJo/EXZLlEyig8lhABNAGvZ+/SwQc/5wCX CncwdIo5Q2qz2gvANK+0KkrH29K5rvRRHXCceR9YZQyjyJFuKHt6ONQ68YMH6p/0xgT1 G5ZbCa4p5RQoaW7OU9kzTEXM2/UyIyKGC6nCPHibweH+X38o4n8ebPF/67Sno2wepf2c OiIA== X-Forwarded-Encrypted: i=1; AJvYcCU3rTzuj749WR2Jc3ffEBnSdQGJpBxwuH370B85X2P1yTGetwinGKW2MTtLiXOM3LOjTZa59qG/0+k/cw3LCSIB/BVdl7M= X-Gm-Message-State: AOJu0YyaRmar407L2nCE/vK5iQfvBYmMUrAC665i39+n/l2Cv5OBUOtc xn9V7kn3l8RbE1Hg2WQ35okoqnRUUPGusslJKs9GCV/BGnVZ2mtrktiXSIEzcQtl6K7wbzz6rzg 1gwtA4kTNFLVvlAI6Di9suY4+1XU= X-Google-Smtp-Source: AGHT+IFIzI9zV9N7ecoHpH4P14UZUy9np5gCAZin4wcSf+3gVnN6E2svFtqlYyyawUIvO97Gn+HCjQGgYmVr5EVDVbM= X-Received: by 2002:a05:6512:3d88:b0:529:b718:2411 with SMTP id 2adb3069b0e04-529b71828e5mr1145081e87.6.1716843942446; Mon, 27 May 2024 14:05:42 -0700 (PDT) In-Reply-To: <877cffp38y.fsf@betli.tmit.bme.hu> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:286069 Archived-At: On Mon, May 27, 2024 at 6:35=E2=80=AFPM Felician Nemeth wrote: > > Jo=C3=A3o T=C3=A1vora writes: > > >> > So when e-m-m-hook was added it was made to run only on "turn on" > >> > > IOW, I don't think there was ever a time when it was ever run at "off" > > time. > > I don't think it matters much, but originally it did run in both cases: > https://github.com/joaotavora/eglot/commit/8d8c90d0d654d262e0ff43f45444ec= 6a512b8185 > > So the current situation can be regarded as a regression. I think it does matter, it's one less thing to worry about if we push that one-liner patch. Can you comment on it, is it doing more or less the same in your opinion? I opted to put it before before the server is shutdown, so that, like the on case, it has access to a presumably fully setup server. Jo=C3=A3o