From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#67152: [PATCH] Fix flymake integration in lua-ts-mode Date: Wed, 15 Nov 2023 12:24:08 +0000 Message-ID: References: <583004a793d54e48e65df38209bace3b6932c98b@pub.pink> <83wmuks9rq.fsf@gnu.org> <83pm0cs8nc.fsf@gnu.org> <789f237e8ac62415aa6ed81b5530e21a50dacda5@pub.pink> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15364"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 67152@debbugs.gnu.org To: jm@pub.pink Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 15 17:27:11 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r3IjP-0003p0-OR for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 15 Nov 2023 17:27:11 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r3IjI-0001vG-JU; Wed, 15 Nov 2023 11:27:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r3IjH-0001ut-8o for bug-gnu-emacs@gnu.org; Wed, 15 Nov 2023 11:27:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r3IjH-0005MT-0u for bug-gnu-emacs@gnu.org; Wed, 15 Nov 2023 11:27:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r3IjG-000242-3o for bug-gnu-emacs@gnu.org; Wed, 15 Nov 2023 11:27:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Nov 2023 16:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67152 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 67152-submit@debbugs.gnu.org id=B67152.17000655787866 (code B ref 67152); Wed, 15 Nov 2023 16:27:02 +0000 Original-Received: (at 67152) by debbugs.gnu.org; 15 Nov 2023 16:26:18 +0000 Original-Received: from localhost ([127.0.0.1]:53102 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3IiY-00022m-EC for submit@debbugs.gnu.org; Wed, 15 Nov 2023 11:26:18 -0500 Original-Received: from mail-ej1-x631.google.com ([2a00:1450:4864:20::631]:47531) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3IiV-00022X-VW for 67152@debbugs.gnu.org; Wed, 15 Nov 2023 11:26:16 -0500 Original-Received: by mail-ej1-x631.google.com with SMTP id a640c23a62f3a-9d10f94f70bso1013938166b.3 for <67152@debbugs.gnu.org>; Wed, 15 Nov 2023 08:26:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700065571; x=1700670371; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=+8Wao9EdHf9l78tYKbtZGjydK5fAX95oq8NGdcaj1hk=; b=aZOxzgbRa4YDlplTOBfVIITp8/lIknXlhgVZuXHIDVpPoV/dL7yKc68VFImT75EEZ3 IAqkMy5xzwGS5Q/H1Z5ZaF9L4Q0eXvaPAUyIZSNp445hqH1xZXY6cH8kYEoKaDpTuPcY 3MnnHuZLcCXOhc8NMLDpLrlkj8msYf19LDMzcXta2TFUVgoNr1lWVw8RSU3UlHCuyoo8 xL1VPAAB9m4YrscgHBSXM7FMZNaJlnMqB4e/Or1GqzFI/NSvKF1cezIxHADfFLI1guv9 rJrDOaiIfKhb/KcIH8kKNXtaJpZCUDggNbhy2Bovp4dJ8WdrBQf0QiPlDZLU4PIpnlQL BITQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700065571; x=1700670371; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+8Wao9EdHf9l78tYKbtZGjydK5fAX95oq8NGdcaj1hk=; b=u9rogemkd0F0VOvvvSvBdXCsWOEbW5Pdxr/Yg+EUgc1TSMu5zX0bb0+YNwtbGP4N+J QNu9YFXhtTh2Iz4H/jTdOGmNDmG/m7mziCgdm4N+TfCUCFnYPgFszf1b/iXtDBxqHR37 hYyBH0c1eAsv2IRL856rEvSyALqMTQvePXuOYryQ7rI9rvDjdVW83kGx9vQjidZBl9/a yHrTM6XdMkUXTkxpDqHKiyyoKI9WIvjevmrR9tc+4procIxsGgz74/P34aFH+TYpPsxy 0rI4wvqf9fOefzxh54q3ZKcH8wYvP9GvcRzUZT16Ur+9zON/IWjavbvAumtwC60K8Ono JzeQ== X-Gm-Message-State: AOJu0YzbqHXfldJ/bUCmg7/u+xo223rbnD84akeEtIfYDwT1k4jKHavI 3Mbw5w3pkPEqggvBZhPSFdlqnwAphvgzMRlW9ck+I8LQwKhBCw== X-Google-Smtp-Source: AGHT+IF9MEy6zRLrZ7gdy12V5RnZtQmQnm+TP1ablCQfzfDYCWikm0ADJYsPNEh2VldR82Hie1keD8if3LjpHHsBgZc= X-Received: by 2002:a05:6512:b05:b0:503:3816:c42c with SMTP id w5-20020a0565120b0500b005033816c42cmr11187611lfu.41.1700051059809; Wed, 15 Nov 2023 04:24:19 -0800 (PST) In-Reply-To: <789f237e8ac62415aa6ed81b5530e21a50dacda5@pub.pink> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274370 Archived-At: Just a note that in the recent patch you provided, (match-string 3) isn't being used. If is is a useful "end column" identifier, you might want to call flymake-diag-region again to get the the corresponding buffer position. flymake-diag-region could see some docstring improvements. It gets a line and optionally a column, whidh defines a single point. It then tries to guess a region, because it's impossible to form a region from just a point. The guess is based on thing-at-point. This guess _may_ be worse than whatever the backend supplied in (match-string 3) so passing that number to flymake-diag-region again to obtain a second point may be a good idea to compose the two buffer positions to give to flymake-make-diagnostic. Jo=C3=A3o