From: "João Távora" <joaotavora@gmail.com>
To: jm@pub.pink
Cc: 67152@debbugs.gnu.org
Subject: bug#67152: [PATCH] Fix flymake integration in lua-ts-mode
Date: Wed, 15 Nov 2023 12:24:08 +0000 [thread overview]
Message-ID: <CALDnm51Zn9POKUsxxHRnMngLdq1hQSZRAY7uJ7msonHwDVMMmQ@mail.gmail.com> (raw)
In-Reply-To: <789f237e8ac62415aa6ed81b5530e21a50dacda5@pub.pink>
Just a note that in the recent patch you provided, (match-string 3)
isn't being used. If is is a useful "end column" identifier, you
might want to call flymake-diag-region again to get the the
corresponding buffer position.
flymake-diag-region could see some docstring improvements.
It gets a line and optionally a column, whidh defines a
single point. It then tries to guess a region, because it's
impossible to form a region from just a point.
The guess is based on thing-at-point. This guess _may_ be worse
than whatever the backend supplied in (match-string 3) so passing
that number to flymake-diag-region again to obtain a second point
may be a good idea to compose the two buffer positions to give
to flymake-make-diagnostic.
João
next prev parent reply other threads:[~2023-11-15 12:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <handler.67152.B.169991476321361.ack@debbugs.gnu.org>
2023-11-13 22:31 ` bug#67152: [PATCH] Fix flymake integration in lua-ts-mode jm--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-13 22:40 ` jm--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-14 14:13 ` Eli Zaretskii
2023-11-14 14:23 ` João Távora
2023-11-14 14:26 ` João Távora
2023-11-14 14:37 ` Eli Zaretskii
2023-11-14 18:08 ` jm--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-15 0:09 ` jm--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-15 12:24 ` João Távora [this message]
2023-11-15 13:02 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALDnm51Zn9POKUsxxHRnMngLdq1hQSZRAY7uJ7msonHwDVMMmQ@mail.gmail.com \
--to=joaotavora@gmail.com \
--cc=67152@debbugs.gnu.org \
--cc=jm@pub.pink \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).