From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#59338: 29.0.50; Commit 1a2d603bb3 breaks Eglot on Windows Date: Thu, 24 Nov 2022 15:27:57 +0000 Message-ID: References: <86bkp5y16y.fsf@gnu.org> <83r0y1cxyb.fsf@gnu.org> <87o7t5wlby.fsf@gmail.com> <87bkp5xl6f.fsf@dfreeman.email> <83edu0d9dg.fsf@gnu.org> <87tu2olb56.fsf@dfreeman.email> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000005e2d1f05ee390d32" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30155"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Richard Copley , Eli Zaretskii , arstoffel@gmail.com, arash@gnu.org To: Danny Freeman , 59338-done@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 24 16:29:11 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oyEA3-0007ev-2b for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 24 Nov 2022 16:29:11 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oyE9v-0006xe-9M; Thu, 24 Nov 2022 10:29:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oyE9u-0006xP-M0 for bug-gnu-emacs@gnu.org; Thu, 24 Nov 2022 10:29:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oyE9u-0007x5-Dc for bug-gnu-emacs@gnu.org; Thu, 24 Nov 2022 10:29:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oyE9u-00006A-9Z for bug-gnu-emacs@gnu.org; Thu, 24 Nov 2022 10:29:02 -0500 Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Thu, 24 Nov 2022 15:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 59338 X-GNU-PR-Package: emacs Mail-Followup-To: 59338@debbugs.gnu.org, joaotavora@gmail.com, arash@gnu.org Original-Received: via spool by 59338-done@debbugs.gnu.org id=D59338.166930369632750 (code D ref 59338); Thu, 24 Nov 2022 15:29:02 +0000 Original-Received: (at 59338-done) by debbugs.gnu.org; 24 Nov 2022 15:28:16 +0000 Original-Received: from localhost ([127.0.0.1]:59836 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyE9A-0008W8-Ac for submit@debbugs.gnu.org; Thu, 24 Nov 2022 10:28:16 -0500 Original-Received: from mail-oo1-f45.google.com ([209.85.161.45]:40519) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyE98-0008Vr-28 for 59338-done@debbugs.gnu.org; Thu, 24 Nov 2022 10:28:14 -0500 Original-Received: by mail-oo1-f45.google.com with SMTP id v7-20020a4aa507000000b00496e843fdfeso303713ook.7 for <59338-done@debbugs.gnu.org>; Thu, 24 Nov 2022 07:28:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=BzATovxQx8pF0VUpp8YHsm8Ob9dn7fuc+KX/K+iuME0=; b=Ar0nXPijwOpur2vUq1DPiMQPOvHL2DrmJXPsUcBdvaO4hDQIWV52sXuGUg+0n0x/S1 +F29NBX+Z9193/tWB+grrmh2Xpeegg2FQITeN4EHmKkzz5LO0pq/i8iDlJyBbtzZkVIC kbG0TKCqTlN+kgrEwE9h98q7ScJxHgde3XgYtVsVfS9gApZkmnjsPlAa/LLXQpXG8zaK UCVVcjIz3zaxszlD0/kYlvXPWyHvztpw9yuHIILNp/1Y7Huvd5B80VYvDb+f4senYjHo RCx49R+m9Z0d9xuILDAtcJlBiItol1Q10IXxWuHxdxoCbkPYlLmdLMD2CFqe6Nj80LSb dgcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BzATovxQx8pF0VUpp8YHsm8Ob9dn7fuc+KX/K+iuME0=; b=1SChr48nrFSuwY6MGnJTkcIalHyxSAptT9TBFV+6Nu3oHFymtORgyydFmp9C0lX93L IMUIONmOrPjKBlcI9eiBe6JLQqzUKJ9RuwPuEaMokJCJUPw8HFAh5D4y5K7ft8d1NkWN jCKksPcM8fkqtwuyuaRyDB8YAeoCf2+yCDSneFxL03zg+Bz0L1HX/lQk/OKN3dQPXPHC qnwhxEaUIoq+bXCO1QfmyqxlrhD1aoAE8mSj/pQWWYmuMwnSOkyG4UKCJxTYylzbA9dZ QTfQvsqUkz67QlJH93mqLdx18FPdHhyTEezgeCTTm/6sfgRDoMAn1aPAt/gU66zvhJay JBLQ== X-Gm-Message-State: ANoB5pk6LIODhNoPAeqsD2YgMa2w4nxkStZKxaD+TV6Ih1smXxmzYukI 0VQ1aPpylb28K9GNnqvFCoypnP4ABywHIwpCKY8= X-Google-Smtp-Source: AA0mqf6CuyD0eyDGQzgmkLE/DcMc/tse3VqGeO88VVkCyPXO5TUT4mgpS5CekOe464hEQvUy77bgOCcdotBXrJBbtjU= X-Received: by 2002:a4a:e0d3:0:b0:49f:de1:96c0 with SMTP id e19-20020a4ae0d3000000b0049f0de196c0mr14917447oot.7.1669303688374; Thu, 24 Nov 2022 07:28:08 -0800 (PST) In-Reply-To: <87tu2olb56.fsf@dfreeman.email> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248878 Archived-At: --0000000000005e2d1f05ee390d32 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable I've just tested it on a Windows machine and pushed it, thanks. Closing this. Jo=C3=A3o On Thu, Nov 24, 2022 at 1:44 PM Danny Freeman wrote: > > Jo=C3=A3o T=C3=A1vora writes: > > > I just found out this bug was ongoing. > > > > Eli, if you're proposing to fix url-parse.el to not be fooled by window= s > > file names, then I support that idea, and I think it's the correct > > thing to do. > > > > But.... we still need the eglot.el kludge installed because url-parse.e= l > > is not distributed as an ELPA package and Eglot is. So users of > > Emacs < 29 would not receive the fix and would have their > > WIndows Eglot broken. > > > > Jo=C3=A3o > > > > Should my patch for eglot be merged then? > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D59338#53 > > -- > Danny Freeman > --=20 Jo=C3=A3o T=C3=A1vora --0000000000005e2d1f05ee390d32 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I've just tested it on a Windows machine and pushed it= , thanks.

Closing this.

Jo=C3=A3o=

On Thu, Nov 24, 2022 at 1:44 PM Danny Freeman <danny@dfreema= n.email> wrote:

Jo=C3=A3o T=C3=A1vora <joaotavora@gmail.com> writes:

> I just found out this bug was ongoing.
>
> Eli, if you're proposing to fix url-parse.el to not be fooled by w= indows
> file names, then I support that idea, and I think it's the correct=
> thing to do.
>
> But.... we still need the eglot.el kludge installed because url-parse.= el
> is not distributed as an ELPA package and Eglot is. So users of
> Emacs < 29 would not receive the fix and would have their
> WIndows Eglot broken.
>
> Jo=C3=A3o
>

Should my patch for eglot be merged then?
https://debbugs.gnu.org/cgi/bugreport.cgi?bu= g=3D59338#53

--
Danny Freeman


--
Jo=C3=A3o T=C3=A1vora
--0000000000005e2d1f05ee390d32--