unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "João Távora" <joaotavora@gmail.com>
To: Danny Freeman <danny@dfreeman.email>, 59338-done@debbugs.gnu.org
Cc: Richard Copley <rcopley@gmail.com>, Eli Zaretskii <eliz@gnu.org>,
	arstoffel@gmail.com, arash@gnu.org
Subject: bug#59338: 29.0.50; Commit 1a2d603bb3 breaks Eglot on Windows
Date: Thu, 24 Nov 2022 15:27:57 +0000	[thread overview]
Message-ID: <CALDnm51UK0fUtxEAJro=pRBN-CKJMnGdqzYJ9wVSQ+EubbzcXw@mail.gmail.com> (raw)
In-Reply-To: <87tu2olb56.fsf@dfreeman.email>

[-- Attachment #1: Type: text/plain, Size: 865 bytes --]

I've just tested it on a Windows machine and pushed it, thanks.

Closing this.

João

On Thu, Nov 24, 2022 at 1:44 PM Danny Freeman <danny@dfreeman.email> wrote:

>
> João Távora <joaotavora@gmail.com> writes:
>
> > I just found out this bug was ongoing.
> >
> > Eli, if you're proposing to fix url-parse.el to not be fooled by windows
> > file names, then I support that idea, and I think it's the correct
> > thing to do.
> >
> > But.... we still need the eglot.el kludge installed because url-parse.el
> > is not distributed as an ELPA package and Eglot is. So users of
> > Emacs < 29 would not receive the fix and would have their
> > WIndows Eglot broken.
> >
> > João
> >
>
> Should my patch for eglot be merged then?
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=59338#53
>
> --
> Danny Freeman
>


-- 
João Távora

[-- Attachment #2: Type: text/html, Size: 1485 bytes --]

  reply	other threads:[~2022-11-24 15:27 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-17 16:51 bug#59338: 29.0.50; Commit 1a2d603bb3 breaks Eglot on Windows Arash Esbati
2022-11-17 17:06 ` Eli Zaretskii
2022-11-17 17:18   ` Augusto Stoffel
2022-11-17 22:27     ` Danny Freeman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-17 23:12       ` Augusto Stoffel
2022-11-18  7:14         ` Eli Zaretskii
2022-11-18 13:39           ` Danny Freeman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-18 14:35             ` Eli Zaretskii
2022-11-18 14:55               ` Danny Freeman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-18 20:01                 ` Arash Esbati
2022-11-18  7:12       ` Eli Zaretskii
2022-11-23 12:51         ` João Távora
2022-11-24 13:42           ` Danny Freeman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-24 15:27             ` João Távora [this message]
2022-11-17 22:33   ` Arash Esbati

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALDnm51UK0fUtxEAJro=pRBN-CKJMnGdqzYJ9wVSQ+EubbzcXw@mail.gmail.com' \
    --to=joaotavora@gmail.com \
    --cc=59338-done@debbugs.gnu.org \
    --cc=arash@gnu.org \
    --cc=arstoffel@gmail.com \
    --cc=danny@dfreeman.email \
    --cc=eliz@gnu.org \
    --cc=rcopley@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).