From: "João Távora" <joaotavora@gmail.com>
To: Joseph Turner <joseph@ushin.org>
Cc: 67390@debbugs.gnu.org, Adam Porter <adam@alphapapa.net>,
Eli Zaretskii <eliz@gnu.org>, Jonas Bernoulli <jonas@bernoul.li>
Subject: bug#67390: 28; shorthands-font-lock-shorthands assumes shorthand uses same separator
Date: Sat, 3 Feb 2024 14:50:01 +0000 [thread overview]
Message-ID: <CALDnm51TcDCk=as6d88Uo92cGvok69Xtf-8nOdyDg9FmB+5fng@mail.gmail.com> (raw)
In-Reply-To: <87sf2at44r.fsf@ushin.org>
Sorry, this flew under the radar. I thought I had already pushed to master
but didn't. So I went through the commits again, addressed your concerns, and
applied your suggestions. Pushed to master now.
On Sat, Feb 3, 2024 at 7:10 AM Joseph Turner <joseph@ushin.org> wrote:
>> -[ \t]*%s\\([ \t;]+\\|$\\)")
>> - (regexp-opt (mapcar 'cadr fnlist) t)))
>> +[ \t]*\\(\\(?:\\sw\\|\\s_\\)+\\)\\([ \t;]+\\|$\\)"))
>
> Would you explain what this regexp is intended to match?
A very complicated one, right? Well ask the author, but I think it's intended
to find many definition-like forms. No idea why this is done with regexps and
not with 'read' as it is a classical parsing pitfall in the long run.
Maybe there
was a reason.
Anyway, I just added a bit of logic so that it considers
read-symbol-shorthands if
there are any.
> Are you able to reproduce this on your machine?
Yes, and I fixed it.
> ...then this form will allocate two strings almost as long as the file.
>
> Here's an alternative hack attempting to uncomment and read the minimum:
Thanks, I think that's a good idea and I added a commit in your name.
> A couple typo nits on the commit message of "Improve
> shorthands-font-lock-shorthands (bug#67390)":
>
> - h//thingy ; hilits "//" reads to 'hyperdrive--thingy'
> + h//thingy ; hilits "h//" reads to 'hyperdrive--thingy'
>
> - Co-authored-by: João Távora <joaotavora@gmail.com>
> + Co-authored-by: Joseph Turner <joseph@breatheoutbreathe.in>
I fixed these, too. If you succesfully test this, I think we can close this bug
(and the other ones, too).
João
next prev parent reply other threads:[~2024-02-03 14:50 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-22 22:18 bug#67390: 28; shorthands-font-lock-shorthands assumes shorthand uses same separator Jonas Bernoulli via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-23 12:57 ` João Távora
2023-11-24 21:51 ` Jonas Bernoulli via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-25 0:03 ` João Távora
2023-11-25 3:26 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-25 16:01 ` Jonas Bernoulli via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-25 22:42 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-26 13:52 ` João Távora
2023-11-26 20:35 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-26 22:02 ` João Távora
2023-11-27 3:48 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-27 12:10 ` Eli Zaretskii
2023-11-29 8:21 ` João Távora
2023-11-29 9:12 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-29 13:56 ` João Távora
2023-11-29 13:30 ` João Távora
2023-11-29 23:27 ` João Távora
2023-11-30 14:16 ` João Távora
2023-11-30 15:23 ` Eli Zaretskii
2023-11-30 15:29 ` João Távora
2023-12-09 18:50 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-03 7:10 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-03 14:50 ` João Távora [this message]
2024-02-03 19:43 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-03 22:25 ` João Távora
2024-02-03 23:48 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-21 22:05 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALDnm51TcDCk=as6d88Uo92cGvok69Xtf-8nOdyDg9FmB+5fng@mail.gmail.com' \
--to=joaotavora@gmail.com \
--cc=67390@debbugs.gnu.org \
--cc=adam@alphapapa.net \
--cc=eliz@gnu.org \
--cc=jonas@bernoul.li \
--cc=joseph@ushin.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).