unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "João Távora" <joaotavora@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 16981@debbugs.gnu.org, Alan Mackenzie <acm@muc.de>
Subject: bug#16981: 24.3.50; electric-pair-delete-adjacent-pairs broken in c-mode, python-mode, maybe-others
Date: Sun, 6 Apr 2014 16:08:39 +0100	[thread overview]
Message-ID: <CALDnm51SWVGXgd8JXe-fbFqmDf6HFrAzmxwpz4i5ea0z3gQb9g@mail.gmail.com> (raw)
In-Reply-To: <jwvfvlqljfm.fsf-monnier+emacsbugs@gnu.org>

On Sun, Apr 6, 2014 at 1:48 PM, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
>> Hmmm now I remember that's it's even harder than defadvice to find the
>> extra code, docstring-wise I mean. How would a hacker discover we're
>> using the filter trick. describe-key doesn't help. .
>
> Right.  C-h k will give you the binding, but only when
> electric-pair-delete-pair would be run.  To make this trick more widely
> usable, we'd need to change C-h k so that it shows all "possible bindings".

Yes, I realized that later on.

In the meantime, we can use the trick that yasnippet uses
(documentation-function if I'm not mistaken) to show what other command
electric-pair-delete-pair is shadowing in that situation.

>> Anyway should I install it?
> If that's OK with you, yes.

Yes, I think it's cleaner than all alternatives, unless add-function is
the way to go for these situations.

> Bzr doesn't really know about cherry picking, but if you put
> "backported" into your commit message, our bzrmerge.el script
> will know that this commit is already in the trunk and will know how to
> avoid the corresponding conflicts when merging emacs-24 back into trunk.

Alright, I'll include "backported from trunk, revs x and y".





  reply	other threads:[~2014-04-06 15:08 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <mailman.16921.1394480964.10748.bug-gnu-emacs@gnu.org>
2014-03-10 19:47 ` bug#16981: 24.3.50; electric-pair-delete-adjacent-pairs broken in c-mode, python-mode, maybe-others João Távora
2014-03-13 22:04   ` Alan Mackenzie
2014-03-18  1:56     ` bug#16959: " Stefan
2014-03-20  0:33       ` Florian Beck
2014-03-21 21:47         ` Stefan
2014-03-25 17:38           ` Florian Beck
2014-03-26  0:34             ` Stefan Monnier
2014-04-05 11:58     ` João Távora
2014-04-05 15:45       ` Stefan Monnier
2014-04-06  1:51         ` João Távora
2014-04-06 12:48           ` Stefan Monnier
2014-04-06 15:08             ` João Távora [this message]
2014-04-07  0:04             ` João Távora

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALDnm51SWVGXgd8JXe-fbFqmDf6HFrAzmxwpz4i5ea0z3gQb9g@mail.gmail.com \
    --to=joaotavora@gmail.com \
    --cc=16981@debbugs.gnu.org \
    --cc=acm@muc.de \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).