From: "João Távora" <joaotavora@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: dooleyn@gmail.com, 67442@debbugs.gnu.org
Subject: bug#67442: [PATCH] eglot: Add ruff-lsp as an alternative python server
Date: Sun, 26 Nov 2023 09:53:02 +0000 [thread overview]
Message-ID: <CALDnm51Q5-HhQkTqXDX=TNLjvJZ1C0VVrSipRo-ZEPQKyfmFWQ@mail.gmail.com> (raw)
In-Reply-To: <834jhac7hw.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1907 bytes --]
On Sat, Nov 25, 2023, 13:01 Eli Zaretskii <eliz@gnu.org> wrote:
> > From: João Távora <joaotavora@gmail.com>
> > Date: Sat, 25 Nov 2023 12:39:22 +0000
> > Cc: Niall Dooley <dooleyn@gmail.com>, 67442@debbugs.gnu.org
> >
> > On Sat, Nov 25, 2023, 11:09 Eli Zaretskii <eliz@gnu.org> wrote:
> >
> > > It supports surfacing Ruff diagnostics and providing Code Actions to
> > > fix them, but is intended to be used alongside another Python LSP in
> > > order to support features like navigation and autocompletion.
> >
> > What do you mean by "alongside"?
> >
> > João, does Eglot support such "alongside" servers?
> >
> > No. This is a feature on my to-do list, but alas I haven't had time to
> work on it.
>
> OK, thanks. So AFAIU, we cannot install this change yet, right?
>
We can. If you read this patch it establishes ruff as an "alternative"
('eglot-alternative'), not as an "alongside" companion.
But just because we can doesn't mean we should. It's possible that the ruff
server wasn't meant to be a full alternative to those other servers.
Reading from its website hints ruff is mainly a linter, so it has a
fraction of what other servers have
The proponents of this patch should argue in terms of ruff-only LSP support
in python buffers. Maybe enough value that it's reasonable to install
as-is, maybe not and we should wait for 'eglot-alongside'.
Or just wait for someone to code a flymake-ruff backend in python-mode.el.
That seems much more promising way to get the intended ruff experience into
Emacs.
There is also the common misconception (not sure if the case here) that if
a server isn't mentioned in 'eglot-server-programs' directly then Eglot
doesn't support it. And this is far from the truth: if 'ruff' is installed
in a user's machine M-x eglot can easily be made to prompt for it. I've
tried dozens of servers like that.
João
[-- Attachment #2: Type: text/html, Size: 3154 bytes --]
next prev parent reply other threads:[~2023-11-26 9:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-24 22:42 bug#67442: [PATCH] eglot: Add ruff-lsp as an alternative python server Niall Dooley
2023-11-25 9:19 ` Eli Zaretskii
2023-11-25 11:09 ` Eli Zaretskii
2023-11-25 11:19 ` Niall Dooley
2023-11-25 12:39 ` João Távora
2023-11-25 13:00 ` Eli Zaretskii
2023-11-26 9:53 ` João Távora [this message]
2023-11-27 10:22 ` Niall Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALDnm51Q5-HhQkTqXDX=TNLjvJZ1C0VVrSipRo-ZEPQKyfmFWQ@mail.gmail.com' \
--to=joaotavora@gmail.com \
--cc=67442@debbugs.gnu.org \
--cc=dooleyn@gmail.com \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).