From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#74914: 30.0.90; Eglot: Incorrect parameter highlighted in signatureHelp Date: Mon, 6 Jan 2025 10:55:26 +0000 Message-ID: References: <53ccf716-7ca6-476f-af39-36300f0a7f1e@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37099"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Dmitry Gutov , Felician Nemeth To: Troy Brown , 74914-done@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 06 11:56:26 2025 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tUkmX-0009SB-S5 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 06 Jan 2025 11:56:25 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tUkmC-0008Vw-CR; Mon, 06 Jan 2025 05:56:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tUkmB-0008VT-4L for bug-gnu-emacs@gnu.org; Mon, 06 Jan 2025 05:56:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tUkmA-0005Eb-Rd for bug-gnu-emacs@gnu.org; Mon, 06 Jan 2025 05:56:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:From:In-Reply-To:References:MIME-Version:To:Subject; bh=zKA/q7d8wZWvtuVZnzUOoYEJeL9ZNj2/mBs6paXl0Bw=; b=bdjaJ2fCiDaU8cqc7myqZQ7F8zBvfk/okiLsbFdbLw1XJbLEa2h+Lx6Al46VbA9X8eM+jpuG+UJIsVU7nJ517k4IPkUrylfuu3XwYhLc4zcumBRuZphzF+HiJwywGwy67GoG4Igzz4CCYQxAeYQoUvfSE7DzUi3E6cSd17haEDIYU0bmauqywjvGXFX1oCVfGfc4j1HXAz0LejxWjk3IcN7Zai1IdyfNxoIpHHpUUgSb+olDBw7QD00L8sKojgTtOXGcBLBfnXVk3kA/+2CTYPj/G+YGo5uBkl4l7NYqCftSkRRH5KIi/7ATeweaVdBUZ6OaxTkK5T0QkD8y3wqXxg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tUkmA-0004eI-Lz for bug-gnu-emacs@gnu.org; Mon, 06 Jan 2025 05:56:02 -0500 Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Jan 2025 10:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 74914 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 74914@debbugs.gnu.org, joaotavora@gmail.com, brownts@troybrown.dev Original-Received: via spool by 74914-done@debbugs.gnu.org id=D74914.173616093617826 (code D ref 74914); Mon, 06 Jan 2025 10:56:02 +0000 Original-Received: (at 74914-done) by debbugs.gnu.org; 6 Jan 2025 10:55:36 +0000 Original-Received: from localhost ([127.0.0.1]:36891 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tUklj-0004dQ-QC for submit@debbugs.gnu.org; Mon, 06 Jan 2025 05:55:36 -0500 Original-Received: from mail-oa1-x29.google.com ([2001:4860:4864:20::29]:47448) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tUklg-0004dA-Sf for 74914-done@debbugs.gnu.org; Mon, 06 Jan 2025 05:55:34 -0500 Original-Received: by mail-oa1-x29.google.com with SMTP id 586e51a60fabf-2689e7a941fso4551451fac.3 for <74914-done@debbugs.gnu.org>; Mon, 06 Jan 2025 02:55:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736160931; x=1736765731; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=zKA/q7d8wZWvtuVZnzUOoYEJeL9ZNj2/mBs6paXl0Bw=; b=g5eWLE6GUpecFee6NPD+djVZAE9YECtSdpjTgQLqRXMMAra9xPVdnPASdCvZXkH/lO YIFwwTAgGcdxHC8brV2MYjsTOVHwmSo5a/c54lBNDgvngDtNSJ9hVldFqlIMNOErKp+J ZsabwXEgvZXvtUQP8G8ljrkQ8o0d4VvTrACaRalVkT6hFik7tmyO9q1gzWA/chbRwfM5 1WAnPq2T9W2w18uU1Svj2vbQpPOz/JX9LHvkysGFKc27/W9UE4MDlqX6bTl0oaZC4bZ0 SGUE+r0o3jq34+MwyZ0nLucISaVl5zX7vfZ38Bczq4FS8q3JIchk2mLyDw1dEVf5m08Q RQQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736160931; x=1736765731; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zKA/q7d8wZWvtuVZnzUOoYEJeL9ZNj2/mBs6paXl0Bw=; b=mm2M4Rn6Oj8UfPrsLcf81VB9cfzsQjR0RRiq2aT0x9An9AmfHA83XecnxsVCNiR64S RxraiDKdu+sGYnuPsKRKF7wJMO49tKh5qD+TQP9cDjvCQynvzgrSLYbM2aJjKfvX/DjY lcQoGU4Bw4ffe/EPaxaT3jAVdxNEHq2gEfS/RbnSckyUHtKbiT/NrW4Sniy/OkYmMPk+ HsohRlFG1ecEp5R67xPjV2gXZsy/zu+9p5kVXr76YIM6wecS5D+SGpmuIYOBkiGYXRbn fQK1rckwyAgWlSYhh/JaQOxtWhjksExAZRi8XY5pP+H8gsxYzCnM5P8odkZXsZKRP9qh KRPA== X-Forwarded-Encrypted: i=1; AJvYcCWKfYpwaY0StWIdVlR6rhlK9Yt2VYqcxcNnIhr/7N3kCDdUHuujfyPJtLFy4T7UnH9KZlfGWgCntekB@debbugs.gnu.org X-Gm-Message-State: AOJu0YwDtpqDMKNkZYA8CiSXBNEB9dKz+bm2SCIJEXxB43ZKLlgUR+WU xMZi/WzaQqTyzOIwr7HvpF6oHM9PzyP62CIqKhVoklYLZ+ketvomopJntclWwJQQQbQ8kPJQ/wO 2OxIXfxZenZN+PJalVIEDES9zu+I= X-Gm-Gg: ASbGnctA0CIDapg8tVSXruZ0Gcwn0ki3wT8ZUQqoe45jYn0c454hefK0tqLnY/XqdJd UTIUqaFY0UCKJLuNCvccH/73PDpXrO6qp0Oy8xA== X-Google-Smtp-Source: AGHT+IHnybNjrPE+L5ntKoWB/QjcRYeVDMFIDHK/Af/NpQE9FtyVaFLNrtW7X3oKpgpKIfhayzwsPklXbTJbtu7cS2A= X-Received: by 2002:a05:6871:d114:b0:296:e10f:af14 with SMTP id 586e51a60fabf-2a7fb4c9d62mr26037472fac.39.1736160931224; Mon, 06 Jan 2025 02:55:31 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:298644 Archived-At: I pushed this patch yesterday. Thanks everyone, closing the bug. On Sun, Jan 5, 2025 at 2:20=E2=80=AFAM Troy Brown w= rote: > > On Sat, Dec 28, 2024 at 10:22=E2=80=AFPM Dmitry Gutov = wrote: > > > > So, does this fix the problem for you? > > > > diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el > > index 816a1e67eca..51c19d5681a 100644 > > --- a/lisp/progmodes/eglot.el > > +++ b/lisp/progmodes/eglot.el > > @@ -3416,7 +3416,7 @@ eglot--sig-info > > 'font-lock-function-name-face)= ))) > > ;; Now to the parameters > > (cl-loop > > - with active-param =3D (or sig-active activeParameter) > > + with active-param =3D (or activeParameter sig-active) > > for i from 0 for parameter across parameters do > > (eglot--dbind ((ParameterInformation) > > ((:label parlabel)) > > > > I'm not sure how the diff was created, as I couldn't get it to apply > cleanly, but yes, this change does fix the issue. --=20 Jo=C3=A3o T=C3=A1vora