unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "João Távora" <joaotavora@gmail.com>
To: Troy Brown <brownts@troybrown.dev>, 74914-done@debbugs.gnu.org
Cc: Dmitry Gutov <dmitry@gutov.dev>,
	Felician Nemeth <felician.nemeth@gmail.com>
Subject: bug#74914: 30.0.90; Eglot: Incorrect parameter highlighted in signatureHelp
Date: Mon, 6 Jan 2025 10:55:26 +0000	[thread overview]
Message-ID: <CALDnm51FbT8YfOjmZgNxyiqpptWrOYNH27h1gqx0rNA=q2uRbA@mail.gmail.com> (raw)
In-Reply-To: <CABvCZ43Z+8nd49o4kNPwUe-LZ_-6x=KTJya5L9MYtvn-PiLczg@mail.gmail.com>

I pushed this patch yesterday.  Thanks everyone, closing the bug.

On Sun, Jan 5, 2025 at 2:20 AM Troy Brown <brownts@troybrown.dev> wrote:
>
> On Sat, Dec 28, 2024 at 10:22 PM Dmitry Gutov <dmitry@gutov.dev> wrote:
> >
> > So, does this fix the problem for you?
> >
> > diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
> > index 816a1e67eca..51c19d5681a 100644
> > --- a/lisp/progmodes/eglot.el
> > +++ b/lisp/progmodes/eglot.el
> > @@ -3416,7 +3416,7 @@ eglot--sig-info
> >                                          'font-lock-function-name-face))))
> >         ;; Now to the parameters
> >         (cl-loop
> > -       with active-param = (or sig-active activeParameter)
> > +       with active-param = (or activeParameter sig-active)
> >          for i from 0 for parameter across parameters do
> >          (eglot--dbind ((ParameterInformation)
> >                         ((:label parlabel))
> >
>
> I'm not sure how the diff was created, as I couldn't get it to apply
> cleanly, but yes, this change does fix the issue.



-- 
João Távora





      reply	other threads:[~2025-01-06 10:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-16 15:19 bug#74914: 30.0.90; Eglot: Incorrect parameter highlighted in signatureHelp Troy Brown
     [not found] ` <handler.74914.B.173436237328655.ack@debbugs.gnu.org>
2024-12-23 15:54   ` bug#74914: Acknowledgement (30.0.90; Eglot: Incorrect parameter highlighted in signatureHelp) Troy Brown
2024-12-28 11:33 ` bug#74914: 30.0.90; Eglot: Incorrect parameter highlighted in signatureHelp Eli Zaretskii
2024-12-28 13:28   ` João Távora
2024-12-29  3:22 ` Dmitry Gutov
2025-01-05  2:20   ` Troy Brown
2025-01-06 10:55     ` João Távora [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALDnm51FbT8YfOjmZgNxyiqpptWrOYNH27h1gqx0rNA=q2uRbA@mail.gmail.com' \
    --to=joaotavora@gmail.com \
    --cc=74914-done@debbugs.gnu.org \
    --cc=brownts@troybrown.dev \
    --cc=dmitry@gutov.dev \
    --cc=felician.nemeth@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).