From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#61368: [PATCH] Extend go-ts-mode with support for pre-filling return statements Date: Mon, 15 Jan 2024 11:40:45 +0000 Message-ID: References: <83edr0nmq6.fsf@gnu.org> <83357flzys.fsf@gnu.org> <83o7pov6li.fsf@gnu.org> <87ttnfvvmi.fsf@thornhill.no> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24410"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Evgeni Kolev , Eli Zaretskii , 61368@debbugs.gnu.org, Stefan Kangas , dev@rjt.dev To: Theodor Thornhill Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 15 12:42:29 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rPLML-00068Z-Lb for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 15 Jan 2024 12:42:29 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rPLM0-0002x5-I5; Mon, 15 Jan 2024 06:42:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rPLLv-0002wq-Gf for bug-gnu-emacs@gnu.org; Mon, 15 Jan 2024 06:42:04 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rPLLv-0000mi-8q for bug-gnu-emacs@gnu.org; Mon, 15 Jan 2024 06:42:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rPLLu-0003O3-CP for bug-gnu-emacs@gnu.org; Mon, 15 Jan 2024 06:42:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 15 Jan 2024 11:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61368 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 61368-submit@debbugs.gnu.org id=B61368.170531886612955 (code B ref 61368); Mon, 15 Jan 2024 11:42:02 +0000 Original-Received: (at 61368) by debbugs.gnu.org; 15 Jan 2024 11:41:06 +0000 Original-Received: from localhost ([127.0.0.1]:44818 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rPLKz-0003Mt-IN for submit@debbugs.gnu.org; Mon, 15 Jan 2024 06:41:05 -0500 Original-Received: from mail-lj1-x235.google.com ([2a00:1450:4864:20::235]:60448) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rPLKx-0003MF-8t for 61368@debbugs.gnu.org; Mon, 15 Jan 2024 06:41:03 -0500 Original-Received: by mail-lj1-x235.google.com with SMTP id 38308e7fff4ca-2ccec119587so105020141fa.0 for <61368@debbugs.gnu.org>; Mon, 15 Jan 2024 03:41:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705318857; x=1705923657; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=p4VRGFP0iYG5v3/0Y7lTCdnDAjEbav7Z4k+X7jG1vGo=; b=N8sDjSeNmvc6/9SBCncAjk+uhQ7x0FgjGhBNo+zbTqdkSrvci3uz4Pkw9wqY2bchfg hcvUD6Ybpd4pZ6LCzE4wWquKIoNli/2mv4Py0EW/KnU3rVo1PSbsII2zSvDPODMujmP5 s526Sx92ix2uB5waVIOBx64d/ZK4c/Sv3TSyyhk7CTCAvVauiBLg+Fnd2nLHKYz1HoN6 +0qNvWChQd7vBV2/SO+m5/7TA1CtPWcK2cFs0zQWP71fZbMKPKkwzctBzn8O5gpyNA88 kzTXGWOHz0GCskN7t9TuQ9x/Y/c9VNm0dkaeq7uZiMOlInrNTjKoefeCHeO/HudHY0Z3 6eKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705318857; x=1705923657; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=p4VRGFP0iYG5v3/0Y7lTCdnDAjEbav7Z4k+X7jG1vGo=; b=aK09zLT5tGPueJLlvld42+dsu6JUS9XaEh80UBIq1XxaXrSnKI50qY5q8F/IVqVGUX 7prCvsF8pPpBdyDE7p115Gd7wveyGRsIvI4zCmvw1NIH3XJasWD1pPopOk4zI2rnC9YJ H/bh1MhFOphVtneJgauYTG9s3Ely4lbtNN5fflDw0nRIz3ghyppoRAyXb2iSsOATzfNC wtLHCmB/Yw2Nz61978hmbrg9Ix19WLyYj7nSHJ4kvjyMajFFjSbAyPIRwGCZ3CutG9qh BsL/JGz2/mrUpfpkzItvUjuUGLS6db8rMhM7bZFoYPDKKP8Crehd8wiehYUhtLhFFoc1 Px2A== X-Gm-Message-State: AOJu0YxZY+lPaDIxEPtSDFZJUqvGAyyqwzoAc5Hvc6UGdaanT2mInXvr 6C1Die8Q6xHkU8ZeN9ISsoEdwQ4I7jhlNUIYdqs= X-Google-Smtp-Source: AGHT+IEDpMEFU+rle/U74z+YLwI6bP/KwSxzEi8a6i6XAxVC04MN4nPXar4jAhWaom70aFAoHGjilY2LSP1HH18KKdo= X-Received: by 2002:a05:651c:104d:b0:2cd:46c2:774 with SMTP id x13-20020a05651c104d00b002cd46c20774mr2610912ljm.97.1705318857211; Mon, 15 Jan 2024 03:40:57 -0800 (PST) In-Reply-To: <87ttnfvvmi.fsf@thornhill.no> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:278265 Archived-At: On Mon, Jan 15, 2024 at 8:39=E2=80=AFAM Theodor Thornhill wrote: > > Evgeni Kolev writes: > > > On Thu, Jan 11, 2024 at 12:43=E2=80=AFAM Stefan Kangas wrote: > >> > >> Evgeni Kolev writes: > >> > >> > Thank you, makes sense. I'll think about the different options and > >> > come up with a proposal. > >> > >> Did you make any progress here? > > > > I have since come across tempo.el and reviewed its use in org-tempo.el. > > > > While tempo.el is a valid option, I still think yasnippet is a better a= pproach. > > However, yasnippet is still not used throughout emacs' core (other > > than "light" uses > > in eglot.el and python.el, and some faces in the themes). > > > > Please let me know in case a generic mechanism for adding snippets to m= ajor > > modes has been added - I might have missed it. > > Perhaps it's time to revisit the snippet.el that Joao has mentioned? I've cleaned it up very minimally and put the most recent version here https://github.com/joaotavora/snippet It has unit tests which you can run with /path/to/emacs -Q --batch -l snippet-tests.el -f ert-run-tests-batch-and-ex= it Not many docs docs, some docstrings, many TODOs. Have a look.