From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#66041: 30.0.50; Should 'flymake-note-echo' inherit from 'compilation-info'? Date: Thu, 21 Sep 2023 22:40:20 +0100 Message-ID: References: <1f9e98be-3248-56cf-b7fd-8301666675c6@gmail.com> <1e19cc18-9942-aa51-c49e-9441e873f037@gmail.com> <83edivg3rg.fsf@gnu.org> <83zg1jemi8.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34399"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii To: Jim Porter , 66041-done@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 21 23:38:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qjRNI-0008jM-QE for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 21 Sep 2023 23:38:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qjRMw-0003ko-7D; Thu, 21 Sep 2023 17:37:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qjRMu-0003k8-FV for bug-gnu-emacs@gnu.org; Thu, 21 Sep 2023 17:37:52 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qjRMu-00070G-5j for bug-gnu-emacs@gnu.org; Thu, 21 Sep 2023 17:37:52 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qjRN4-0001tV-5f for bug-gnu-emacs@gnu.org; Thu, 21 Sep 2023 17:38:02 -0400 Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Thu, 21 Sep 2023 21:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 66041 X-GNU-PR-Package: emacs Mail-Followup-To: 66041@debbugs.gnu.org, joaotavora@gmail.com, jporterbugs@gmail.com Original-Received: via spool by 66041-done@debbugs.gnu.org id=D66041.16953322817276 (code D ref 66041); Thu, 21 Sep 2023 21:38:01 +0000 Original-Received: (at 66041-done) by debbugs.gnu.org; 21 Sep 2023 21:38:01 +0000 Original-Received: from localhost ([127.0.0.1]:34923 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qjRN3-0001tD-5w for submit@debbugs.gnu.org; Thu, 21 Sep 2023 17:38:01 -0400 Original-Received: from mail-lf1-x12d.google.com ([2a00:1450:4864:20::12d]:55299) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qjRN0-0001sy-Eu for 66041-done@debbugs.gnu.org; Thu, 21 Sep 2023 17:37:59 -0400 Original-Received: by mail-lf1-x12d.google.com with SMTP id 2adb3069b0e04-5043120ffbcso1563175e87.2 for <66041-done@debbugs.gnu.org>; Thu, 21 Sep 2023 14:37:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695332262; x=1695937062; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=VX2B5GyXQcbaYnUqB4DpD1Nl5rp/wdyt/fhdMzsetsQ=; b=fCAUUl2jSAGQlZ8CVnmoKtYE9lJw/7L4LCXdZAJYULsh+m0TObf0GjbD4eHP+PzTjK fcW432GYd34zqy7j2/1j7KKrsdsGdkS8z4rOU8BHekI3CKrjQusjOu4tTp3+MIg+iGsj 4L256HxmCfAHv2ZfWXCr3B14+DM05PL7Jx60tXUu/UeIV423+hsK3+GJOj0y5XT5vCMs iwOSeBeHcprUluQG9v3UZqmTYUyhKGzPdV2X4eUWwieloAPQ6JtouROm/8FmFRpcMJ+E yw4bMicZ3polfeFbmbmJKVNaQzoEa1UovlBY2puHSLHNlBoKxQUhzO9/cxNbUWOgWAaR wx8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695332262; x=1695937062; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VX2B5GyXQcbaYnUqB4DpD1Nl5rp/wdyt/fhdMzsetsQ=; b=WZ9dPEw64wA7VdZCQV4qF1z7PsHzZfAkKnX+iJABYJ8A/f21iBZEP+eNudnP5TgYa8 i+odSYLh5ZLVqQHL1sNZiYnyqqEtjukQCcsaJz40iWBCPjrmkyiLY3NMBjPEM84b+Bif LzpOjVmC18X3JO5kVvq65JUKXo4ypLE48RDI0/sM5hfBZl2P7uJ9uRiGYmdSjneUjJW1 eD9Ri33Qsh94HoLKpE0McwTp9oyWLEFZ1jujgI7jra2lxQFju+QkStcwxxzecQzIWgUK EGTIvMH7CDy2J19kNb76Oyxtx2GWXEf+2UhbeuTM2OjHcJz52DvoaEG0zjcHJTT6DfZd dI9Q== X-Gm-Message-State: AOJu0YzqoynRUNMICZJMu39p8A0b6Gs0p55wMqKcGAVjmwZwiddPhCdT 3KR2Pvp/W720ZevvYsHTsfBDRqdKv3wXUx+8ruI= X-Google-Smtp-Source: AGHT+IH/3zveBMU6rlv4GfbreMk0ueMFJ0MV1N46QeUcZdfZLviRDEGV8+CQSjJbJ2AjFHtbrpENoSVRNYxSBba3Sf4= X-Received: by 2002:a05:6512:158f:b0:500:9a45:636 with SMTP id bp15-20020a056512158f00b005009a450636mr7015474lfb.13.1695332261969; Thu, 21 Sep 2023 14:37:41 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:271028 Archived-At: On Mon, Sep 18, 2023 at 7:49=E2=80=AFPM Jo=C3=A3o T=C3=A1vora wrote: > That's possible to implement. > > But the single/multiple overlay decision is just an implementation detail > Currently Flymake uses one "end of line" overlay only, but here the logic > o control that uniqueness failed, so an extra unintended overlay was > created, and that created problems with cursor placement. > > But your suggestion is noted, though. Over the last 2 days, I've been working on this bug and pushed your patch. I also significantly reworked and robustified the end-of-line overlay logic= , fixing the two bugs I had identified. Then I also implemented your "and N more" suffix suggestion. Just set flymake-show-diagnostic-at-end-of-line to 'short'. I'm closing this bug, but let me know if you are satisfied with the changes or notice more points of possible improvement. Jo=C3=A3o