From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#61478: 28.2; eglot keeps sending `didSave` notifications despite the active server not supporting `textDocumentSync` Date: Mon, 13 Feb 2023 18:44:47 +0000 Message-ID: References: <43958a5c-a163-d1b3-5c1c-8a5ea3c1064d@tilde.team> <873579l8o7.fsf@betli.tmit.bme.hu> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000066e7e305f4993ee1" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15026"; mail-complaints-to="usenet@ciao.gmane.io" Cc: ~kby , 61478@debbugs.gnu.org To: Felician Nemeth Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Feb 13 19:47:00 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pRdqr-0003fw-Nt for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 13 Feb 2023 19:46:57 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pRdqK-0005y6-SH; Mon, 13 Feb 2023 13:46:25 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRdpz-0005YY-Db for bug-gnu-emacs@gnu.org; Mon, 13 Feb 2023 13:46:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pRdpz-0000nU-4U for bug-gnu-emacs@gnu.org; Mon, 13 Feb 2023 13:46:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pRdpy-0003aO-Gg for bug-gnu-emacs@gnu.org; Mon, 13 Feb 2023 13:46:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 13 Feb 2023 18:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61478 X-GNU-PR-Package: emacs Original-Received: via spool by 61478-submit@debbugs.gnu.org id=B61478.167631390513710 (code B ref 61478); Mon, 13 Feb 2023 18:46:02 +0000 Original-Received: (at 61478) by debbugs.gnu.org; 13 Feb 2023 18:45:05 +0000 Original-Received: from localhost ([127.0.0.1]:51556 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRdp3-0003Z4-Is for submit@debbugs.gnu.org; Mon, 13 Feb 2023 13:45:05 -0500 Original-Received: from mail-oi1-f176.google.com ([209.85.167.176]:45918) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRdp1-0003YH-R4 for 61478@debbugs.gnu.org; Mon, 13 Feb 2023 13:45:04 -0500 Original-Received: by mail-oi1-f176.google.com with SMTP id cz14so11010803oib.12 for <61478@debbugs.gnu.org>; Mon, 13 Feb 2023 10:45:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=sEcEGIuuJIVYbRQb5lOuUhdH45y47wGixqYWPVRCwF8=; b=YtoHpNBYTsd1QFm14DTG2btL8MP5YVY2aSbZUa2YcVHkaItxC/bR6b7tsHirGzqfTw awVAJHxtFITVNrdY7RoyFpw5pHirWQth6jbx40OEOpJHogXj9Q1qo/SyWX071cvGMGCo A+ie3JKHqgBF5fUQhYvjJTGL2r09NZNAJRPrvz/gmpoF8yRViS0EKyYyyzkzn4Lis5bQ RDwVLY4Z2nhaU8gXVcbI/zPcN8+CRA4vVKvVz3BYG4mHuDSh2hvk7K90uLT0X9zc//nF e3TekMWJVrHI6NTDI+jGw8Twmg/iV+ZJlKCcIGb5VR71Gg4BLRSQYt5XijXNGX06srds gzHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=sEcEGIuuJIVYbRQb5lOuUhdH45y47wGixqYWPVRCwF8=; b=pMwcebyCAnnsNrdBWkvn9s+OfEDhOEPGKnZkJXWlC8ik5A7zntj3QWwL3or3eoaqtI 1z535Nlsqm+nUak9KcngpERO3lWvg3YBPb1SdTtO5jJ+juHlNZ7q8pgXS6dOQyeZ1pCk sJeeg2oIFKt6n/iHsJpPZ7UFZ5MyGe+hMzoRzfTkgylrpbKDgomHmWeaSPYhAUw/oXjN vgb6Fge2yl3CEhh+f8Nh8VYYeF2I0QLiffBx/yvzmCMRkp2c5WnOapHJZSfI76y2BMDi KfMSsCQPw3uKStj1/4/RWXYf/syuH35x7tzUF0gfsnzoC3M7shlI48rYpnQVzLGO4bKi WgDw== X-Gm-Message-State: AO0yUKUGYfmd4jpuv/5slVI92y1A/GWUJZeZSuS02tudOdhMuwsUz4Ac PMrxX0d++YUp1vS4p0B+6ngRz/MH8YcEwe8pKSo= X-Google-Smtp-Source: AK7set8A1fMSP08fZmatINRl9+gt/lrbqngRLVnBtIL1OLLSYbfYakqusS7zKSPLkv8FEc6rJbSDnZr8vXpXLebPO3Q= X-Received: by 2002:a05:6808:18aa:b0:369:e573:3e54 with SMTP id bi42-20020a05680818aa00b00369e5733e54mr1866855oib.215.1676313897656; Mon, 13 Feb 2023 10:44:57 -0800 (PST) In-Reply-To: <873579l8o7.fsf@betli.tmit.bme.hu> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:255516 Archived-At: --00000000000066e7e305f4993ee1 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Yep, Felician, that is exactly it. Should be a straightforward patch. I'll do it, if noone beats me to it. Jo=C3=A3o On Mon, Feb 13, 2023, 18:30 Felician Nemeth wrote: > > - Following text appears in the minibuffer area: `[eglot] Server > > reports (type=3D1): Unknown method textDocument/didSave` > > Without actually looking into the details, this feels similar to an > earlier issue, which I unfortunately closed: > https://github.com/joaotavora/eglot/issues/360 > > The commit referenced in #360 only fixed the willSave part. I guess the > solution to this bug report should be probably similar to that fix: > Eglot should check (eglot--server-capable :textDocumentSync :save) > before sending a textDocument/didSave. > --00000000000066e7e305f4993ee1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Yep, Felician, that is exactly it. Should be a straightfo= rward patch. I'll do it, if noone beats me to it.

=
Jo=C3=A3o

On Mon, Feb 13, 2023, 18:30 Felician= Nemeth <felician.nemeth@gm= ail.com> wrote:
> - Follo= wing text appears in the minibuffer area: `[eglot] Server
>=C2=A0 =C2=A0reports (type=3D1): Unknown method textDocument/didSave`
Without actually looking into the details, this feels similar to an
earlier issue, which I unfortunately closed:
https://github.com/joaotavora/eglot/issues/= 360

The commit referenced in #360 only fixed the willSave part.=C2=A0 I guess t= he
solution to this bug report should be probably similar to that fix:
Eglot should check (eglot--server-capable :textDocumentSync :save)
before sending a textDocument/didSave.
--00000000000066e7e305f4993ee1--