From: "João Távora" <joaotavora@gmail.com>
To: Felician Nemeth <felician.nemeth@gmail.com>
Cc: ~kby <kby@tilde.team>, 61478@debbugs.gnu.org
Subject: bug#61478: 28.2; eglot keeps sending `didSave` notifications despite the active server not supporting `textDocumentSync`
Date: Mon, 13 Feb 2023 18:44:47 +0000 [thread overview]
Message-ID: <CALDnm518geis_e8fmb=z_Z6bo=M8uw1=U=mFTMnc_JMXYQpN7A@mail.gmail.com> (raw)
In-Reply-To: <873579l8o7.fsf@betli.tmit.bme.hu>
[-- Attachment #1: Type: text/plain, Size: 772 bytes --]
Yep, Felician, that is exactly it. Should be a straightforward patch. I'll
do it, if noone beats me to it.
João
On Mon, Feb 13, 2023, 18:30 Felician Nemeth <felician.nemeth@gmail.com>
wrote:
> > - Following text appears in the minibuffer area: `[eglot] Server
> > reports (type=1): Unknown method textDocument/didSave`
>
> Without actually looking into the details, this feels similar to an
> earlier issue, which I unfortunately closed:
> https://github.com/joaotavora/eglot/issues/360
>
> The commit referenced in #360 only fixed the willSave part. I guess the
> solution to this bug report should be probably similar to that fix:
> Eglot should check (eglot--server-capable :textDocumentSync :save)
> before sending a textDocument/didSave.
>
[-- Attachment #2: Type: text/html, Size: 1216 bytes --]
next prev parent reply other threads:[~2023-02-13 18:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-13 14:52 bug#61478: 28.2; eglot keeps sending `didSave` notifications despite the active server not supporting `textDocumentSync` ~kby via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-13 18:30 ` Felician Nemeth
2023-02-13 18:44 ` João Távora [this message]
2023-02-13 19:00 ` ~kby via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-13 23:50 ` João Távora
2023-02-14 12:01 ` Eli Zaretskii
2023-02-14 12:57 ` João Távora
2023-02-14 13:59 ` Eli Zaretskii
2023-02-14 14:12 ` João Távora
2023-02-14 14:40 ` Eli Zaretskii
2023-02-14 23:34 ` João Távora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALDnm518geis_e8fmb=z_Z6bo=M8uw1=U=mFTMnc_JMXYQpN7A@mail.gmail.com' \
--to=joaotavora@gmail.com \
--cc=61478@debbugs.gnu.org \
--cc=felician.nemeth@gmail.com \
--cc=kby@tilde.team \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).