From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#68450: 30.0.50; Eldoc fails to display argument tooltip for arguments inside (...) in `define-advice' Date: Sat, 20 Jan 2024 18:01:26 +0000 Message-ID: References: <87frz0rnuc.fsf@localhost> <83il3otkfd.fsf@gnu.org> <87fryrzynj.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40126"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , Ihor Radchenko , 68450@debbugs.gnu.org To: Thierry Volpiatto Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 20 19:02:09 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rRFfU-000AF8-Nz for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 20 Jan 2024 19:02:08 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rRFfN-0005xR-Uk; Sat, 20 Jan 2024 13:02:01 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rRFfL-0005wX-P1 for bug-gnu-emacs@gnu.org; Sat, 20 Jan 2024 13:01:59 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rRFfL-0007hS-EF for bug-gnu-emacs@gnu.org; Sat, 20 Jan 2024 13:01:59 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rRFfN-0008In-QM for bug-gnu-emacs@gnu.org; Sat, 20 Jan 2024 13:02:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 20 Jan 2024 18:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68450 X-GNU-PR-Package: emacs Original-Received: via spool by 68450-submit@debbugs.gnu.org id=B68450.170577371231899 (code B ref 68450); Sat, 20 Jan 2024 18:02:01 +0000 Original-Received: (at 68450) by debbugs.gnu.org; 20 Jan 2024 18:01:52 +0000 Original-Received: from localhost ([127.0.0.1]:35697 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rRFfD-0008IP-S5 for submit@debbugs.gnu.org; Sat, 20 Jan 2024 13:01:52 -0500 Original-Received: from mail-lf1-x135.google.com ([2a00:1450:4864:20::135]:51341) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rRFf9-0008I9-O2 for 68450@debbugs.gnu.org; Sat, 20 Jan 2024 13:01:51 -0500 Original-Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-50ea8fbf261so2200451e87.2 for <68450@debbugs.gnu.org>; Sat, 20 Jan 2024 10:01:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705773698; x=1706378498; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=i52TMnuY6fGRyXpUd/Rmgt7vNr7o9DmkRzPgHpyCAg4=; b=ixw0h8PynffAZK63MAWgAnC44Tvv8FCwY15tvJOOV91EU2LCeHOFDwtk5jnUheMjw/ sO5dvK2Do0OZQ2OvNYV4zhFxPP7lQad6YfM5f7kCbEKlixT62XaOblG8usddAIJZDli3 CfaZy+y+BOzrnzDFWtlCX+rB5jzDg7vl7f6MdymcgGXE59miehc5RXC9Zd3jByQIvP+X Cua3F1Wws9bnc73pJxHR78tjDdlKW0N21SWLDGlkBZaW4jLHX/Fn0BXcKbAc05rRv7qJ q0q5kmuORLbl5hGKSDBbmS8yCmX/NqNGOovAPP9jceMXo/Iw0dawxQebrPMxf+yyRsCM DbQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705773698; x=1706378498; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=i52TMnuY6fGRyXpUd/Rmgt7vNr7o9DmkRzPgHpyCAg4=; b=E4b0wHkO6tyUt2MZxIWwu+L9+St6T5wyMOnNhh1WWSq0r6RYtHYdLBz3/C/BIbbzMV hhr+GxYrIwuj7QwpoJxYM/iaEB3u6ZdRgdTSzFkDwYmW9PjvWIlPpwMzPAZMKvj0Tdjh aJ4csYwFMGTFfmhGJoIKsu71E4kxvxkO5Gr+xi80LZlnTjMb2/ryRjrBRKV091MR4Jdj 4brQRPny+/gSkXXwBOXxeE0RycIM6vs1RvpIH2qqvQpfC9nPjwi2UovqtartktO98q5Y CL3N9/vUv+MPPr5sYvGnrP39moKfSynnqPyctHYMkYPV1q0Euf0WJnZzCyDiS62ijROo fIlQ== X-Gm-Message-State: AOJu0YxG2ss+eCN1bvWoe8Lv0JEAQFaSEcZfVp4O5oJbBxsrB4KfKrRW 03YY024YSs2EHR9n9SpsgkobeEft3iHJX5TU46/Ux1DHz8i7/lq6d3CXdsX9mk1Jy/uGnRxDuls rYhm47q6utdROhH/j1dxqEalMrk4= X-Google-Smtp-Source: AGHT+IF+yIpZyiF2PpwJnvy3Zj3MJD8MRq3cWthT338xVi5jFArOrTEcgeNPtyFG+TlEgbJp8Zxt0FVrItvVmGNTbx4= X-Received: by 2002:a05:6512:1154:b0:50e:e680:cd4e with SMTP id m20-20020a056512115400b0050ee680cd4emr648363lfg.108.1705773698464; Sat, 20 Jan 2024 10:01:38 -0800 (PST) In-Reply-To: <87fryrzynj.fsf@posteo.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:278619 Archived-At: On Sat, Jan 20, 2024 at 5:45=E2=80=AFPM Thierry Volpiatto wrote: > > Jo=C3=A3o T=C3=A1vora writes: > > > On Sat, Jan 20, 2024 at 9:37=E2=80=AFAM Eli Zaretskii wr= ote: > > > >> > Expected: > >> > "define-advice: (SYMBOL (*HOW* LAMBDA-LIST &optional NAME DEPTH) &re= st BODY) > >> > still appears in the echo area. > >> > >> Thierry and Jo=C3=A3o, could you please look into this? > > > > I'm reasonably sure the source of this bug isn't in ElDoc per se, > > but in elisp-mode.el's use of eldoc.el facilities, > > Yes, probably, we have the same problem with (dolist (... > Slime handles this correctly IIRC, it has a nice library handling > signatures but I don't remember the details. Yes, you recall correctly. Like SLY, Slime's fork, it has some minimal sexp parsing logic that it makes use of in slime-autodoc.el. I'll see what I can do (if you don't beat me to it), but this is probably a very old bug: I don't remember Elisp ever handling this correctly. Jo=C3=A3o