From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#64859: 30.0.50; Eglot: codeAction.resolveSupport capability is incorrect Date: Fri, 2 Feb 2024 09:13:40 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32843"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Matan Peled , 64859@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Feb 02 10:15:21 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rVpdp-0008Ne-AY for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 02 Feb 2024 10:15:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rVpdN-0004zh-J7; Fri, 02 Feb 2024 04:14:53 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rVpdM-0004zT-2p for bug-gnu-emacs@gnu.org; Fri, 02 Feb 2024 04:14:52 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rVpdL-0004NZ-R0 for bug-gnu-emacs@gnu.org; Fri, 02 Feb 2024 04:14:51 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rVpdW-0004lB-5h for bug-gnu-emacs@gnu.org; Fri, 02 Feb 2024 04:15:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 02 Feb 2024 09:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64859 X-GNU-PR-Package: emacs Original-Received: via spool by 64859-submit@debbugs.gnu.org id=B64859.170686525118208 (code B ref 64859); Fri, 02 Feb 2024 09:15:02 +0000 Original-Received: (at 64859) by debbugs.gnu.org; 2 Feb 2024 09:14:11 +0000 Original-Received: from localhost ([127.0.0.1]:43731 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rVpch-0004jc-7X for submit@debbugs.gnu.org; Fri, 02 Feb 2024 04:14:11 -0500 Original-Received: from mail-lf1-x12a.google.com ([2a00:1450:4864:20::12a]:46525) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rVpce-0004jI-Te for 64859@debbugs.gnu.org; Fri, 02 Feb 2024 04:14:10 -0500 Original-Received: by mail-lf1-x12a.google.com with SMTP id 2adb3069b0e04-511207d62b6so2827100e87.1 for <64859@debbugs.gnu.org>; Fri, 02 Feb 2024 01:13:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706865232; x=1707470032; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=hPt6uYKVveQVE0Guo9Ox8Ia1gySOJo76KQhG4ff/Ehc=; b=juwa6IcjvBPAyFeLqTfcu9EV9N7hJ6pokEAAnhgSUZZvNTn7PF5ZIjOAtMFR2/rbI9 25QwotM+XY2GLGHIXTYiYFJ1IEK9pnXKLk3Ha0tS5ZszfmM3Ad0FwSYwJITGva0w7mbJ z5wga9cXATi7XLNGng1pAyyXVVh0yH59+9GWrV9k3lICLjzKkvMgOfXxz96KixEeY9xP zrmupVa/EEI3AgSBvCS+rn59kE+Fw87e+zhf8/aWSzH40OawPwCFS7jO87w6zSt6HLGW xsKLeE8Da5XocQHIHIv1rM47wTFXKJnZKHcZ/O9O7fTtQXFbUoBGWq0rjtbquB8KHgKf j3ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706865232; x=1707470032; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hPt6uYKVveQVE0Guo9Ox8Ia1gySOJo76KQhG4ff/Ehc=; b=eJCvlt4Jl3NqmUAI80O7coayuK62iWQKdaCPmyYPCooFXLKHU1l200Qc9tqxWm1+bv tH3ZLNb2ATE7eNYq/F/yKKg558N+bq4cyMGzCAPXRu/ro3OJi0hiRx1Si+nGSEMx6JBA vyAKVkR9kAVpU1448ojxGfE/cg8qdFAJG2B1aaKT2VRjbepIcEMjZUnwXZsqKd+W860I p3ib3pHnmwuE43ZTB8K0+n/uxQSxqOPP1pVhNYUj2lLsvDyd1DQ8NFFZh1izZ4mqCWRl upz9npmuP2YG/blBBwj12qhkK7+mEh26Wsb4RilVKsnOqPtmQhQceVuh6LBENrwkuMBR tiYA== X-Gm-Message-State: AOJu0YxZpes5Ph7IdV5UP9cOEhmwucPxJxgjfv1Zgj0DtfXC0OlWEEJF RiW2l2xnajhaSjtenjCAMcIWfzXA2ROeVE2lTQfaokL6ef/8PI4+3jA9y8uiu5AV7sAxpBo/LA0 GHOhGbOsk1ywWIQG4uHFF1mH16e8= X-Google-Smtp-Source: AGHT+IEc4pal8d0DHgDvmacWtA9iOq98zebRby09PPI1Wn0T6VB0OqG/h3JmFVXZZQXHV8S/b4IkqlikRaQiYdnfITg= X-Received: by 2002:a05:6512:3c8b:b0:511:1b24:9c29 with SMTP id h11-20020a0565123c8b00b005111b249c29mr3698869lfv.5.1706865232110; Fri, 02 Feb 2024 01:13:52 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:279340 Archived-At: On Fri, Feb 2, 2024 at 7:33=E2=80=AFAM Stefan Kangas wrote: > > Matan Peled writes: > > > I'm using a recent snapshot build. > > > > When trying to use Eglot on Rust code (with the rust-analyzer LSP > > server), it crashes complaining about the InitializationOptions message > > being misformed. > > > > This is due to this commit: > > https://git.savannah.gnu.org/cgit/emacs.git/commit/lisp/progmodes/eglot= .el?id=3D3b7273f4ae3623962c5d5fdc922a62af1136f448 > > > > resolveSupport is supposed to be a list, not a boolean, see here: > > https://microsoft.github.io/language-server-protocol/specifications/lsp= /3.17/specification/#textDocument_codeAction > > > > I'm not sure what properties Eglot supports here, so I'm not certain on > > what the correction should be. > > Jo=C3=A3o, any comments here? I think this was already fixed by: commit bc1e7b9b8e681346e407c4dc32272a0bf4decd68 Author: Jo=C3=A3o T=C3=A1vora Date: Wed Jul 12 10:11:34 2023 +0100 Eglot: fix advertisement of textDocument.codeAction.resolveSupport See https://github.com/joaotavora/eglot/issues/1255. * lisp/progmodes/eglot.el (eglot-client-capabilities): Use correct format for textDocument.codeAction.resolveSupport. I just didn't mention the debbugs id. Jo=C3=A3o